Re: Re: [wiki.synchro.net] page changed: module:logon
By: Mortifis to wiki.synchro.net on Mon Jul 15 2019 12:58 am
Wiki edit of http://wiki.synchro.net/module:logon by digital man:
[Logon] Mention the new email_validation option.
Woohoo, a very extensive update to the emailval.js module, I must say, this particular development is VERY much welcomed! Thank you!
I consider that a pretty minor change actually.
I didn't write this module, but I have some issues with its design:
1. It uses the user's security level as the sole indicator that the user's email address has not been validated. I think a flag or a separate user property (a newer concept, but completely doable at time this script was written by tracker1) would make more sense (just toggle the flag on/off). That way if the user changed their email address, let's say, you could require it to be re-validated without touching any other security settings.
2. It stores the random code and the successful validation result in the user's comment field. This is a bad idea. The sysop could have already put some useful comment there which would get blown-away by the script. Or the sysop may accidentally change/clear the pending code because they're using the user editor to add comments to users. Again, another use for a user property (see load/userprops.js and their example usage in other *.js files).
3. It requires the user to type the code, which I guess is okay and should be an option, but it'd be much more cool if the email included an http link that the user could just click to verify their email address. Like how the rest of the world does it. :-)
digital man
This Is Spinal Tap quote #36:
Bobbi Flekman: Money talks, and bullshit walks.
Norco, CA WX: 74.3øF, 62.0% humidity, 4 mph E wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net