• src/sbbs3/sbbsecho.c

    From rswindell@VERT to CVS commit on Fri Sep 21 15:15:04 2012
    src/sbbs3 sbbsecho.c 1.210 1.211
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13752

    Modified Files:
    sbbsecho.c
    Log Message:
    Address lack of error logging reported by Mindless Automation:
    use lprintf(LOG_ERR,...) instead of fprintf(stderr,...) to report errors opening or allocating memory for areas.bbs file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 28 21:49:44 2012
    src/sbbs3 sbbsecho.c 1.213 1.214
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2761

    Modified Files:
    sbbsecho.c
    Log Message:
    Experimental change for access_d:
    Use the 0000p###.su0 point system bundle base-filename scheme for FLO-style mailers (was previously only used for FD/attach-style mailers).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Tue Sep 3 16:32:55 2013
    src/sbbs3 sbbsecho.c 1.216 1.217
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15763

    Modified Files:
    sbbsecho.c
    Log Message:
    Whatever we needed windows.h for here is gone. this fixes the windows.h -> winsock.h / winsock2.h problem.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Sep 16 21:56:34 2013
    src/sbbs3 sbbsecho.c 1.218 1.219
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14764

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix for Joe Delahaye:
    Use zone information from packet header (rather than default/system zone)
    since packed message headers don't zone information - use this address
    for replying to AREAFIX requests.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Sep 17 02:20:56 2013
    src/sbbs3 sbbsecho.c 1.219 1.220
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25035

    Modified Files:
    sbbsecho.c
    Log Message:
    Finish fix for Joe Delahaye:
    Don't reset the origin zone in import_netmail().
    Fix-up type 2+ packet header parsing (ugh this is ugly).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Sep 27 18:04:40 2013
    src/sbbs3 sbbsecho.c 1.220 1.221
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30785

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix 2 bugs reported/root-caused by Deuce regarding corrupted/unpackable bundles:
    1. If the unpackable bundle file was more then 48 hours old, it would not try to rename it - the file date/time comparison logic was backwards and was trying to rename the file only if it was *less* than 48 hours old (and could in
    theory still be in transit).
    2. If the unpackable bundle file was more than 48 hours old, SBBSecho would continuously and indefinitely try to unpack it consuming CPU cycles and generating log output. Forever.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Oct 4 23:52:33 2013
    src/sbbs3 sbbsecho.c 1.221 1.222
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25548

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Wilfred van Velzen 2:280/464 introduced in rev 218: system's address was being added to SEEN-BY list twice when destination zone was different than the system's zone.
    Another experimental change for Joe (1:249/303) and Wilfred: when parsing SEEN-BYs from incoming packets, assume the zone of the nodes in the SEEN-BYs
    is the same as the origin zone of the packet, rather than the destination zone of the packet.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Thu Oct 24 21:15:00 2013
    src/sbbs3 sbbsecho.c 1.224 1.225
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30226

    Modified Files:
    sbbsecho.c
    Log Message:
    Quick "fix" for "%compression none" areafix command.
    May fix a crash, may eat your cat. If it breaks, you get to keep both
    the pieces.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Thu Oct 24 22:54:14 2013
    src/sbbs3 sbbsecho.c 1.225 1.226
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31439

    Modified Files:
    sbbsecho.c
    Log Message:
    More fixin's for the crash reported by access_d.



    ---
    þ Synchronet þ Vertrauen þ Home of Sync
  • From deuce@VERT to CVS commit on Mon Oct 28 13:34:38 2013
    src/sbbs3 sbbsecho.c 1.226 1.227
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22141

    Modified Files:
    sbbsecho.c
    Log Message:
    More fixin's for %compression none.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet
  • From deuce@VERT to CVS commit on Mon Oct 28 14:24:43 2013
    src/sbbs3 sbbsecho.c 1.227 1.228
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22625

    Modified Files:
    sbbsecho.c
    Log Message:
    Add a bit more %compresson none paranoia.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet
  • From Bill McGarrity@VERT to deuce on Mon Oct 28 18:18:00 2013
    deuce wrote to CVS commit <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22625

    Modified Files:
    sbbsecho.c
    Log Message:
    Add a bit more %compresson none paranoia.


    I take it this will be part of tomorrow's dev file?

    Enjoy

    Bill

    Telnet: bbs.tequilamockingbirdonline.net
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look TWICE.... Save a life. Motorcycles are EVERYWHERE!!
    --- MultiMail/Win32 v0.49
    þ Synchronet þ TequilaMockingbird Online - TELNET: bbs.tequilamockingbirdonline.net
  • From deuce@VERT to CVS commit on Mon Oct 28 17:25:00 2013
    src/sbbs3 sbbsecho.c 1.228 1.229
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24055

    Modified Files:
    sbbsecho.c
    Log Message:
    More %compression NONE fixin'
    DAMN YOU ALAN!


    ---
    þ Synchronet þ Vertrauen þ Home of Synchrone
  • From deuce@VERT to CVS commit on Tue Oct 29 14:10:24 2013
    src/sbbs3 sbbsecho.c 1.229 1.230
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14930

    Modified Files:
    sbbsecho.c
    Log Message:
    Clean up alter_config() a *lot*. Should now support unlimited line lengths. Note that it still assumes that teach arctype uses one line only. It will only add
    the specified node to one line, but every time it comes across a line with
    the old type, it will replace it with a new line containing every node which uses
    the old type. This is likely not what you want, so only use a single USEPACKER line per archiver type is you're modifying this by hand.

    I'm looking at you access_d. Your welcome.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Tue Oct 29 14:18:25 2013
    src/sbbs3 sbbsecho.c 1.230 1.231
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14990

    Modified Files:
    sbbsecho.c
    Log Message:
    No need to ensure ushorts are >= 0



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telne
  • From Corey@VERT to deuce on Tue Oct 29 14:53:51 2013
    Re: src/sbbs3/sbbsecho.c
    By: deuce to CVS commit on Tue Oct 29 2013 02:18 pm

    src/sbbs3 sbbsecho.c 1.230 1.231
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14990

    Modified Files:
    sbbsecho.c
    Log Message:
    No need to ensure ushorts are >= 0





    unless ushorts are still in the washer.

    "Practise safe Lunch, Use a Condiment"


    ---
    þ Synchronet þ Three Stooges Gentlemens Club - Las Vegas, Nv - tsgc.dyndns.org
  • From rswindell@VERT to CVS commit on Sat Jan 4 17:07:53 2014
    src/sbbs3 sbbsecho.c 1.231 1.232
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25028

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Joe Delahaye:
    Uplinks configured as "passive nodes" were still added to the seen-by lines
    of messages posted locally or passing through the system.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sun Jan 19 20:11:00 2014
    src/sbbs3 sbbsecho.c 1.233 1.234
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7791

    Modified Files:
    sbbsecho.c
    Log Message:
    Reimplement the zone-blind threshold logic: if *both* the local AKA zone and the compared (e.g. SEEN-BY, PATH) zone are equal to or less than the threshold, then the zone will be considered a local (not foreign) zone. (for access_d) Also, add logic to check for nodes with an illegal net value of 0 and exclude from PATH: lines. Reportedly, messages coming from Mike Powel's system (1:2320/105.1), running SBBSecho v2.12, have a path line with a node "0/0"
    in it - reported by Wilfred van Velzen (2:280/464).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 2 22:17:37 2014
    src/sbbs3 sbbsecho.c 1.234 1.235
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20687

    Modified Files:
    sbbsecho.c
    Log Message:
    Beautification of netmail_arealist(): no functional change (yet).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 2 22:54:17 2014
    src/sbbs3 sbbsecho.c 1.235 1.236
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20979

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix %UNLINKED AreaFix command response for configurations which use the ELIST_ONLY option: include unlinked echoes from "additional echolists" in the response (rather than just "None.").
    Created and used area_is_linked() function for the commonly copy/pasted code for checking if a specific node address is already linked with a specific area.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 2 23:48:07 2014
    src/sbbs3 sbbsecho.c 1.236 1.237
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21422

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve GCC error: 'for' loop initial declarations are only allowed in C99 mode Better/more log output when receiving AreaFix requests for echo/area lists.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 2 23:55:56 2014
    src/sbbs3 sbbsecho.c 1.237 1.238
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21623

    Modified Files:
    sbbsecho.c
    Log Message:
    Enable the delfile() (remove file retry loop) function for Win32 builds to see it resolves Joe's errors with areas.bbs modifications via AreaFix on Windows.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 3 00:12:07 2014
    src/sbbs3 sbbsecho.c 1.238 1.239
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21845

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix reversed logic for %QUERY and %UNLINKED areafix requests introduced in
    rev 236 (this this one, access===D).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 3 01:00:16 2014
    src/sbbs3 sbbsecho.c 1.239 1.240
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22491

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix compile failure in delfile() (for Windows only).
    Fix %LIST AreaFix response for ELIST_ONLY mode.
    Fix %UNLINKED AreaFix response for non-ELIST_ONLY mode (include echolists).
    Fix alter_areas() crash introduced in rev. 236 (j was not valid here).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 3 01:44:14 2014
    src/sbbs3 sbbsecho.c 1.240 1.241
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22855

    Modified Files:
    sbbsecho.c
    Log Message:
    Sort AreaFix area list request (e.g. %LIST, %QUERY, %UNLINKED) results (alphabetically) since pulling/merging from multiple lists (add'l echolists
    and the areas.bbs) often creates a confusing mix of sorted and unsorted area names.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 3 12:42:16 2014
    src/sbbs3 sbbsecho.c 1.241 1.242
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4923

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove trailing white-space from received area-fix commands.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 4 20:17:00 2014
    src/sbbs3 sbbsecho.c 1.242 1.243
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25024

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: packetized messages following an AreaFix netmail message would be skipped/ignored: import_netmail() moves the file position to the end of the message but returns non-zero (-2) when encountering an AreaFix message
    and the calling code assumes a non-zero return value indicates an error and
    the file position is somewhere *before* the end of the message (the NUL char). Resolved by saving the current file position before calling import_netmail() and restoring it after, so it matters not what improt_netmail does with the file pointer or what the return value is (in this case).
    Thanks for the report, Joe!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sat Apr 5 22:07:56 2014
    src/sbbs3 sbbsecho.c 1.243 1.244
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16673

    Modified Files:
    sbbsecho.c
    Log Message:
    Lots of string copy clean-up hoping to fix Joe's reported crashes in strupr().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sat Apr 5 22:26:45 2014
    src/sbbs3 sbbsecho.c 1.244 1.245
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16858

    Modified Files:
    sbbsecho.c
    Log Message:
    Get rid of tempname(), use tempnam() instead (supported everywhere we care).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Sun Apr 6 21:00:59 2014
    src/sbbs3 sbbsecho.c 1.245 1.246
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7683

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix error reported by access_d...
    SAFECOPY() ain't safe for pointers... use strdup() since that's what we
    want anyway.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sun Apr 6 21:39:19 2014
    src/sbbs3 sbbsecho.c 1.246 1.247
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8000

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve warning C4047: '=' : 'char *' differs in levels of indirection from 'int'

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 16 01:04:58 2014
    src/sbbs3 sbbsecho.c 1.247 1.248
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1127

    Modified Files:
    sbbsecho.c
    Log Message:
    Additional paranoia around additional echolist parsing in reponse to areafix requests - should handle more unexpected echolist lines (e.g. extra long, blank or whatever). Hopefully resolves crashes in strdup() Joe is seeing.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 17 00:11:54 2014
    src/sbbs3 sbbsecho.c 1.249 1.250
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1036

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix compile error introduced in previous commit: smb_faddrtoa(), not faddrtoa()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Tue May 6 20:36:36 2014
    src/sbbs3 sbbsecho.c 1.250 1.251
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3281

    Modified Files:
    sbbsecho.c
    Log Message:
    Since the beginning of time, a "PASSWORD" areafix command would remove
    all AREAFIX lines except for the one that was updated.

    This is apparently "bad". Stop doing this bad thing (We'll still delete AREAFIX lines without an address though).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Tue May 6 20:52:07 2014
    src/sbbs3 sbbsecho.c 1.251 1.252
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3464

    Modified Files:
    sbbsecho.c
    Log Message:
    While I'm looking at it, something similar appears to be happening with USEPACKER...
    Basically, if there are more than one USEPACKER lines of the same archive
    type as the new one, the user will be added to the first instance of the USEPACKER, and every other USEPACKER line of the same type will be deleted.

    We likely don't want to do that either.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 27 17:07:10 2014
    src/sbbs3 sbbsecho.c 1.252 1.253
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3883

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by access_d: was routing mail (when using a FLO mailer) even when the destination node was configured for "Direct". Apparently others have been working around this issue with a "Route to" configuration directive to route a node's netmail to itself. This work-around should no longer be necessary, but anyone that was depending on the old behavior (routing mail
    for nodes configured as "Direct") will need to adjust their configuration.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 27 19:25:40 2014
    src/sbbs3 sbbsecho.c 1.253 1.254
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7245

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug which caused the tear-line detection/conversion and origin line detection/conversion when exporting message text not work if the message contained line-feed terminated lines.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Sep 1 01:43:44 2014
    src/sbbs3 sbbsecho.c 1.254 1.255
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14891

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug where sbbsecho export pointer would be "fixed" to zero if the message base could not be opened for some reason.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Sep 4 19:08:04 2014
    src/sbbs3 sbbsecho.c 1.255 1.256
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22361

    Modified Files:
    sbbsecho.c
    Log Message:
    Log the netmail attribute value (from the message header) for debugging Access_D's reported problem with re-routed netmail.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sat May 2 06:59:49 2015
    src/sbbs3 sbbsecho.c 1.257 1.258
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21870

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix compile errors introduced with redefinition of post_t
    for sbbs_t::loadposts().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Jul 21 18:01:16 2015
    src/sbbs3 sbbsecho.c 1.258 1.259
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv9988

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to address Psi-Jack's reported problem:
    Don't pack netmail that has the "SENT" attribute flag set.
    Set the "SENT" attribute flag in netmail (.msg) files so if they're not deleted they won't be repacked/sent again later.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Psi-Jack@VERT to rswindell on Tue Jul 21 23:15:46 2015
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to address Psi-Jack's reported problem:
    Don't pack netmail that has the "SENT" attribute flag set.
    Set the "SENT" attribute flag in netmail (.msg) files so if they're not deleted they won't be repacked/sent again later.

    Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

    Tested outbound packing using:

    sbbsecho -linfd
    Confirmed in sbbsecho 2.27-Linux (rev 1.249)

    )))[Psi-Jack -//- Decker]

    ---
    þ Synchronet þ Decker's Heaven -//- bbs.deckersheaven.com
  • From Psi-Jack@VERT to rswindell on Wed Jul 22 00:32:43 2015
    Re: src/sbbs3/sbbsecho.c
    By: Psi-Jack to rswindell on Tue Jul 21 2015 11:15 pm

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to address Psi-Jack's reported problem:
    Don't pack netmail that has the "SENT" attribute flag set.
    Set the "SENT" attribute flag in netmail (.msg) files so if they're
    not deleted they won't be repacked/sent again later.

    Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

    Tested outbound packing using:

    sbbsecho -linfd
    Confirmed in sbbsecho 2.27-Linux (rev 1.249)

    Hold that thought.. It is working, but doing other wierd things.

    Sent flag did get set, second run of sbbsecho -linfd did not pack the netmail, however, I was sending to my point node in testing.

    Test node received it, acted like it came from the right address, but TO the same address, not the point node address. Re-sent it back to the main node, Synchronet on the main node then took that message, which was empty, and squashed the 1.msg with that new blank netmail message, not using 2.msg, or proper next message number..

    Packate type was 2+, trying 2.2 and 2 to see if any differences occur on this issue.

    The fact it literally squashes the original netmail is a bit concerning. (by squash, I mean effectively deletes/erases it, because it becomes empty, and because it gets overwritten as empty, then sbbsecho deletes that...)

    )))[Psi-Jack -//- Decker]

    ---
    þ Synchronet þ Decker's Heaven -//- bbs.deckersheaven.com
  • From Psi-Jack@VERT to rswindell on Wed Jul 22 01:24:58 2015
    Re: src/sbbs3/sbbsecho.c
    By: Psi-Jack to rswindell on Tue Jul 21 2015 11:15 pm

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to address Psi-Jack's reported problem:
    Don't pack netmail that has the "SENT" attribute flag set.
    Set the "SENT" attribute flag in netmail (.msg) files so if they're
    not deleted they won't be repacked/sent again later.

    Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

    Tested outbound packing using:

    sbbsecho -linfd
    Confirmed in sbbsecho 2.27-Linux (rev 1.259)

    Reverted back to 1.258 (correction made on earlier post, not 1.249 but 1.259)

    Something totally messes up the mailing to a point node with 1.259. Once I updated, when I would send mail from 1:135/371 to 1:135/371.1, the point node system would receive it as it if were addressed to 1:135/371, send it back to 1:135/371, empty, 1:135/371 would see an empty netmail, kill it, send a package back to 1:135/371.1, empty, and the point node would kill it because it's empty there too. That would end the cycle of it all.

    )))[Psi-Jack -//- Decker]

    ---
    þ Synchronet þ Decker's Heaven -//- bbs.deckersheaven.com
  • From rswindell@VERT to CVS commit on Wed Jul 22 14:21:48 2015
    src/sbbs3 sbbsecho.c 1.259 1.260
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3270

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
    Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Jul 22 16:46:14 2015
    src/sbbs3 sbbsecho.c 1.260 1.261
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5250

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix: set the correct "SENT" flag value, as reported by Psi-Jack.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT to rswindell on Wed Jul 22 20:15:00 2015
    rswindell wrote to CVS commit <=-

    src/sbbs3 sbbsecho.c 1.259 1.260
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3270

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
    Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the
    -d option.


    Rob...

    Will this be in the daily dev tomorrow?


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Wed Jul 22 17:53:39 2015
    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Wed Jul 22 2015 08:15 pm

    rswindell wrote to CVS commit <=-

    src/sbbs3 sbbsecho.c 1.259 1.260
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3270

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
    Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.


    Rob...

    Will this be in the daily dev tomorrow?

    It should be. The only time the daily dev build isn't updated (every morning) is when the build fails for some reason.

    digital man

    Synchronet "Real Fact" #58:
    Synchronet apparel and merchandise can be purchased at cafepress.com/synchronet Norco, CA WX: 79.2øF, 62.0% humidity, 15 mph SE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT to Digital Man on Thu Jul 23 01:10:00 2015
    Digital Man wrote to Bill McGarrity <=-

    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Wed Jul 22 2015 08:15 pm

    rswindell wrote to CVS commit <=-

    src/sbbs3 sbbsecho.c 1.259 1.260
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3270

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
    Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.


    Rob...

    Will this be in the daily dev tomorrow?

    It should be. The only time the daily dev build isn't updated (every morning) is when the build fails for some reason.

    Thank you sir!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
  • From deuce@VERT to CVS commit on Fri Aug 21 23:38:43 2015
    src/sbbs3 sbbsecho.c 1.261 1.262
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29984

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix warnings.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Mon Aug 24 18:41:21 2015
    src/sbbs3 sbbsecho.c 1.262 1.263
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24011

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix warning.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Sep 7 18:41:40 2015
    src/sbbs3 sbbsecho.c 1.263 1.264
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22861

    Modified Files:
    sbbsecho.c
    Log Message:
    Create BSO/FLO .REQ files for outbound file requests at the request (?) of Psi-Jack.
    Move the common outbound directory creation logic into a function.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Sep 7 19:15:05 2015
    src/sbbs3 sbbsecho.c 1.264 1.265
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23500

    Modified Files:
    sbbsecho.c
    Log Message:
    Append-to rather than over-write .req files, just incase one already exists. Needs a line-ending too, to support multple file requests in a single .req file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Sep 8 13:18:50 2015
    src/sbbs3 sbbsecho.c 1.265 1.266
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13625

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed typo in recent commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Oct 23 23:17:36 2015
    src/sbbs3 sbbsecho.c 1.266 1.267
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18170

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix problem reported by PSI-Jack and Bill Chaney: when no msg areas are defined in the system's areas.bbs file, SBBSecho would terminate prematurely with an error: "No areas defined in <path/to>areas.bbs". This would prevent SBBSecho from importing inbound netmail and packing outbound netmail, for example.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sat Oct 31 00:30:15 2015
    src/sbbs3 sbbsecho.c 1.267 1.268
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11437

    Modified Files:
    sbbsecho.c
    Log Message:
    Half-assed work-arounds for Accession/AxisD/Access_D/Nick:
    1. If the PATH kludge line only contains 1 address, don't use it for circular path detection.
    2. If the last address of the PATH kludge line is the system's address, don't add the system's address to the PATH.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Nov 23 02:04:43 2015
    src/sbbs3 sbbsecho.c 1.269 1.270
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30718

    Modified Files:
    sbbsecho.c
    Log Message:
    Create the NetMail directory if it doesn't already exist, in pkt_to_msg(), apparently SCFG wasn't creating this directory and SBBS only created it if you sent FTN netmail from the terminal server.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Dec 7 01:10:02 2015
    src/sbbs3 sbbsecho.c 1.271 1.272
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11921

    Modified Files:
    sbbsecho.c
    Log Message:
    Address a couple of concerns from Accession:
    Don't add TZUTC kludge lines to exported netmail and echomail messages when there is already a TZUTC FidoNet control line in the message header (unexpected but apparently, GoldEd+ does this).
    If there are other duplicate FTN control/kludge lines created by SBBSecho exporting messages added to SMBs by GoldEd+, we should address those too, even though I believe in most cases, you should configure the editor to *not* add these header fields in the first place.
    Do not convert exisiting Origin Line's to effectively comments (replacing * with # in " * Origin") if the current sub-board has been configured to not add network tag/origin-lines.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Dec 9 21:15:09 2015
    src/sbbs3 sbbsecho.c 1.272 1.273
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22813

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix crash in create_netmail(() introduced in last commit, when processing area-fix requests or generating any netmail not from the mail base.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Fat Rastus@VERT to rswindell on Thu Dec 10 08:44:47 2015
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Dec 09 2015 09:15 pm

    Still having issues. When a script tries to create an email/netmail or an NNTP Reader tries to upload a message the following error is generated:

    Dec 10 08:31:53 bbs synchronet: srvc 0024 NNTP !JavaScript /sbbs/exec/nntpservice.js line 836: Error: Error -110 adding SENDERNETADDR field to message header
    --- SBBSecho 2.30-Linux
    * Origin: Electronic Warfare BBS: Telnet://bbs.ewbbs.net (0:0/0)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Digital Man@VERT to Fat Rastus on Thu Dec 10 11:53:31 2015
    Re: src/sbbs3/sbbsecho.c
    By: Fat Rastus to rswindell on Thu Dec 10 2015 08:44 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Dec 09 2015 09:15 pm

    Still having issues.

    Maybe I misssed it, did you report a problem before?

    When a script tries to create an email/netmail or an
    NNTP Reader tries to upload a message the following error is generated:

    Dec 10 08:31:53 bbs synchronet: srvc 0024 NNTP !JavaScript /sbbs/exec/nntpservice.js line 836: Error: Error -110 adding SENDERNETADDR field to message header

    Thanks for the bug report. It should be fixed now.

    digital man

    Synchronet "Real Fact" #65:
    Synchronet was conceived of and mostly developed in southern California.
    Norco, CA WX: 65.0øF, 47.0% humidity, 3 mph E wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Lord Time@VERT to rswindell on Mon Dec 14 11:06:28 2015
    src/sbbs3 sbbsecho.c 1.272 1.273
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22813

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix crash in create_netmail(() introduced in last commit, when processing area-fix requests or generating any netmail not from the mail base.

    so that why I was having problems, the last few days, when someone netmail my sbbsecho, it had problems or didn't work the way it should


    ---

    Rob Starr
    Lord Time SysOp of
    Time Warp of the Future BBS
    Telnet://Time.Darktech.Org:24 or
    Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
    ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
    Yahoo : lordtime2000 AIM : LordTime20000 MSN : Lord Time
    Astra : lord_time X-Box : Lord Time 2000 oovoo : lordtime2000
    ---
    þ Synchronet þ Time Warp of the Future BBS - Home of League 10 IBBS Games
  • From rswindell@VERT to CVS commit on Wed Dec 30 10:44:32 2015
    src/sbbs3 sbbsecho.c 1.273 1.274
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27473

    Modified Files:
    sbbsecho.c
    Log Message:
    Additional debug-level log output anytime SBBSecho creates or appends a BSO/FLO file or creates a netmail message (*.msg) file. This will hopefully help to provide that evidence that either:
    A. there is a bug in SBBSecho with regards to passing mail to downlinks, or:
    B. Michiel van der Vlist is just a whimpering ass-hat

    ---
    þ Synchronet þ Vertrau
  • From Accession@VERT to rswindell on Wed Dec 30 18:03:36 2015
    Hello rswindell,

    On 30 Dec 15 10:44, rswindell wrote to CVS commit:

    src/sbbs3 sbbsecho.c 1.273 1.274
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27473

    Modified Files:
    sbbsecho.c
    Log Message:
    Additional debug-level log output anytime SBBSecho creates or appends
    a BSO/FLO file or creates a netmail message (*.msg) file. This will hopefully help to provide that evidence that either: A. there is a bug
    in SBBSecho with regards to passing mail to downlinks, or: B. Michiel
    van der Vlist is just a whimpering ass-hat

    LMFAO. This is definitely getting copy/pasted. You just made my day much more enjoyable.

    Regards,
    Nick

    --- GoldED+/LNX 1.1.5-b20151129
    * O
  • From rswindell@VERT to CVS commit on Fri Jan 1 13:24:34 2016
    src/sbbs3 sbbsecho.c 1.275 1.276
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12549

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix GCC build error introduced in last commit (and a couple warnings).

    ---
    þ Synchronet þ Vertra
  • From rswindell@VERT to CVS commit on Sat Jan 2 17:19:18 2016
    src/sbbs3 sbbsecho.c 1.277 1.278
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15175

    Modified Files:
    sbbsecho.c
    Log Message:
    More debug-level log message changes/additions.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchrone
  • From rswindell@VERT to CVS commit on Wed Jan 20 17:36:08 2016
    src/sbbs3 sbbsecho.c 1.278 1.279
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22493

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to addres Bill McGarrity's reported error:
    2016-01-20 06:06:39 ERROR line 1836 renaming c:\fd\outbound\20060640.pk_ to c:\fd\outbound\20060640.pkt
    I think this is because the file 200606040.pkt already existed when the
    .pk_ temp file was created and thus the rename will fail (can't rename over
    an existing file) and then the packet is sent to the wrong link.
    When generating a packet name, keep incrementing until both the .pkt and
    .pk_ variants do not already exist. This should fix this scenario.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 13 19:08:43 2016
    src/sbbs3 sbbsecho.c 3.1 3.2
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13162

    Modified Files:
    sbbsecho.c
    Log Message:
    Better error message for AREAS.BBS parsing problem (discovered by Lord Time): Display parsed FTN addresss instead of string from AREAS.BBS file. Hopefully this provides a better clue as to what is happening with his configuration.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 15 18:22:18 2016
    src/sbbs3 sbbsecho.c 3.2 3.3
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28913

    Modified Files:
    sbbsecho.c
    Log Message:
    Detect invalid Area File (AREAS.BBS) lines, report as a warning, and don't
    try to parse the link addresses.
    Example invalid line (echo-tag cannot contain spaces):
    VADA Virtual Advanced BBS Support 1:261/38

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Mon Apr 18 22:04:55 2016
    src/sbbs3 sbbsecho.c 3.3 3.4
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1325

    Modified Files:
    sbbsecho.c
    Log Message:
    No more malloc.h please... apparently it's needed for alloca() on Win32,
    but it doesn't look like that's used here...


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Mon Apr 18 22:05:56 2016
    src/sbbs3 sbbsecho.c 3.4 3.5
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1388

    Modified Files:
    sbbsecho.c
    Log Message:
    Comment out empry if statement.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 18 23:13:39 2016
    src/sbbs3 sbbsecho.c 3.5 3.6
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6216

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: insure ctrl dir value (read from SBBSCTRL env var) ends in a path separator (/ or \) before checking for mutex file.
    Don't require an exact match [node:x] section in sbbsecho.ini for every link
    in the area file (areas.bbs).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 20 22:29:15 2016
    src/sbbs3 sbbsecho.c 3.9 3.10
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24362

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix log output for "filtering due to age" message.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT to rswindell on Thu Apr 21 11:55:00 2016
    Hiya Rob...

    rswindell wrote to CVS commit <=-

    src/sbbs3 sbbsecho.c 3.9 3.10
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24362

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix log output for "filtering due to age" message.


    OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

    Problem signature:
    Problem Event Name: APPCRASH
    Application Name: sbbsecho.exe
    Application Version: 0.0.0.0
    Application Timestamp: 5718d044
    Fault Module Name: sbbsecho.exe
    Fault Module Version: 0.0.0.0
    Fault Module Timestamp: 5718d044
    Exception Code: c0000005
    Exception Offset: 0002dc4e
    OS Version: 6.0.6002.2.2.0.274.10
    Locale ID: 1033
    Additional Information 1: 6b6b
    Additional Information 2: 5d30f7473d03206ee7cab825049a8704
    Additional Information 3: 8f54
    Additional Information 4: 6c0aa36107156dd00f32b85c4d5fd0cb

    Read our privacy statement:
    http://go.microsoft.com/fwlink/?linkid=50163&clcid=0x0409

    I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

    Either way I reverted back to the previous version of sbbsecho.

    Thanks

    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Thu Apr 21 14:50:09 2016
    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Thu Apr 21 2016 11:55 am

    OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

    Problem signature:
    Problem Event Name: APPCRASH

    Thanks. Fix is imminent.

    I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

    No, the 2.2 packets will include the proper domain *if* the FTN_domains.ini exists (and is used), otherwise "fidonet" is always used as the src & dest domain values for type 2.2 packets.

    digital man

    Synchronet "Real Fact" #56:
    Synchronet introduced Telnet, FTP, SMTP and POP3 support w/v3.00a-Win32 in 2000.
    Norco, CA WX: 81.2øF, 21.0% humidity, 6 mph SE wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT to Digital Man on Fri Apr 22 07:24:00 2016
    Digital Man wrote to Bill McGarrity <=-

    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Thu Apr 21 2016 11:55 am

    OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

    Problem signature:
    Problem Event Name: APPCRASH

    Thanks. Fix is imminent.

    Great... glad I could help.


    I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

    No, the 2.2 packets will include the proper domain *if* the FTN_domains.ini exists (and is used), otherwise "fidonet" is always
    used as the src & dest domain values for type 2.2 packets.

    OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

    z1 = Fidonet
    z2 = Fidonet
    z24 = Sportnet

    etc??

    Thanks in advance!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Deuce@VERT to Bill McGarrity on Sat Apr 23 03:53:46 2016
    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to Digital Man on Fri Apr 22 2016 07:24 am

    OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

    A full config with two domains would currently be something like this:

    [fidonet]
    Zones=1,2,3,4,5,6,7
    DNSSuffix=binkp.net
    OutboundRoot=/sbbs/fido/fido

    [othernet]
    Zones=31337
    DNSSuffix=other.net
    OutboundRoot=/sbbs/fido/othernet

    SBBSEcho will only use the section name, Zones line, and OutboundRoot keys.

    In the future, there is likely to be a NodeList option as well (that SBBSEcho will also not use).

    ---
    þ Synchronet þ The future of BBSing
  • From Bill McGarrity@VERT to Deuce on Sat Apr 23 00:26:00 2016
    Deuce wrote to Bill McGarrity <=-

    Re: Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to Digital Man on Fri Apr 22 2016 07:24 am

    OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

    A full config with two domains would currently be something like this:

    [fidonet]
    Zones=1,2,3,4,5,6,7
    DNSSuffix=binkp.net
    OutboundRoot=/sbbs/fido/fido

    [othernet]
    Zones=31337
    DNSSuffix=other.net
    OutboundRoot=/sbbs/fido/othernet

    SBBSEcho will only use the section name, Zones line, and OutboundRoot keys.

    In the future, there is likely to be a NodeList option as well (that SBBSEcho will also not use).

    Gotcha.... thank you!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From rswindell@VERT to CVS commit on Wed Apr 27 14:15:12 2016
    src/sbbs3 sbbsecho.c 3.10 3.11
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25611

    Modified Files:
    sbbsecho.c
    Log Message:
    Possible bug fix for Joe Delahaye: don't include duplicate area tags in
    areafix responses to %LIST and %UNLINKED requests. If the same echo tag
    was listed in multiple additional echolists, it was possible it would
    appear multiple times in the areafix response list.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 27 14:38:51 2016
    src/sbbs3 sbbsecho.c 3.11 3.12
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27550

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Accession: Error "maximum open files reached"
    (paraphrased) encountered when performing a echomail rescan for link(s):
    When a packet reaches the configured "maximum packet size", finalize the
    packet immediately (terminate the packet and close the file) rather than waiting until the very end of all SBBSecho operations.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Joe Delahaye@VERT to rswindell on Wed Apr 27 19:49:56 2016
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 27 2016 14:15:12

    Possible bug fix for Joe Delahaye: don't include duplicate area tags in areafix responses to %LIST and %UNLINKED requests. If the same echo tag was listed in multiple additional echolists, it was possible it would appear multiple times in the areafix response list.


    As in my answer to Bill, changing the false to true fixed the problem. At least for me. I'll ask the downlink to check as well. In the meantime if this is part of the dailies I'll download it.
    --- SBBSecho 3.00-Win32
    * Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Digital Man@VERT to Joe Delahaye on Wed Apr 27 17:15:07 2016
    Re: src/sbbs3/sbbsecho.c
    By: Joe Delahaye to rswindell on Wed Apr 27 2016 07:49 pm

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 27 2016 14:15:12

    Possible bug fix for Joe Delahaye: don't include duplicate area tags in areafix responses to %LIST and %UNLINKED requests. If the same echo tag was listed in multiple additional echolists, it was possible it would appear multiple times in the areafix response list.


    As in my answer to Bill, changing the false to true fixed the problem. At least for me. I'll ask the downlink to check as well. In the meantime if this is part of the dailies I'll download it.

    If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

    digital man

    Synchronet "Real Fact" #5:
    Synchronet version 3 for Linux and FreeBSD development began in 2001.
    Norco, CA WX: 66.0øF, 54.0% humidity, 9 mph E wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Joe Delahaye@VERT to Digital Man on Wed Apr 27 22:02:31 2016
    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Joe Delahaye on Wed Apr 27 2016 17:15:07

    If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

    I have 2 echo lists, set up as you told me how. just the full fido echo name is listed in those. One is marked "Allowed", and the other is marked "Private". The flags used to be ALLO and SECR. They now are ALLOWED and SECRET, since it will now take many more characters. There are no dupes between these two lists. Areas.bbs is the only one that has all those names in it, but in areas.bbs format. Nothing has changed from the original setup in that respect. I requested my downlink to try another %list in areafix again. I just received a netmail. I will let you know if he succeed, but I see no reason he would not :)
    --- SBBSecho 3.00-Win32
    * Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Digital Man@VERT to Joe Delahaye on Thu Apr 28 00:24:51 2016
    Re: src/sbbs3/sbbsecho.c
    By: Joe Delahaye to Digital Man on Wed Apr 27 2016 10:02 pm

    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Joe Delahaye on Wed Apr 27 2016 17:15:07

    If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

    I have 2 echo lists, set up as you told me how. just the full fido echo name is listed in those. One is marked "Allowed", and the other is marked "Private". The flags used to be ALLO and SECR. They now are ALLOWED and SECRET, since it will now take many more characters. There are no dupes between these two lists. Areas.bbs is the only one that has all those names in it, but in areas.bbs format. Nothing has changed from the original setup in that respect. I requested my downlink to try another %list in areafix again. I just received a netmail. I will let you know if he succeed, but I see no reason he would not :)

    I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

    digital man

    Synchronet/BBS Terminology Definition #32:
    REP = QWK Reply
    Norco, CA WX: 53.9øF, 69.0% humidity, 5 mph NNE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Joe Delahaye@VERT to Digital Man on Thu Apr 28 10:47:19 2016
    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Joe Delahaye on Thu Apr 28 2016 00:24:51

    I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

    OK, I have downloaded the daily this morning (Eastern TIme), also got the latest js to change over the cfg file.

    ; Converted from /sbbs/ctrl\sbbsecho.cfg using sbbsecho_upgrade.js 1.11

    I now see the all the archivers in echocfg.
    --- SBBSecho 3.00-Win32
    * Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Digital Man@VERT to Joe Delahaye on Thu Apr 28 16:03:10 2016
    Re: src/sbbs3/sbbsecho.c
    By: Joe Delahaye to Digital Man on Thu Apr 28 2016 10:47 am

    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Joe Delahaye on Thu Apr 28 2016 00:24:51

    I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

    OK, I have downloaded the daily this morning (Eastern TIme), also got the latest js to change over the cfg file.

    ; Converted from /sbbs/ctrl\sbbsecho.cfg using sbbsecho_upgrade.js 1.11

    I now see the all the archivers in echocfg.

    Okay, thanks for the update.

    Here is the history of that script: http://cvs.synchro.net/cgi-bin/viewcvs.cgi/exec/sbbsecho_upgrade.js?sortby=date &view=log

    The oldest version that could be expected to work reasonably well with SBBSecho v3 was rev 1.9. And there were 2 bug fixes since then.

    digital man

    Synchronet/BBS Terminology Definition #30:
    NUL = ASCII 0
    Norco, CA WX: 67.2øF, 49.0% humidity, 7 mph ESE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Jun 29 18:42:29 2016
    src/sbbs3 sbbsecho.c 3.14 3.15
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1741

    Modified Files:
    sbbsecho.c
    Log Message:
    Address AreaFix bugs:
    1. Reported by Accession and Rastus: when linking/unlinking echoes via AreaFix,
    all the linked node addresses (in the areas.bbs file) would be changed to a
    garbage address (e.g. "16720:17235/19521.19551").
    Bug introduced in sbbsecho.c rev 3.13 (May-9-2016).

    2. Reported by Accession:
    Extraneous debug-level log output (a log line for each echo that exists in
    the area file): "Adding areas for <addr> to path/to/areas.bbs" and
    "Removnig areas for <addr> from path/to/areas.bbs".
    Introduced way back in sbbsecho.c rev 1.249 (Apr-17-2014).
    Now, a single debug-level log entries is added per areafix change request
    for all adds (area linking) and then all deletions (area unlinking) which
    makes much more sense.

    3. Observed in the code:
    When using AreaFix to modify the area file (areas.bbs), if a modified
    echo's internal code was 16 characters, exaclty, then no space would be
    added between the internal code and the echotag.
    This bug has apparently been possible since the introduction of internal
    code prefixes in 2003.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Jun 30 15:40:45 2016
    src/sbbs3 sbbsecho.c 3.15 3.16
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6872

    Modified Files:
    sbbsecho.c
    Log Message:
    When writing to area file (areas.bbs), pad echo tag to maximum length
    (35 chars). Use macros for maximum internal code length and echo tag lengths.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Jul 5 01:46:39 2016
    src/sbbs3 sbbsecho.c 3.16 3.17
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13698

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Jon Justvig with opening stray outbound packets:
    ERROR 2 (No such file or directory) opening stray packet: /sbbs/temp/sbbsecho/577ab8e4.pkt

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 10 17:49:50 2016
    src/sbbs3 sbbsecho.c 3.19 3.20
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31484

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: For outbound files destined for foreign zones, don't chop off the character of the default outbound directory *unless* it is a path delimiter (e.g. / or \) - for BSO only.
    Also minor optimization: don't call mkpath() unless isdir() returns false
    (on the outbound directory).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Oct 5 23:57:00 2016
    src/sbbs3 sbbsecho.c 3.20 3.21
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22493

    Modified Files:
    sbbsecho.c
    Log Message:
    Log a warning when a duplicate area is found in the area file (areas.bbs). Added (new) '-a' option to dump the parsed area file (areas.bbs) to stdout (useful for debugging area file issues).
    Only age-filtered messages can be relayed to downlinks now (not twit-filtered messages).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Oct 18 20:59:26 2016
    src/sbbs3 sbbsecho.c 3.21 3.22
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25445

    Modified Files:
    sbbsecho.c
    Log Message:
    More detail on the "Scanning" console output print statements so it's clear which are inboxes, the secure inbound and the non-secure inbound.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Nov 10 02:19:22 2016
    src/sbbs3 sbbsecho.c 3.22 3.23
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19346

    Modified Files:
    sbbsecho.c
    Log Message:
    SBBSecho will ignore all votes and poll messages (FTN doesn't support them). These messages would actually already be ignored due to the lack of a message body, but by checking the message attributes (and redundant msg 'type'), the msg headers for votes & polls aren't even loaded into memory. SBBSecho v2 should work just fine with msg bases that contain votes or polls as well.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Nov 17 22:24:01 2016
    src/sbbs3 sbbsecho.c 3.23 3.24
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16711

    Modified Files:
    sbbsecho.c
    Log Message:
    Move sbbsecho.bsy mutex file locking until *after* the configuratino files have been read. This way, the configured bsy_timeout value is used. Before, the value of 0 was used which results in an infinite timeout (max age) for the mutex, requiring a manual deletion of the file (no automatic recover) if SBBSecho happened to crash. Now, it'll use the default bsy_timeout value
    of 12 hours or the configured value in sbbsecho.ini.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Nov 22 16:58:43 2016
    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Lord Time@VERT/TIME to rswindell on Tue Nov 22 18:09:25 2016
    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)

    I hope that for the linux only not the windows one?


    ---

    Rob Starr
    Lord Time SysOp of
    Time Warp of the Future BBS
    Telnet://Time.Darktech.Org:24 or
    Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
    ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
    Yahoo : lordtime2000 AIM : LordTime20000 Astra : lord_time
    X-Box : Lord Time 2000 oovoo : lordtime2000
    ---
    þ Synchronet þ Time Warp of the Future BBS - Home of League 10 IBBS Games
  • From Digital Man@VERT to Lord Time on Tue Nov 22 20:39:51 2016
    Re: Re: src/sbbs3/sbbsecho.c
    By: Lord Time to rswindell on Tue Nov 22 2016 06:09 pm

    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)

    I hope that for the linux only not the windows one?

    Yup, Linux only. It was a build issue and I don't think you're buildling the code.

    digital man

    Synchronet/BBS Terminology Definition #35:
    NNTP = Network News Transfer Protocol
    Norco, CA WX: 57.5øF, 86.0% humidity, 0 mph SE wind, 0.01 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Lord Time@VERT/TIME to Digital Man on Tue Nov 22 21:23:56 2016
    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)

    I hope that for the linux only not the windows one?

    Yup, Linux only. It was a build issue and I don't think you're buildling the code.

    yep


    now did you see the message that called Re: docs/syncqnet.txt (it was from me to sbbs )?


    ---

    Rob Starr
    Lord Time SysOp of
    Time Warp of the Future BBS
    Telnet://Time.Darktech.Org:24 or
    Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
    ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
    Yahoo : lordtime2000 AIM : LordTime20000 Astra : lord_time
    X-Box : Lord Time 2000 oovoo : lordtime2000
    ---
    þ Synchronet þ Time Warp of the Future BBS - Home of League 10 IBBS Games
  • From Digital Man@VERT to Lord Time on Tue Nov 22 22:15:39 2016
    Re: Re: src/sbbs3/sbbsecho.c
    By: Lord Time to Digital Man on Tue Nov 22 2016 09:23 pm

    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)

    I hope that for the linux only not the windows one?

    Yup, Linux only. It was a build issue and I don't think you're buildling the code.

    yep


    now did you see the message that called Re: docs/syncqnet.txt (it was from me to sbbs )?

    No. If you post a message to "sbbs", it'll be eaten by the QWK import stuff as a QWK control message. Best to change the "to" line in that case.

    digital man

    Synchronet "Real Fact" #55:
    Synchronet Terminal Server introduced RLogin support w/v3.00c (2000).
    Norco, CA WX: 55.7øF, 87.0% humidity, 0 mph SSE wind, 0.01 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Lord Time@VERT/TIME to Digital Man on Wed Nov 23 00:02:09 2016
    src/sbbs3 sbbsecho.c 3.25 3.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1796

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed build error (signal, SIGTERM, not defined, etc.) and warning seen on Ubuntu 12.04.2 LTS (gcc v4.6.3)

    I hope that for the linux only not the windows one?

    Yup, Linux only. It was a build issue and I don't think you're buildling the code.

    yep


    now did you see the message that called Re: docs/syncqnet.txt (it was from me to sbbs )?

    No. If you post a message to "sbbs", it'll be eaten by the QWK import stuff as a QWK control message. Best to change the "to" line in that case.

    ok, I'll dig it out :

    docs syncqnet.txt NONE 1.1
    Update of /cvsroot/sbbs/docs
    In directory cvs:/var/www/html/docs

    Added Files:
    syncqnet.txt
    Log Message:
    Historic file documenting the Synchronet QWK Networking extensions
    (routed netmail, time zone kludges, etc).

    was just looking at that, is the contact info at the bottom right (note I wasn't going to use it, but someone would)?




    ---

    Rob Starr
    Lord Time SysOp of
    Time Warp of the Future BBS
    Telnet://Time.Darktech.Org:24 or
    Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
    ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
    Yahoo : lordtime2000 AIM : LordTime20000 Astra : lord_time
    X-Box : Lord Time 2000 oovoo : lordtime2000
    ---
    þ Synchronet þ Time Warp of the Future BBS - Home of League 10 IBBS Games
  • From Digital Man@VERT to Lord Time on Wed Nov 23 01:58:42 2016
    Re: Re: src/sbbs3/sbbsecho.c
    By: Lord Time to Digital Man on Wed Nov 23 2016 12:02 am

    Added Files:
    syncqnet.txt
    Log Message:
    Historic file documenting the Synchronet QWK Networking extensions (routed netmail, time zone kludges, etc).

    was just looking at that, is the contact info at the bottom right (note I wasn't going to use it, but someone would)?

    No, it's absolutely wrong. But I wanted to get this file into the revision control system (CVS) since I nearly lost it. I can now edit it to suit or even remove it if/when the same information is moved to the Wiki.

    digital man

    Synchronet/BBS Terminology Definition #40:
    R0DENT = Derogatory reference to a young BBS user of the 1990's
    Norco, CA WX: 52.0øF, 92.0% humidity, 0 mph E wind, 0.01 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Dec 6 10:50:57 2016
    src/sbbs3 sbbsecho.c 3.26 3.27
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24283

    Modified Files:
    sbbsecho.c
    Log Message:
    Make area file (e.g. areas.bbs) not case-sensitive. i.e. AREAS.BBS or areas.bbs or Areas.BBS will all be found/opened successfully if "areas.bbs" is used.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Feb 24 13:25:41 2017
    src/sbbs3 sbbsecho.c 3.28 3.29
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22342

    Modified Files:
    sbbsecho.c
    Log Message:
    2 Area-fix changes with regards to "pass-through areas":
    - %RESCAN returns a different failure result if the requested echo is a pass-through area (cannot be rescanned)
    - %UNLINKED will return only the unlinked echoes even when an "additional echolist" is utliized and the linked areas are all pass-through (for Bill).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to rswindell on Fri Feb 24 18:26:00 2017
    rswindell wrote to CVS commit on 02-24-17 13:25 <=-

    src/sbbs3 sbbsecho.c 3.28 3.29
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22342

    Modified Files:
    sbbsecho.c
    Log Message:
    2 Area-fix changes with regards to "pass-through areas":
    - %RESCAN returns a different failure result if the requested echo is a pass-through area (cannot be rescanned)
    - %UNLINKED will return only the unlinked echoes even when an
    "additional echolist" is utliized and the linked areas are all pass-through (for Bill).


    Thank you sir!!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net:81
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Sat Feb 25 12:31:39 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Fri Feb 24 2017 06:26 pm

    - %UNLINKED will return only the unlinked echoes even when an "additional echolist" is utliized and the linked areas are all pass-through (for Bill).


    Thank you sir!!!

    You're welcome. Thank you for the bug report.

    digital man

    Synchronet/BBS Terminology Definition #38:
    POP3 = Post Office Protocol version 3
    Norco, CA WX: 61.0øF, 42.0% humidity, 0 mph ENE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to Digital Man on Sat Feb 25 18:54:00 2017
    Digital Man wrote to Bill McGarrity on 02-25-17 12:31 <=-

    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Fri Feb 24 2017 06:26 pm

    - %UNLINKED will return only the unlinked echoes even when an "additional echolist" is utliized and the linked areas are all pass-through (for Bill).


    Thank you sir!!!

    You're welcome. Thank you for the bug report.

    Not a problem.... happy to help!!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net:81
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From rswindell@VERT to CVS commit on Mon Mar 6 12:48:02 2017
    src/sbbs3 sbbsecho.c 3.30 3.31
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21334

    Modified Files:
    sbbsecho.c
    Log Message:
    Added debug log output line for Bill McGarrity: the "echolists configured" number is particularly interesting to me given the error's he reported seeing.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Mar 21 18:33:00 2017
    src/sbbs3 sbbsecho.c 3.32 3.33
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32199

    Modified Files:
    sbbsecho.c
    Log Message:
    Change for Bill McGarrity: When exporting netmail from packets to .msg files, update the file path in the message subject to point to the inbound directory where the packet was found.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to rswindell on Wed Mar 22 01:52:00 2017
    rswindell wrote to CVS commit on 03-21-17 18:33 <=-

    src/sbbs3 sbbsecho.c 3.32 3.33
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32199

    Modified Files:
    sbbsecho.c
    Log Message:
    Change for Bill McGarrity: When exporting netmail from packets to .msg files, update the file path in the message subject to point to the
    inbound directory where the packet was found.


    Worked like a charm!!

    **** Start Log..

    SBBSecho v3.00-Linux (rev 3.33) - Synchronet FidoNet EchoMail Tosser



    Loading configuration files from /home/pi/sbbs/ctrl/

    SBBSecho 3.00-Linux r3.33 Mar 22 2017 GCC 4.9.2 invoked with options: -lesr

    7 packers, 41 linked-nodes, 1 echolists configured

    Reading /home/pi/sbbs/data/areas.bbs

    Read 98 areas from /home/pi/sbbs/data/areas.bbs



    Scanning /home/pi/sbbs/temp/sbbsecho/ for Stray Outbound Packets...



    Scanning for Inbound Packets...

    Scanning secure inbound: /home/pi/sbbs/sportnet/secure/

    Importing /home/pi/sbbs/sportnet/secure/58d20d9e.pkt (Type 2e, 0.8KB) from 24:120/0 to 24:24/1
    Bill McGarrity (24:120/0) To: jay Allsihire (24:120/3) Foreign address - Exporting: /home/pi/sbbs/netmail/1.msg Bill McGarrity (24:120/0) To: jay Allsihire (24:120/3) Exported to /home/pi/sbbs/netmail/1.msg



    Deleting /home/pi/sbbs/sportnet/secure/58d20d9e.pkt (from line 4941)

    Scanning non-secure inbound: /home/pi/sbbs/sportnet/inbound/



    Scanning for Inbound NetMail Messages...

    /home/pi/sbbs/netmail/1.msg Bill McGarrity (24:120/0) To: jay Allsihire (24:120/3) Foreign address



    Exporting Outbound NetMail from /home/pi/sbbs/data/mail to /home/pi/sbbs/netmail/*.msg ...



    Packing Outbound NetMail from /home/pi/sbbs/netmail/*.msg ...

    NetMail msg 1.msg from Bill McGarrity (24:120/0) to jay Allsihire (24:120/3): Packing NetMail (1.msg) from Bill McGarrity (24:120/0) to jay Allsihire (24:120/3), attr: 0011, subject: /home/pi/sbbs/sportnet/secure/test1.txt

    Node (24:120/3) successfully locked via: /home/pi/binkd-1.1/sportnet/outbound/00780003.bsy

    File (/home/pi/sbbs/sportnet/secure/test1.txt, 0.1KB) for 24:120/3 added to BSO/FLO file: /home/pi/binkd-1.1/sportnet/outbound/00780003.dlo

    Adding NetMail (1.msg) to new packet for 24:120/3: /home/pi/binkd-1.1/sportnet/outbound/00780003.dut
    Deleting /home/pi/sbbs/netmail/1.msg (from line 4292)



    Deleting /home/pi/binkd-1.1/sportnet/outbound/00780003.bsy (from line 2293)

    Deleting /home/pi/sbbs/ctrl/sbbsecho.bsy (from line 2297)

    SBBSecho exiting with error level 0, NetMail(0 imported, 0 exported, 1 packed), EchoMail(0 imported, 0 exported)

    **** End LOg


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net:81
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Wed Mar 22 11:17:46 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Wed Mar 22 2017 01:52 am

    Worked like a charm!!

    Good to know. :-)

    digital man

    Synchronet "Real Fact" #10:
    The name "DOVE-Net" was suggested by King Drafus (sysop of The Beast's Domain). Norco, CA WX: 61.4øF, 82.0% humidity, 6 mph E wind, 0.09 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 10 18:10:26 2017
    src/sbbs3 sbbsecho.c 3.33 3.34
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19760

    Modified Files:
    sbbsecho.c
    Log Message:
    Another change for Bill:
    Added (back) the '-d' command-line option to disable the deletion of processed (e.g. imported) inbound netmail messages.
    - This option has no effect if DeleteNetmail is set to "false" in sbbsecho.ini. - This option *only* disables deletion of incoming netmail (no effect on
    outbound netmail deletion)
    - In SBBSecho v2, the '-d' option disabled all netmail deletion, even though
    the help output only mentioned "netmail after import" (it was wrong).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to rswindell on Tue Apr 11 00:17:00 2017
    rswindell wrote to CVS commit on 04-10-17 18:10 <=-

    src/sbbs3 sbbsecho.c 3.33 3.34
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19760

    Modified Files:
    sbbsecho.c
    Log Message:
    Another change for Bill:
    Added (back) the '-d' command-line option to disable the deletion of processed (e.g. imported) inbound netmail messages.
    - This option has no effect if DeleteNetmail is set to "false" in sbbsecho.ini. - This option *only* disables deletion of incoming
    netmail (no effect on
    outbound netmail deletion)
    - In SBBSecho v2, the '-d' option disabled all netmail deletion, even though
    the help output only mentioned "netmail after import" (it was wrong).


    I love ya man.... :)


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Tue Apr 11 00:11:32 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Tue Apr 11 2017 12:17 am

    Added (back) the '-d' command-line option to disable the deletion of processed (e.g. imported) inbound netmail messages.

    I love ya man.... :)

    Does that mean it works for ya?

    digital man

    Synchronet "Real Fact" #7:
    The name "Synchronet" was suggested by Steve Deppe (Ille Homine Albe) in 1991. Norco, CA WX: 57.3øF, 59.0% humidity, 0 mph SW wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 16 20:54:26 2017
    src/sbbs3 sbbsecho.c 3.36 3.37
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv818

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Ray Quinn: node inbox paths (configured in sbbsecho.ini
    or via echocfg) were not automatically slash-terminated. So if the user did not provide the trailing slash (or backslash on Windows), then the bundles and packets in an inbox could not be extracted/imported.
    Also, fixed the truncation of area descriptions in the badareas.lst file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert|cvs|bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Oct 2 19:55:14 2017
    src/sbbs3 sbbsecho.c 3.38 3.39
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22209

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve warning.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Oct 18 13:16:23 2017
    src/sbbs3 sbbsecho.c 3.39 3.40
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8630

    Modified Files:
    sbbsecho.c
    Log Message:
    Track new stats per invocation of SBBSecho and report during the "signoff" ("Exiting") log message: packets sent, packets imported, bundles sent, and bundles unpacked.
    Signoff log messages is always logged when in "Debug" log level.
    Stat groups that are all zeroes are not logged in the "signoff" message.
    The inbound, secure_inbound, and outbound directories are now "full pathed", meaning relative paths become absolute paths, forward-slashes become backslashes (on Windows), etc. This makes the command-line generated and using these paths less likely to be incompatible with archive unpackers.
    The configured inbound/outbound paths are now logged in "Debug" log level mode. The optional "outgoing_sem" (used by binkit or tickit.js) is now touched under more circumstances (e.g. outbound bundle created without exporting any new mail).
    No longer log the "writing" bad areas file debug output.

    Area Manager changes:
    - Bug-fix: %PASSWORD was setting the wrong key in the [node] section of the
    sbbsecho.ini file (areafix_pwd -> AreafixPwd).
    - Enhancement: %PKTPWD command may now be used to change the ndoe's packet
    password. This change takes effect immediately, so additional packets in the
    same session or bundle would need to use the new password. This can be
    changes to take effect the next time SBBSecho is invoked instead, if desired. - Aliases for AreaMgr commands for commonly supported synonymous commands:
    %PWD -> %PASSWORD
    %COMPRESS -> %COMPRESSION
    %PAUSE -> %PASSIVE
    %RESUME -> %ACTIVE


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Oct 26 11:55:10 2017
    src/sbbs3 sbbsecho.c 3.41 3.42
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6617

    Modified Files:
    sbbsecho.c
    Log Message:
    Addition of echostats collection, a WIP

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Oct 26 12:04:21 2017
    src/sbbs3 sbbsecho.c 3.42 3.43
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6953

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in alter_areas() - the function for modifying the area file (areas.bbs) in response to AreaFix requests: this function attempted to support a trailing comment (beginning with a semicolon, but after any/all links) - but failed to so correctly. Since, forever. So it's unlikely sysops actually added trailing comments to their area file (or didn't provide AreaFix support to their downlinks), but this "feature" should actually work now. I considered just removing this support but decided to fix it instead, at least for now.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Oct 28 13:37:41 2017
    src/sbbs3 sbbsecho.c 3.45 3.46
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17667

    Modified Files:
    sbbsecho.c
    Log Message:
    Fixed an MSVC2013 compilation errors and a couple of NULL pointer dereferences introduced in the previous commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 29 16:17:59 2017
    src/sbbs3 sbbsecho.c 3.46 3.47
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13519

    Modified Files:
    sbbsecho.c
    Log Message:
    Parse the old pre-standard TZUTCINFO kludge line in fidomsg_to_echostat_msg() Use the SBBSecho PID info as the TID field, by default, in export echostats Don't include the Total* stats that are zero, in echostats (0 is assumed) Uppercase the echotag when auto-adding a sub to the Area File.
    Implemented long-awaited "bad echo" re-toss feature (use '-R' command-line option to enable).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 29 16:25:24 2017
    src/sbbs3 sbbsecho.c 3.47 3.48
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14499

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve several GCC warnings.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 29 16:29:52 2017
    src/sbbs3 sbbsecho.c 3.48 3.49
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15134

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve several GCC warnings.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 29 23:18:57 2017
    src/sbbs3 sbbsecho.c 3.49 3.50
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1965

    Modified Files:
    sbbsecho.c
    Log Message:
    Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
    Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Mon Oct 30 06:53:08 2017
    On 2017 Oct 29 23:18:56, rswindell wrote to CVS commit:

    src/sbbs3 sbbsecho.c 3.49 3.50
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1965

    Modified Files:
    sbbsecho.c
    Log Message:
    Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
    Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG

    i don't know that i'd specify "Fidonet" in that entry... just "Echomail" should
    work... there are other FTNs out there and they should not be restricted from this new auto-add feature should they? ;) QWK mail is not echomail, that's for
    sure :)

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... Pardon me! Where did you get the idea the whistle pulls the train???
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Mon Oct 30 15:26:18 2017
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Mon Oct 30 2017 06:53 am


    On 2017 Oct 29 23:18:56, rswindell wrote to CVS commit:

    src/sbbs3 sbbsecho.c 3.49 3.50
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1965

    Modified Files:
    sbbsecho.c
    Log Message:
    Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
    Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG

    i don't know that i'd specify "Fidonet" in that entry... just "Echomail" should
    work... there are other FTNs out there and they should not be restricted from this new auto-add feature should they? ;) QWK mail is not echomail, that's for
    sure :)

    It's a 25+ year old menu item under "Network Options" for sub-boards in SCFG.

    digital man

    This Is Spinal Tap quote #25:
    Viv Savage: Have... a good... time... all the time. That's my philosophy. Norco, CA WX: 68.1øF, 60.0% humidity, 9 mph ENE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to Digital Man on Mon Oct 30 21:33:30 2017
    On 2017 Oct 30 15:26:18, you wrote to me:

    i don't know that i'd specify "Fidonet" in that entry... just
    "Echomail" should work... there are other FTNs out there and they
    should not be restricted from this new auto-add feature should they?
    ;) QWK mail is not echomail, that's for sure :)

    It's a 25+ year old menu item under "Network Options" for sub-boards
    in SCFG.

    oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
    when i read it ;) ;) ;)

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... Our swords shall play the orators for us.
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Mon Oct 30 19:50:14 2017
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to Digital Man on Mon Oct 30 2017 09:33 pm


    On 2017 Oct 30 15:26:18, you wrote to me:

    i don't know that i'd specify "Fidonet" in that entry... just
    "Echomail" should work... there are other FTNs out there and they
    should not be restricted from this new auto-add feature should they?
    ;) QWK mail is not echomail, that's for sure :)

    It's a 25+ year old menu item under "Network Options" for sub-boards
    in SCFG.

    oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
    when i read it ;) ;) ;)

    The online help and documentation can (and will) be sure to make it clear that's it not just for "FidoNet proper", but I hesitate to rename SCFG options that haven't changed in forever since many people have written docs and how-to's using the current naming.

    digital man

    Synchronet/BBS Terminology Definition #42:
    SBBS = Synchronet Bulletin Board System
    Norco, CA WX: 60.9øF, 82.0% humidity, 2 mph E wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From MRO@VERT/BBSESINF to mark lewis on Mon Oct 30 22:12:23 2017
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to Digital Man on Mon Oct 30 2017 09:33 pm

    It's a 25+ year old menu item under "Network Options" for sub-boards
    in SCFG.

    oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
    when i read it ;) ;) ;)

    i dont think anybody's ever had a problem.
    ---
    þ Synchronet þ ::: BBSES.info - free BBS services :::
  • From rswindell@VERT to CVS commit on Mon Nov 6 16:53:46 2017
    src/sbbs3 sbbsecho.c 3.51 3.52
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1162

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug with export_echomail() introduced in rev 3.47 (Oct-29):
    - If SBBSecho is run in a mode to both import and export (e.g. no command-line
    options), the SMB pointer used when exporting would be crossed-up with the
    last sub-board imported into. This was the cause of the mass dupe flood from
    1:154/30 (mostly announcements from "New Files At War Ensemble BBS").

    Added a bit more log output with regards to bad echo area configuration and re-tossing (this was not related to the bug/fix above).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Nov 6 20:12:23 2017
    src/sbbs3 sbbsecho.c 3.52 3.53
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8451

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix "Bad-echo area" debug output.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Nov 6 22:52:27 2017
    src/sbbs3 sbbsecho.c 3.53 3.54
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15378

    Modified Files:
    sbbsecho.c
    Log Message:
    Huge performance improvement to read_echostats():
    - Don't search for the section (echo) for each key/value

    Added a debug-level log entry about the number of echostats read/parsed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to rswindell on Tue Nov 7 09:26:18 2017
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

    Hiya Rob...

    src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

    Modified Files: sbbsecho.c Log Message: Huge performance improvement
    to read_echostats(): - Don't search for the section (echo) for each key/value

    You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

    You the best..

    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: 6697
    Radio: radio.tequilamockingbirdonline.net:8010/live

    ---
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Digital Man@VERT to Bill McGarrity on Tue Nov 7 10:24:39 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Tue Nov 07 2017 09:26 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

    Hiya Rob...

    src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

    Modified Files: sbbsecho.c Log Message: Huge performance improve
    ement
    to read_echostats(): - Don't search for the section (echo) for each key/value

    You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

    You the best..

    Well the initial implementation was certainly not optimized. :-)

    digital man

    Synchronet/BBS Terminology Definition #52:
    TCP = Transmission Control Protocol
    Norco, CA WX: 70.8øF, 53.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to Digital Man on Tue Nov 7 20:06:00 2017
    Digital Man wrote to Bill McGarrity on 11-07-17 10:24 <=-

    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Tue Nov 07 2017 09:26 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

    Hiya Rob...

    src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

    Modified Files: sbbsecho.c Log Message: Huge performance
    mprove

    ement
    to read_echostats(): - Don't search for the section (echo) for each key/value

    You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

    You the best..

    Well the initial implementation was certainly not optimized. :-)

    Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Mickey@VERT/OXFORDMI to Bill McGarrity on Tue Nov 7 21:28:20 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to Digital Man on Tue Nov 07 2017 08:06 pm

    You ain't kidding. The previous versions since you've added echostats to about 40 seconds to run. Now it's 7 seconds for the entire mailin proces

    You the best..

    Well the initial implementation was certainly not optimized. :-)

    Hey, shit happens. I've just taken some heat from the Russians over dumping FTSC_Public. "F" um... :)



    Not your fault completely Bill. Im sure Trump had 'something' to do with it.

    p.s. ALmost back together here :-)

    Mick


    Central Ontario Remote BBS
    Fidonet 1:249/307 fsxNET 21:1/156

    ---
    þ Synchronet þ Central Ontario Remote - Campbellford, Cda
  • From Accession@VERT/PHARCYDE to Bill McGarrity on Tue Nov 7 21:11:46 2017
    Hello Bill,

    On Tue Nov 07 2017 20:06:00, Bill McGarrity wrote to Digital Man:

    Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)

    I honestly wanted to tell that guy to go kill himself, but deleted a lot of text and went with a more subtle reply. ;)

    Regards,
    Nick

    ... "Ðе знаю. Я здеÑÑŒ только работаю."
    --- GoldED+/LNX 1.1.5-b20170303
    * Origin: thePharcyde_ distribution system (Wisconsin) (723:1/1)
    þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)
  • From Bill McGarrity@VERT/TEQUILAM to Mickey on Wed Nov 8 13:42:00 2017
    Mickey wrote to Bill McGarrity on 11-07-17 21:28 <=-

    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to Digital Man on Tue Nov 07 2017 08:06 pm

    You ain't kidding. The previous versions since you've added echostats to about 40 seconds to run. Now it's 7 seconds for the entire mailin proces

    You the best..

    Well the initial implementation was certainly not optimized. :-)

    Hey, shit happens. I've just taken some heat from the Russians over dumping FTSC_Public. "F" um... :)



    Not your fault completely Bill. Im sure Trump had 'something' to do
    with it.

    Nah... Trump fck's up enough things on his own... I'll give him a pass on this one.

    p.s. ALmost back together here :-)

    Great!!


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Bill McGarrity@VERT/TEQUILAM to Accession on Wed Nov 8 13:43:00 2017
    Accession wrote to Bill McGarrity on 11-07-17 21:11 <=-


    On Tue Nov 07 2017 20:06:00, Bill McGarrity wrote to Digital Man:

    Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)

    I honestly wanted to tell that guy to go kill himself, but deleted a
    lot of text and went with a more subtle reply. ;)

    LOL... I noticed. Diplomacy is sometimes the better part of valour... :)


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From rswindell@VERT to CVS commit on Wed Nov 8 20:12:41 2017
    src/sbbs3 sbbsecho.c 3.54 3.55
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31270

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix for BSO/FLO mode: when packing netmail, if the netmail message has the "Crash" attribute set, don't route to the configured uplink.
    We really should do something similar for the "DIR" FLAGS kludge line, but that's more work (and isn't easily set on a per-msg basis, like crash is), so I'll revisit that later.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Nov 8 23:30:27 2017
    src/sbbs3 sbbsecho.c 3.55 3.56
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6659

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix for BSO/FLO mode: when packing netmail, if the netmail message has the "Hold" attribute set, don't route to the configured uplink. Just like the last commit, but now we actually create the proper cut/hut/out filename based on the status as well.
    Turns out, Crash and Hold NetMail was handled correctly in v2.x and was an un-reported regression (new bug) in v3.0.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Nov 9 00:07:00 2017
    src/sbbs3 sbbsecho.c 3.56 3.57
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7959

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix long-standing bug (since forever):
    When packetizing netmail, the "origin" address in the created packet header
    was copied from the netmail (*.msg) message file. This is fine for locally created netmail, but nof for forwarded netmail (!). This would end up creating outbound packets with a foreign source/origin address which may or may not
    be deliverable.

    Sort of related, if there are stray packets in the outbound directory with a foreign source/origin address - don't packetize them! Just log a msg and ignore these foreign outbound packets.

    This explains at least part of the problem Nelgin reported where a routed netmail was delivered to him (on Vert) from a hop running SBBSecho v3.01 and
    I saw this packet header oddity. Now, why the actual netmail message itself
    had the wrong origin address has not been identified.

    If your system routes netmail messages (e.g. your hub), you'll want his update!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to All on Thu Nov 9 00:31:49 2017
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Thu Nov 09 2017 12:07 am

    If your system routes netmail messages (e.g. your hub), you'll want his update!

    Let me restate that:

    If your system routes netmail messages (e.g. you're a hub), you'll want this update!

    It does amaze me how this bug was never reported, but I guess routed netmail just hasn't been widely utilized or scrutinized (when it didn't work). Thanks to Nelgin for trying all these things that theoretically should've been working for decades.

    digital man

    Synchronet "Real Fact" #19:
    The first Synchronet BBS (Vertrauen) went live in July of 1991 (replacing WWIV).
    Norco, CA WX: 57.6øF, 91.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Nov 12 20:15:47 2017
    src/sbbs3 sbbsecho.c 3.57 3.58
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix long-standing bug with routed (re-packed) netmail messages:
    The orig address in the packed msg header is (and still is) the proper
    local system address (this may be correct behavior, still checking), but
    no INTL control line (FSC-0004) was added, so the packed message header
    ends up defining the originating system address. So, now we include an
    INTL control line in packed netmail messages which reflects the actual
    origin address of the message. Thanks to Nigel Reed for helping to identify
    and test this problem over the past week or so.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Nov 13 00:56:02 2017
    src/sbbs3 sbbsecho.c 3.59 3.60
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to rswindell on Mon Nov 13 10:21:00 2017
    rswindell wrote to CVS commit on 11-13-17 00:56 <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.



    May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

    Thanks..




    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Lord Time@VERT/TIME to Bill McGarrity on Mon Nov 13 10:42:46 2017
    rswindell wrote to CVS commit on 11-13-17 00:56 <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.

    May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

    thanks, was going to say something like that :)


    ---

    Rob Starr
    Lord Time SysOp of
    Time Warp of the Future BBS
    Telnet://Time.Darktech.Org:24 or
    Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
    ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
    Yahoo : lordtime2000 AIM : LordTime20000 Astra : lord_time
    X-Box : Lord Time 2000 oovoo : lordtime2000 Skype : lordtime@tds.net
    ---
    þ Synchronet þ Time Warp of the Future BBS - Home of League 10 IBBS Games
  • From Digital Man@VERT to Bill McGarrity on Mon Nov 13 16:13:26 2017
    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Mon Nov 13 2017 10:21 am

    rswindell wrote to CVS commit on 11-13-17 00:56 <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.



    May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

    The nightly failed to build. I expect them to build successfully tomorrow AM.

    digital man

    Synchronet/BBS Terminology Definition #3:
    ASCII = American Standard Code for Information Interchange
    Norco, CA WX: 70.4øF, 51.0% humidity, 5 mph NNE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Bill McGarrity@VERT/TEQUILAM to Lord Time on Mon Nov 13 18:50:00 2017
    Lord Time wrote to Bill McGarrity on 11-13-17 10:42 <=-

    rswindell wrote to CVS commit on 11-13-17 00:56 <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.

    May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

    thanks, was going to say something like that :)


    :)


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From Bill McGarrity@VERT/TEQUILAM to Digital Man on Tue Nov 14 11:08:00 2017
    Digital Man wrote to Bill McGarrity on 11-13-17 16:13 <=-

    Re: src/sbbs3/sbbsecho.c
    By: Bill McGarrity to rswindell on Mon Nov 13 2017 10:21 am

    rswindell wrote to CVS commit on 11-13-17 00:56 <=-

    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Squash a couple of new GCC warnings.



    May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

    The nightly failed to build. I expect them to build successfully
    tomorrow AM.

    And that they did... :)

    Thank you...


    --

    Bill

    Telnet: tequilamockingbirdonline.net
    Web: bbs.tequilamockingbirdonline.net
    FTP: ftp.tequilamockingbirdonline.net:2121
    IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
    Radio: radio.tequilamockingbirdonline.net:8010/live


    ... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
    --- MultiMail/Win32 v0.50
    þ Synchronet þ TequilaMockingbird Online - Toms River, NJ
  • From rswindell@VERT to CVS commit on Tue Nov 28 17:23:41 2017
    src/sbbs3 sbbsecho.c 3.61 3.62
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2671

    Modified Files:
    sbbsecho.c
    Log Message:
    When packetizing netmail with an attachment (only one attached file is supported), remove the file path information from the message subject
    (it's not needed and could be seen as a security issue).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Nov 29 01:17:23 2017
    src/sbbs3 sbbsecho.c 3.62 3.63
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13760

    Modified Files:
    sbbsecho.c
    Log Message:
    When exporting netmail from the "mail" base, decode multipart MIME messages to get the "plain text" part only - this solves one problem with using an Internet email program to send NetMail. The next problem (ToDo) would be to extract MIME-encoded file attachment(s) and export them the FidoNet way.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Dec 2 11:33:34 2017
    src/sbbs3 sbbsecho.c 3.63 3.64
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5466

    Modified Files:
    sbbsecho.c
    Log Message:
    New feature: when exporting FTN netmail from the "mail" base, if the message has a MIME-encoded file attachment, decode that attachment into a file and attach to the message FTN-style.
    - This allows sending of FTN file attached netmail using your Internet email
    client.
    - Only a single attachment is supported (consistent with all attachment support
    in SBBSecho).
    create_netmail() enhancements:
    Don't add the FLAGS control line if we're in FLO-mode - this line is not used by BSO/FLO mailers.
    If there is a file attachment, but the message contains a subject, add a Subject: <original subject> line to the message body, since FTN requires the attached filename be placed in the subject.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Dec 8 11:37:52 2017
    src/sbbs3 sbbsecho.c 3.64 3.65
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18641

    Modified Files:
    sbbsecho.c
    Log Message:
    When packetizing netmail, don't add the INTL kludge line if it already
    exists in the message body.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Jan 9 13:15:37 2018
    src/sbbs3 sbbsecho.c 3.65 3.66
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20824

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix AreaFix "HELP" command response, broken in rev 3.59, reported by
    Rastus:
    file_to_netmail() assumed the file pointer was at the end of the file.
    This was not the case with the areamgr.hlp file (just opened, not read or seeked).
    Also, added some more error logging in case of file_to_netmail() failure.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Jan 21 14:46:08 2018
    src/sbbs3 sbbsecho.c 3.66 3.67
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25691

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't trim trailing white-space off of incoming MSGID and REPLY (reply-id) values. Apparently since this behavior is not not universal, it causes
    some systems to treat the 2 MSG-IDs (one with and one without trailing whitespace) as unique, causing potential dupes. Reported by Mark Lewis.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Feb 19 21:35:52 2018
    src/sbbs3 sbbsecho.c 3.67 3.68
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30298

    Modified Files:
    sbbsecho.c
    Log Message:
    Address many (but not all) Coverity reported "issues".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Feb 22 11:05:27 2018
    src/sbbs3 sbbsecho.c 3.69 3.70
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26643

    Modified Files:
    sbbsecho.c
    Log Message:
    Add BBS name and sysop name to PING netmail response message body.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Feb 22 12:59:03 2018
    src/sbbs3 sbbsecho.c 3.70 3.71
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7753

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix pong response bug introduced in previous commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Mar 31 20:37:37 2018
    src/sbbs3 sbbsecho.c 3.73 3.74
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv445

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs) if it didn't already exist.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 5 03:28:26 2018
    src/sbbs3 sbbsecho.c 3.74 3.75
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20684

    Modified Files:
    sbbsecho.c
    Log Message:
    Some status string (e.g. "Loading user names...") were being sent to stderr instead of stdout.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 5 17:49:22 2018
    src/sbbs3 sbbsecho.c 3.75 3.76
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Log an error if ftouch() fails to create the outbound sem file.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 5 20:02:58 2018
    src/sbbs3 sbbsecho.c 3.76 3.77
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Use GCC-assisted printf-style format/arg checking to find and fix instances
    of lprintf() misuse.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 6 10:55:44 2018
    src/sbbs3 sbbsecho.c 3.77 3.78
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1786

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 16 19:56:18 2018
    src/sbbs3 sbbsecho.c 3.78 3.79
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18475

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail included an "old-style" (not MIME-encoded) file attachment (where the file path is in the subject and the FILEATTACH aux-attribute flag is set), the corresponding netmail attribute flag would not be set in the stored msg (*.msg) file. Also simplified the create_netmail() function prototype/usage, removing the "file_attached" argument (use the hdr.auxattr instead).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 16 21:14:07 2018
    src/sbbs3 sbbsecho.c 3.79 3.80
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    write_flofile(): if the 'infile' path contains a drive letter prefix
    (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
    to forward-slashes (for all OSes). This resolves an issue of sending a
    netmail file-attachment that was created on a Windows/MS-DOS type system
    and then scanned/exported on a *nix system. The FTN "stored message"
    convention is to have the full path of the attached file in the message subject.

    Hopefully nobody wants to use outbound directory names beginning with "x:"
    on *nix. :-)


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 30 18:17:34 2018
    src/sbbs3 sbbsecho.c 3.80 3.81
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19737

    Modified Files:
    sbbsecho.c
    Log Message:
    If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in length, just delete it (don't rename to *.?_?).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 22 15:34:42 2018
    src/sbbs3 sbbsecho.c 3.81 3.82
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32044

    Modified Files:
    sbbsecho.c
    Log Message:
    When exporting msgs that came from an FTN (e.g. during a rescan), don't convert existing tear/origin lines and don't add a new origin line.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 22 21:16:51 2018
    src/sbbs3 sbbsecho.c 3.82 3.83
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2537

    Modified Files:
    sbbsecho.c
    Log Message:
    Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan (apparently this is a pseudo-standard supported by fastecho and other "old-school" tossers) - per mark lewis' request.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jun 4 12:07:36 2018
    src/sbbs3 sbbsecho.c 3.83 3.84
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17065

    Modified Files:
    sbbsecho.c
    Log Message:
    Address RMH's issue:
    When the local system has multiple AKAs for the same zone and we are picking a origin/source address suitable for the destination address, pick the AKA that matches both the zone and net of the destination address first (if there is such a local AKA). It's the same logic used in sbbs_t::netmail() to display
    the originating address, so the AKA picking logic now matches what is shown
    to the netmail author and what SBBSecho will actually use.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jun 4 13:56:38 2018
    src/sbbs3 sbbsecho.c 3.84 3.85
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28074

    Modified Files:
    sbbsecho.c
    Log Message:
    Another improvement to create_netmail():
    If the SMB header contains a source FTN address, use that as the origin address of the netmail and do not look-up a local AKA match for the destination address.
    Also, fix what appears to have been a (currently harmless) bug in smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail message headers, where the echostats come from. Could just remove
    these 2 lines.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Jun 19 12:01:05 2018
    src/sbbs3 sbbsecho.c 3.85 3.86
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18682

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing packets, don't export previously-rescanned messages
    (messages which contain the RESCANNED control line) to downlinks.

    Also renamed pkt_to_pkt() to write_to_pkts().


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 28 17:27:14 2018
    src/sbbs3 sbbsecho.c 3.87 3.88
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12172

    Modified Files:
    sbbsecho.c
    Log Message:
    When adding a new sub-board to the area file, if the sub has a "newsgroup"
    name specified, use that instead of the short name as the "Echo Tag"
    (Area Tag) value.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jul 30 13:43:15 2018
    src/sbbs3 sbbsecho.c 3.88 3.89
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14995

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix crash (segfault) reported in AreaFix handler for "-ALL", reported
    by Ragnarok@DOCKSUD.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Aug 2 22:48:00 2018
    src/sbbs3 sbbsecho.c 3.89 3.90
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Log an error if one or more file attachments could not be deleted when attempted.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Aug 2 23:37:20 2018
    src/sbbs3 sbbsecho.c 3.90 3.91
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13077

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't delete netmail file attachments: just because the netmail was exported
    to .msg file doesn't mean you should delete the file attachment! The .msg
    file will still be pointing to that file and it needs to be there.
    SBBSecho was silently failing to delete file attachments on my system, so
    I didn't see this problem. Oops. Anyway, this explains Al's problem with netmail attachments.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Sep 26 22:48:34 2018
    src/sbbs3 sbbsecho.c 3.92 3.93
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18679

    Modified Files:
    sbbsecho.c
    Log Message:
    Updated failure/error log messages for SMB library function call failures: always include the text description of the last error and the line number.
    The logging of the smb.file string is probably redundant since that path
    will likely be included in the last_error string.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Oct 16 12:27:58 2018
    src/sbbs3 sbbsecho.c 3.94 3.95
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25420

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug with AreaFix "ECHOSTATS" command: if the echotag specified was not found, it would be added to the list of echoes tracked in echostats.ini. Ideally, a negative-response message would be sent to requester in this case, but we're not doing that currently.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 28 23:29:28 2018
    src/sbbs3 sbbsecho.c 3.96 3.97
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1311

    Modified Files:
    sbbsecho.c
    Log Message:
    Requested change by Mark Lewis:
    can we get a slight change in the sbbsecho code or maybe in echocfg so that when a link is set to passive, areafix notices are NOT sent to them even if "send notices" is specifically set to yes?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to Digital Man on Mon Oct 29 12:56:12 2018
    On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    Requested change by Mark Lewis:
    can we get a slight change in the sbbsecho code or maybe in echocfg so
    that
    when a link is set to passive, areafix notices are NOT sent to them even
    if
    "send notices" is specifically set to yes?

    thank you... i'm guessing that the option in the config file toggles when links
    change their statuses? glad to see the change wasn't very involved :)

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... I generally prefer normal late-19th century cuisine. ML
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Mon Oct 29 12:01:53 2018
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to Digital Man on Mon Oct 29 2018 12:56 pm


    On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    Requested change by Mark Lewis:
    can we get a slight change in the sbbsecho code or maybe in echocfg so
    that
    when a link is set to passive, areafix notices are NOT sent to them even
    if
    "send notices" is specifically set to yes?

    thank you... i'm guessing that the option in the config file toggles when links
    change their statuses? glad to see the change wasn't very involved :)

    Right. That link setting is modifiable via areafix.

    digital man

    Synchronet/BBS Terminology Definition #19:
    DOCSIS = Data Over Cable Service Interface Specification
    Norco, CA WX: 76.9øF, 43.0% humidity, 0 mph E wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Nov 23 09:58:38 2018
    src/sbbs3 sbbsecho.c 3.98 3.99
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30801

    Modified Files:
    sbbsecho.c
    Log Message:
    Fuzzy Zone operation: make the implementation match the feature description/documentation more closely. That is, if there is an INTL kludge line in the incoming netmail message, there will be no "fuzzy" zone matching. This means that Fuzzy Zone operation will only apply to netmail messages that do *not* have an INTL kludge line (which specifies the source and destination zones already). This solves the problem reported by Mark Lewis with
    unexpected Fuzzy Zone behavior (when enabled), it was over-riding the
    source zone number even though it was specified (via INTL kludge) in the original netmail message body.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Dec 18 15:10:15 2018
    src/sbbs3 sbbsecho.c 3.99 3.100
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17849

    Modified Files:
    sbbsecho.c
    Log Message:
    Log a notice-level message when adding a new area to the unknown/bad area list.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Dec 18 15:21:43 2018
    src/sbbs3 sbbsecho.c 3.100 3.101
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18772

    Modified Files:
    sbbsecho.c
    Log Message:
    Change requested by Mark Lewis: accept area manager (areafix) netmail
    requests sent to "SBBSecho" again. SBBSecho used to allow this back in
    v3.02 (Nov-2017) and earlier versions, but was removed for loop-safety
    since AreaMgr notifications and responses are sent from "SBBSecho", but
    we have bot-loop protection built in, so that should be okay.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Jan 17 13:58:12 2019
    src/sbbs3 sbbsecho.c 3.102 3.103
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8260

    Modified Files:
    sbbsecho.c
    Log Message:
    Longer, hopefully more helpful, "Authenticated EchoMail" warning log msg.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Feb 11 19:14:48 2019
    src/sbbs3 sbbsecho.c 3.104 3.105
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3902

    Modified Files:
    sbbsecho.c
    Log Message:
    Restore the BRE inter-bbs netmail attachment work-around from SBBSecho v2:
    If the attached file begins with a '^', ignore/skip that character in the file path. This should resolve the error reported by Ken of Section One BBS:
    ERROR line 850, attachment file not found: ^C:/SBBS/XTRN/BRE777/...

    SBBSecho v2.x included this work-around and it was not included in the v3 re-factoring/re-write. Of course, BRE is doing something wrong and is totally at fault here, but no one expects BRE to be fixed... ever. :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Mar 19 12:48:22 2019
    src/sbbs3 sbbsecho.c 3.106 3.107
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23463

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix the off-by-one error in the COLS kludge line parsing logic.
    Don't store a columns value of 0 (the default).
    Use SAFEPRINTF in place of sprintf() in parse_control_line().


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Mar 19 13:46:15 2019
    src/sbbs3 sbbsecho.c 3.107 3.108
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32444

    Modified Files:
    sbbsecho.c
    Log Message:
    Add "COLS" kludge line to EchoMail msgs too (not just NetMail) - oops.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 12 12:39:45 2019
    src/sbbs3 sbbsecho.c 3.109 3.110
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7631

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove reference to removed/unused enum value: NET_FIDO_ASCII


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 15 03:32:39 2019
    src/sbbs3 sbbsecho.c 3.110 3.111
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15890

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix potential crash in create_netmail(), bug introduced in rev 3.108:
    When responding to AreaFix requests, it's normal for create_netmail() to be called with a NULL 'msg' argument value - so don't try to dereference it
    (for the "cols" header field value) if it's NULL. Thanks to Mark Lewis for the bug report.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Apr 28 23:14:18 2019
    src/sbbs3 sbbsecho.c 3.111 3.112
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31205

    Modified Files:
    sbbsecho.c
    Log Message:
    Use FIDO_SOFT_CR (0x8d) rather than the magic number

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 28 01:47:43 2019
    src/sbbs3 sbbsecho.c 3.114 3.115
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26186

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't warn about free disk space for directories that don't exist.
    Log free disk space errors to sbbsecho.log (as well as print to stdout).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jun 22 15:27:43 2019
    src/sbbs3 sbbsecho.c 3.115 3.116
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11356

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

    When processing area manager netmail messages, SBBSecho can modify
    (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

    Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the node for the sectoin naming.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Sat Jun 22 19:13:32 2019
    On 2019 Jun 22 15:27:42, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

    When processing area manager netmail messages, SBBSecho can modify (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

    i've seen this! never was able to spend time to try to figure out the problem so was unable to report the bug... glad to know that it has been found and fixed! yay!

    Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the
    node for the sectoin naming.

    that's like what tickit is doing when it hunts for a system's tic password... look for this and if not found, then look for the other form of address...

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... Don't corner something meaner than you.
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Jun 28 17:44:03 2019
    src/sbbs3 sbbsecho.c 3.116 3.117
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't need lzh.h here.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Jul 25 21:55:19 2019
    src/sbbs3 sbbsecho.c 3.120 3.121
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21629

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Fri Jul 26 11:47:38 2019
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm


    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is
    *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

    digital man

    Synchronet/BBS Terminology Definition #27:
    FOSSIL = Fido/Opus/SEAdog Standard Interface Layer
    Norco, CA WX: 90.5øF, 37.0% humidity, 4 mph N wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Fri Jul 26 13:00:42 2019
    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to mark lewis on Fri Jul 26 2019 11:47 am

    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm


    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

    Before today... :-)

    digital man

    Synchronet/BBS Terminology Definition #40:
    IMAP = Internet Message Access Protocol
    Norco, CA WX: 94.5øF, 34.0% humidity, 4 mph NNE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Fri Jul 26 12:10:28 2019
    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is
    *not* the start of a valid control paragraph (kludge line), then
    convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we
    don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes
    causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    )\/(ark

    Once men turned their thinking over to machines in the hope that this would set
    them free. But that only permitted other men with machines to enslave them.
    ... A bachelor lives like a king and dies like a beggar.
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jul 29 22:07:53 2019
    src/sbbs3 sbbsecho.c 3.122 3.123
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8880

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove unused variable.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jul 29 22:25:53 2019
    src/sbbs3 sbbsecho.c 3.123 3.124
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10902

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the
    delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me. The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in SBBSecho, so
    I'll just punt for now and do what Mark asked for. <shrug>


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Wed Jul 31 20:30:24 2019
    On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

    you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

    The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But
    parsing/using the "Flags" control line flags isn't already in
    SBBSecho,

    exactly...

    so I'll just punt for now and do what Mark asked for. <shrug>

    the main thing is the files are no longer killed... attached files really should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

    )\/(ark

    Once men turned their thinking over to machines in the hope that this would set
    them free. But that only permitted other men with machines to enslave them.
    ... But if the handwriting on the wall is a forgery?
    ---
    * Origin: (1:3634/12.73)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Thu Aug 1 00:40:15 2019
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Wed Jul 31 2019 08:30 pm


    On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

    you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

    The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in
    SBBSecho,

    exactly...

    so I'll just punt for now and do what Mark asked for. <shrug>

    the main thing is the files are no longer killed...

    They will be if the KILLSENT flag is sent (which is normal).

    attached files really
    should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

    Okay. I'll probably just add the KFS flag checking and remove the checking of the KILLSENT attr bit for that logic.

    digital man

    Synchronet/BBS Terminology Definition #9:
    BSO = Binkley Style Outbound
    Norco, CA WX: 66.2øF, 87.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Aug 2 01:31:15 2019
    src/sbbs3 sbbsecho.c 3.124 3.125
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19947

    Modified Files:
    sbbsecho.c
    Log Message:
    If SBBSecho imports a message with a "CHRS" control line with a value of "UTF-8", set the msg's auxattr MSG_HFIELDS_UTF8 flag because FTS-5003 states:
    "The character set identifier applies to all parts of the message,
    including the header information and the control lines like origin
    and tear line."


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Aug 2 02:22:58 2019
    src/sbbs3 sbbsecho.c 3.125 3.126
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29414

    Modified Files:
    sbbsecho.c
    Log Message:
    Use the \1FLAGS KFS (parsed crudely from netmail .msg body text) to trigger file-attachment deletion in write_flofile() - not the KILLSENT attribute flag. Export the SMB MSG_KILLSENT auxattr from SMB mail to FTN netmail \1FLAGS KFS.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 3 03:07:40 2019
    src/sbbs3 sbbsecho.c 3.126 3.127
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22270

    Modified Files:
    sbbsecho.c
    Log Message:
    Export a default CHRS: (charset) value of "UTF-8" when any of the header fields contain UTF-8 characters.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 3 04:31:10 2019
    src/sbbs3 sbbsecho.c 3.127 3.128
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2831

    Modified Files:
    sbbsecho.c
    Log Message:
    Same as previous commit, but for EchoMail this time (!).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 3 23:05:18 2019
    src/sbbs3 sbbsecho.c 3.128 3.129
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30083

    Modified Files:
    sbbsecho.c
    Log Message:
    Revamp the 0-byte inbound bundle handling:
    - Don't ever try to unpack a 0-byte file.
    - Don't log anything or try delete if the file is < 24 hours old.
    - Try to delete the file if it's >= 24 hours old (and log a msg, INFO-level).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Aug 4 00:01:38 2019
    src/sbbs3 sbbsecho.c 3.129 3.130
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4469

    Modified Files:
    sbbsecho.c
    Log Message:
    If failure to find a .msg netmail file attachment, don't bail (immediately exit), just log the error and continue processing. Reported by wkitty42.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Aug 4 13:16:43 2019
    src/sbbs3 sbbsecho.c 3.130 3.131
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Add missing %s printf args.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Aug 5 17:59:44 2019
    src/sbbs3 sbbsecho.c 3.131 3.132
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17560

    Modified Files:
    sbbsecho.c
    Log Message:
    Log the process-ID (PID) on the debug-level log lines: "invoked" and "exiting" Always log the "exiting" line when exiting with a non-zero error level.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Aug 16 14:06:56 2019
    src/sbbs3 sbbsecho.c 3.132 3.133
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10170

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing FTN TZUTC values, don't get fancy trying to convert to a US standard time-zone (e.g. -0300 == EST) as this is not accurate when daylight saving time is in effect (-0400 == EDT or AST?).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Aug 18 12:04:17 2019
    src/sbbs3 sbbsecho.c 3.133 3.134
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10866

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have
    a FLAGS kludge line.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Alterego@VERT/ALTERANT to Digital Man on Mon Aug 19 08:21:09 2019
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

    Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

    Ahh, you might have found it?

    I'll rebuild and try with the same message anyway...
    ...ëîå*

    ... Nursing Law: All the IV trees are at the other end of the hall.

    ---
    þ Synchronet þ Alterant | an SBBS in Docker on Pi!
  • From Digital Man@VERT to Alterego on Sun Aug 18 16:11:59 2019
    Re: src/sbbs3/sbbsecho.c
    By: Alterego to Digital Man on Mon Aug 19 2019 08:21 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

    Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

    Ahh, you might have found it?

    I think so.

    I'll rebuild and try with the same message anyway...

    Thanks!

    digital man

    Synchronet "Real Fact" #37:
    Synchronet's Windows Control Panel is built with Borland C++ Builder.
    Norco, CA WX: 84.4øF, 46.0% humidity, 15 mph NE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Aug 20 01:00:06 2019
    src/sbbs3 sbbsecho.c 3.134 3.135
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28445

    Modified Files:
    sbbsecho.c
    Log Message:
    Using the new lookup_user() function for destinatino user name look-ups.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 21 17:31:15 2019
    src/sbbs3 sbbsecho.c 3.136 3.137
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Beautify the "Adding sub-board" log message a bit.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 21 17:38:20 2019
    src/sbbs3 sbbsecho.c 3.137 3.138
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Log a notice-level msg if the configured areafile can't be opened.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Aug 26 20:47:56 2019
    src/sbbs3 sbbsecho.c 3.138 3.139
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6532

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't require that the last character of the "DateTime" field of packed messages is a null (0x00) byte. Some broken FidoNet software may include
    a full 20 usable characters in their DateTime header field, like so:
    "04 Feb 119 20:26:32" - representing February 4th, 2019. Y2K. <sigh>

    The DateTime won't be parsed fully correct, but at least the packet won't be rejected outright because it is "Grunged". - for Alterego (ALTERANT)


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Aug 29 17:58:44 2019
    src/sbbs3 sbbsecho.c 3.139 3.140
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23255

    Modified Files:
    sbbsecho.c
    Log Message:
    Revert last commit. The example packed message with the corrupted DateTime
    was not a recoverable message header (e.g. the toUserName field was *not*
    at offset 0x22):

    xx 02 00 01 00 01 00 6A - 02 FE 01 00 00 00 00 30 : .......j.......0
    34 20 46 65 62 20 31 31 - 39 20 20 32 30 3A 32 36 : 4 Feb 119 20:26
    3A 33 32 04 00 4B 75 72 - 74 20 57 65 69 73 6B 65 : :32..Kurt Weiske

    So restore the DateTime field validation: the 20th byte must be null.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Oct 8 15:54:25 2019
    src/sbbs3 sbbsecho.c 3.142 3.143
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27640

    Modified Files:
    sbbsecho.c
    Log Message:
    When exporting NetMail from data/mail.* to netmail/*.msg, map the SMB
    aux/net attributes to FidoNet msg header attributes:
    - CRASH
    - FILEREQUEST (FREQ)
    - RECEIPTREQ (RRREQ)

    This should fix the FREQ netmail issue reported by Richard Williamson (RICHARDF). Thanks for the bug report!


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Oct 16 21:01:43 2019
    src/sbbs3 sbbsecho.c 3.143 3.144
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15382

    Modified Files:
    sbbsecho.c
    Log Message:
    Attempt to re-create outbound directories in mutex (.bsy) file lock loop, just in case something (e.g. Argus mailer) deleted it while we were waiting our
    turn to use it. As reported by Alterego (ALTERANT)


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Oct 27 08:00:35 2019
    src/sbbs3 sbbsecho.c 3.144 3.145
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv398

    Modified Files:
    sbbsecho.c
    Log Message:
    More loop prevention: check a message's PATH in addition-to its SEEN-BYs in write_to_pkts():
    If for some weird reason a downlink's address is in the PATH, but not in the SEEN-BYs, detect as a loop and don't send to (add to an outbound pkt for) the downlink.

    This is an experimental change to see if it addresses the issue reported by Richard Williamson and Mark Lewis with regards to dupes in the COOKING
    echo from point nodes off 1:396/45.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Oct 30 11:52:32 2019
    src/sbbs3 sbbsecho.c 3.145 3.146
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3751

    Modified Files:
    sbbsecho.c
    Log Message:
    Even more loop-prevention paranoia:
    If a packed messages contains no PATH or SEEN-BY lines, we can still detect
    and prevent a message loop by comparing the origin address in the packet header against the downlink's address and if it's a match, skip that downlink.
    It is still possible that a packed message header contains a different origin address than the packet header, and we're actually over-writing the packed messge header variable with the parsed Origin: line address (if there is one), so perhaps we'll want to compare the (actual) packed message header origin address too at some point in the future, if loops continue to be a problem.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Nov 17 16:31:10 2019
    src/sbbs3 sbbsecho.c 3.146 3.147
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19001

    Modified Files:
    sbbsecho.c
    Log Message:
    Enhancement for Alterego (ALTERANT):
    Don't ever route netmail when the destination zone/net/node matches a local
    AKA (ignoring the point value).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Alterego@VERT/ALTERANT to Digital Man on Mon Nov 18 12:27:58 2019
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Nov 17 2019 04:31 pm

    Don't ever route netmail when the destination zone/net/node matches a local AKA (ignoring the point value).

    Actually, what will happen to it?

    I'm assuming if the point is defined in sbbsecho.ini, it will be packed for the downstream point.

    But what will happen otherwise? Perhaps it could be re-addressed to the sysop of the AKA, so that they are aware?
    ...ëîå*

    ... When two Englishmen meet their first talk is of the weather.

    ---
    þ Synchronet þ Alterant | an SBBS in Docker on Pi!
  • From Digital Man@VERT to Alterego on Sun Nov 17 19:02:53 2019
    Re: src/sbbs3/sbbsecho.c
    By: Alterego to Digital Man on Mon Nov 18 2019 12:27 pm

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Nov 17 2019 04:31 pm

    Don't ever route netmail when the destination zone/net/node matches a local AKA (ignoring the point value).

    Actually, what will happen to it?

    Normal processing, just not routed.

    I'm assuming if the point is defined in sbbsecho.ini, it will be packed for the downstream point.

    Yup.

    But what will happen otherwise? Perhaps it could be re-addressed to the sysop of the AKA, so that they are aware?

    I don't follow.

    digital man

    This Is Spinal Tap quote #44:
    It really, it does disturb me, but i'll rise above it; I'm a professional. Norco, CA WX: 75.1øF, 18.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Alterego@VERT/ALTERANT to Digital Man on Mon Nov 18 14:17:03 2019
    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Alterego on Sun Nov 17 2019 07:02 pm

    But what will happen otherwise? Perhaps it could be re-addressed to
    the sysop of the AKA, so that they are aware?
    I don't follow.

    What will happen to the incoming netmail where the point doesnt exist.

    IE: Somebody sends a netmail to 1:2/3.4 - and .4 is not configured in sbbsecho.ini, will:
    * The netmail still packed up into the outbound for when a .4 does eventually connect, or
    * The netmail will be discard
    * The packet will be renamed ".bad"...

    ?

    I'm wanting to know what will happen to the netmail and how will the sysop of 1:2/3 know about an incoming netmail destined for a point that has not been configured.
    ...ëîå*

    ... I think sex is better than logic, but I can't prove it.

    ---
    þ Synchronet þ Alterant | an SBBS in Docker on Pi!
  • From Digital Man@VERT to Alterego on Sun Nov 17 23:03:30 2019
    Re: src/sbbs3/sbbsecho.c
    By: Alterego to Digital Man on Mon Nov 18 2019 02:17 pm

    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Alterego on Sun Nov 17 2019 07:02 pm

    But what will happen otherwise? Perhaps it could be re-addressed to
    the sysop of the AKA, so that they are aware?
    I don't follow.

    What will happen to the incoming netmail where the point doesnt exist.

    IE: Somebody sends a netmail to 1:2/3.4 - and .4 is not configured in sbbsecho.ini, will:
    * The netmail still packed up into the outbound for when a .4 does eventually connect, or
    * The netmail will be discard
    * The packet will be renamed ".bad"...

    ?

    I'm wanting to know what will happen to the netmail and how will the sysop of 1:2/3 know about an incoming netmail destined for a point that has not been configured.

    The change I made was in pack_netmail(), so the netmail message would still be packed for the destination node, just as if there was no "route" entry matching its address. If the ".4" node ever does connect, it should get the packet with the netmail inside.

    digital man

    Synchronet "Real Fact" #83:
    Donations to the Synchronet project are welcome @ http://wiki.synchro.net/donate
    Norco, CA WX: 70.3øF, 21.0% humidity, 0 mph SW wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Nov 18 13:08:15 2019
    src/sbbs3 sbbsecho.c 3.147 3.148
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Update to previous commit: always read/use the destination node config,
    (e.g. for Hold status) even if/when it's a point off of us.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Jan 20 14:37:37 2020
    src/sbbs3 sbbsecho.c 3.149 3.150
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Log any error reading message header when exporting NetMail (from SMB to *.msg).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Jan 22 18:25:22 2020
    src/sbbs3 sbbsecho.c 3.150 3.151
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug introduced in rev 1.236 (April-3-2014):
    Areafix requests to unlink a node from an area would corrupt the list of
    linked nodes: the *last* listed node would always be removed. If this was
    not the node that submitted the areafix request, then 2 nodes would be
    removed from the list of linked-nodes for an echo.
    To simplify this, we're just going to not write the removed node back to
    the area file, but leave it in the in-memory list. So technically, the node won't be unlinked until the next run of SBBSecho when the area file is re-parsed. If that's a problem, we can always add run-time removal from
    the in-memory list later. Reported by Alterego (ALTERANT).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Mar 11 00:58:51 2020
    src/sbbs3 sbbsecho.c 3.151 3.152
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1945

    Modified Files:
    sbbsecho.c
    Log Message:
    Move debug log message ("NOT EXPORTING previously-rescanned message from: <addr>")
    to before the actual export, so that if an area has no downlinks, you won't actually see this errorneous but harmless log message. Also include the "export-to" address in the message.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Mar 23 17:55:05 2020
    src/sbbs3 sbbsecho.c 3.152 3.153
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25668

    Modified Files:
    sbbsecho.c
    Log Message:
    Include the echo Title (from an echolist), if found, in the echostats.ini.
    This makes this file more suitable for import into SCFG->Message Areas (something I'll work on soon), i.e. as an alternative to importing badareas.lst

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 3 00:06:59 2020
    src/sbbs3 sbbsecho.c 3.153 3.154
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5966

    Modified Files:
    sbbsecho.c
    Log Message:
    When writing badareas.lst, don't space-pad the areatags needlessly:
    calculate the longest tag first, then use that value for the padding.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 3 11:59:46 2020
    src/sbbs3 sbbsecho.c 3.154 3.155
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv9012

    Modified Files:
    sbbsecho.c
    Log Message:
    Reduce unnecessary padding of AreaTags in AreaFix responses.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 6 19:54:12 2020
    src/sbbs3 sbbsecho.c 3.156 3.157
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29346

    Modified Files:
    sbbsecho.c
    Log Message:
    Added some debug and error level log output to help Angel Ripoll figure out
    why his messages aren't being exported to packets.
    Don't increment the per-area-export counter when write_to_pkts() returns false.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 7 13:25:41 2020
    src/sbbs3 sbbsecho.c 3.157 3.158
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27213

    Modified Files:
    sbbsecho.c
    Log Message:
    Modify a single log message, the new "Added <area> message from x to packets": Track and log the packet-export exceptions (link packets that were *not* exported-to) and detail those exceptions (number of seen-bys, paths, origin address, etc.) which were triggered.
    This requires latest xpdev/str_list.*

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 7 13:28:48 2020
    src/sbbs3 sbbsecho.c 3.158 3.159
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27706

    Modified Files:
    sbbsecho.c
    Log Message:
    Make use of strListIsEmpty() - optimization.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 21 20:25:34 2020
    src/sbbs3 sbbsecho.c 3.159 3.160
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6003

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove attributes CRASH, HOLD, and LOCAL from the headers of netmail messages be unpacked into stored messages (.msg). Debug-level log message indicating that one or more attributes were removed (and which ones, in hex).
    This set of stripped attribute flags could easily be configurable, if that turns out to be desirable.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Apr 26 13:43:06 2020
    src/sbbs3 sbbsecho.c 3.160 3.161
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31899

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug reported by Mark Lewis (Rampage@SESTAR), when packing NetMail messages (from stored messages in .msg files into packets), the origin net/node within the *packed message* header would be set to the local system's address net/node (for the destination zone), always. This is the appropriate action when packing EchoMail, but not for NetMail.

    Now, there are lot of other header fields in the packed message that contain the source/origin address (e.g. @FMPT, @INTL kludges) and those would reflect the original origin address still. And these fields take precedence over the orign net/node fields of the packed message header. So I'm not sure this bug would actually cause any problems anywhere, but it was a bug all the same.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Apr 26 18:43:52 2020
    src/sbbs3 sbbsecho.c 3.162 3.163
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix bug in previous commit, 0-initialize the usernumber so that messages imported for robots actually have a 'to' index value of 0.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 27 00:01:38 2020
    src/sbbs3 sbbsecho.c 3.164 3.165
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    An extra debug-level log message when exporting a netmail from SMB.
    Don't add another tear-line (---) if one already exists, when creating
    netmail (.msg) stored messages.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 27 14:52:27 2020
    src/sbbs3 sbbsecho.c 3.165 3.166
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29169

    Modified Files:
    sbbsecho.c
    Log Message:
    MKDIR -> mkpath

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 27 18:24:21 2020
    src/sbbs3 sbbsecho.c 3.166 3.167
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1773

    Modified Files:
    sbbsecho.c
    Log Message:
    When exporting netmail from SMB->.msg, always set the "SENT" net-attribute
    and clear the "IN-TRANSIT" net-attribute of the original message, even if we're flagging it for deletion (the delete attribute could always be toggled off).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Apr 27 21:07:03 2020
    src/sbbs3 sbbsecho.c 3.167 3.168
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28557

    Modified Files:
    sbbsecho.c
    Log Message:
    When import netmail for robots, don't perform duplicate message body-text checking.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 29 21:34:37 2020
    src/sbbs3 sbbsecho.c 3.168 3.169
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11388

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing messages into a local msgbase that contained an origin line
    but no tear line, I noticed that the initial space before "* Origin" was absent from the tail. It turns out the missing space character was being appended to the end of the body text. While investigating why that was, I was dismayed at the cruftiness of code but totally suprised that there was 80-column word-wrap logic in here (!). Removed that word-wrap logic <blush> and fixed the origin thing. More clean-up coming up next.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 29 21:47:15 2020
    src/sbbs3 sbbsecho.c 3.169 3.170
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20270

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove unnecessary typecasts.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rampage@VERT/SESTAR to digital man on Thu Apr 30 07:56:04 2020
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 29 2020 21:34:37


    Modified Files:
    sbbsecho.c
    Log Message:
    When importing messages into a local msgbase that contained an origin
    line but no tear line, I noticed that the initial space before
    "* Origin" was absent from the tail. It turns out the missing space character was being appended to the end of the body text. While investigating why that was, I was dismayed at the cruftiness of code
    but totally suprised that there was 80-column word-wrap logic in here
    (!). Removed that word-wrap logic <blush> and fixed the origin thing.
    More clean-up coming up next.

    i'm glad you found this! i had thought to go rummaging through the code looking to see if there was such in place but the TODO list is quite long... i've been noticing a difference in the formatting of posts when compared to how they arrive via QWK and when they're gated to FTN... i'm curious to see if they're now more similar or exact to the QWK arrivals when seen on the FTN side... they should be, now, with this forced 80 column formatting removed :)


    )\/(ark

    ---
    þ Synchronet þ The SouthEast Star Mail HUB - SESTAR
  • From Digital Man@VERT to Rampage on Thu Apr 30 12:06:56 2020
    Re: src/sbbs3/sbbsecho.c
    By: Rampage to digital man on Thu Apr 30 2020 07:56 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 29 2020 21:34:37


    Modified Files:
    sbbsecho.c
    Log Message:
    When importing messages into a local msgbase that contained an origin line but no tear line, I noticed that the initial space before
    "* Origin" was absent from the tail. It turns out the missing space character was being appended to the end of the body text. While investigating why that was, I was dismayed at the cruftiness of code
    but totally suprised that there was 80-column word-wrap logic in here (!). Removed that word-wrap logic <blush> and fixed the origin thing. More clean-up coming up next.

    i'm glad you found this!

    If someone had asked, I would have said that SBBSecho did not do that.

    i had thought to go rummaging through the code
    looking to see if there was such in place but the TODO list is quite long... i've been noticing a difference in the formatting of posts when compared to how they arrive via QWK and when they're gated to FTN... i'm curious to see if they're now more similar or exact to the QWK arrivals when seen on the FTN side... they should be, now, with this forced 80 column formatting removed :)

    Cool, let me know what you find.

    digital man

    Synchronet "Real Fact" #45:
    Synchronet External "Plain Old Telephone System" support was introduced in 2007.
    Norco, CA WX: 73.9øF, 69.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Apr 30 17:08:23 2020
    src/sbbs3 sbbsecho.c 3.170 3.171
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14414

    Modified Files:
    sbbsecho.c
    Log Message:
    Always delete exported netmail if there's no SENDEREXT (from_ext) as this could result in orphaned sent-mail otherwise.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat May 2 16:04:49 2020
    src/sbbs3 sbbsecho.c 3.171 3.172
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23694

    Modified Files:
    sbbsecho.c
    Log Message:
    Resolve weird Clang warning: format specifies type 'unsigned short' but the argument has type 'int'

    So a (ushort&ushort) == int? That makes no sense.When in doubt, typecast!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 19 21:53:37 2020
    src/sbbs3 sbbsecho.c 3.172 3.173
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv953

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix issue reported by Alterego:
    Don't auto-add sub-boards to the area file if the echotag is already in the area file (but marked as pass-through or associated with a different sub-board already). This configuration could result in the same sub-board(s) being auto-added to the area file for every invocation of sbbsecho.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Jul 15 21:11:55 2020
    src/sbbs3 sbbsecho.c 3.173 3.174
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22900

    Modified Files:
    sbbsecho.c
    Log Message:
    If an export netmail message has MSGID/REPLY header fields, add those as kludges (needed for including message-IDs in exported netmail).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 18 20:42:28 2020
    src/sbbs3 sbbsecho.c 3.174 3.175
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1776

    Modified Files:
    sbbsecho.c
    Log Message:
    Extra log level message (INFO, WARNING, and DEBUG) when moving netamil file attachments (attached files) - for debugging the issue reported by
    alterego (ALTERANT)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Jul 19 11:50:39 2020
    src/sbbs3 sbbsecho.c 3.175 3.176
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10832

    Modified Files:
    sbbsecho.c
    Log Message:
    import_netmail(): Safer string handline and a bit more/consistent log output around attached file handling (especially if mv() fails).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thu Sep 24 20:20:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/57afc83c4a58a1a7f6af05ee
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Signal the sub-board's configured semaphore file when importing echomail

    At the request of alterego (ALTERANT), if a sub-board has a "post semaphore" configured, signal (touch) it whenever a message is imported via SBBSecho into that sub-board.
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thu Sep 24 20:34:10 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ddba8d7cec9cd0367d7e0480
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix previous commit: we need to use mycmdstr(), not cmdstr().
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Fri Sep 25 17:57:04 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/da486a78c63293a86718c78d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't attempt to parse origin addr from origin lines in NetMail msgs

    Apparently, some versions or configurations of Mystic BBS will include an Origin Line in FTN NetMail messages. That would've been okay for SBBSecho, except these origin lines do not contain an FTN address (in parenthesis).

    So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don't attempt to parse any Origin Lines. Secondly, fix up the Origin Line parse
    code a bit better detect the case when no FTN address is actually present.
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Fri Nov 20 21:38:16 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6380257eb617c61048195583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support forwarding FTN netmail to user's forward-to netmail address

    There's no new opt-in option for this new feature - maybe there should be.
    For geneb.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Nov 21 12:18:30 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/796c3db7d2e5fdb81b1c4dff
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    A better check of a user's netmail-forwarding address.

    is_supported_netmail_addr() actually takes the system configuration and QWK routing table into account. No sense forwarding to a non-deliverable address.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Nov 21 12:59:53 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/efbb1b5d5577a05515f1f6e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Revert "A better check of a user's netmail-forwarding address."

    This reverts commit 796c3db7d2e5fdb81b1c4dff884e15d66718063c.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Nov 22 14:28:50 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbda86ec8738498c14ae87fb
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix netmail forwarding (new feature)

    The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.

    Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").

    For geneb.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Dec 9 22:29:28 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/a1e127841841087fb51e1c32
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't repeate mail "comment" headers in exported netmail msgs

    smb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.
    When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).

    Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Dec 24 16:28:13 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/c590c437c7dee6de8531217b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use QWKnet ID of originating system when imported via QWKnet

    Update to previous commit.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 14 17:17:59 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/53d3103177986398c19564a3
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When replying to PING netmails, use the destination addr as the origaddr

    As tested and reported in FIDONEWS by Michiel van der Vlist, 2:280/5555, SBBSecho would use the "best match" FidoNet AKA for the originating address when replying to PING netmail messages and not necessarily the original destination address of the ping request. For systems that have multiple addresses (AKAs) that could be considered appropriate originating addresses for the requesting node address (e.g. multiple addresses in the same zone or zone/net), this could cause a confusion for the PING requester.

    The create_netmail() function now accepts an optional source (orig) address parameter and the PING response logic passes the netmail's destination address for the reply message's originating (source) address.

    I noticed that AreaMgr responses also follow the same logic as PING responses (just use the best-fit AKA, not necessarily the same address as the original request's destination address) - but I did not choose to address that "issue" at this time.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 21 19:25:49 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a9967b46fc2be2e0d08efb49
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix memcmp() usage problem introduced in previous commit

    Caught by GCC.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 22 00:27:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a1bead7cc4e295514a5c1b18
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate a large pass-struct-by-value

    Caught by Coverity.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 22 14:44:06 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/160606e4ce35305a55819266
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Print error and return NULL from getfmsg() upon ftell error

    Caught by Coverity - ftell[o] can return negative.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f3e4a6e498c8c206e087da88
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use SAFECAT() instead of strcat() for more safety.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu May 20 02:48:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/1031d0f6e01686c5a8dda583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace tempnam() usage with the suggested mkstemp()

    Since we're cleaning up warnings... this will break the Windows build for now. ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 29 19:32:50 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/0f262d8ab2a6bd870adbb428
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-board

    It was recently pointed out to me that a downlink could link to the '*' echo via Area Manager (AreaFix) request. This was not intentional.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 29 20:12:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7f0390149d84d79a3b7bfb10
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Keep the same area file (areas.bbs) mode flags (permissions)

    When executing area manager requests that alter the area file, the temp area file created (with mkstemp) had mode 0600 (owner read/write only). The sysop very possibly had different permission flags they want to keep for their area file, so copy the mode flags from the original area file to the temp/new area file.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat May 29 20:16:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9a8c8e6d414c2bfe503aa841
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Microsoft doesn't have fchmod(), so use chmod() on the closed file
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Oct 6 18:38:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ccc0e4019838ce4021c16b0e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When packing netmail (stored messages), don't discard non-zero zones

    As reported by Ragnarok (DOCKSUD) via DOVE-Net, when packing (packetizing) netmail messages, the source and destination zones from the netmail header were discarded (since they are defined as "optional" in FTS-1) and the zone values were replaced with the system's primary/default zone number. If the netmail message included an INTL kludge, the source and destination zone values would be parsed from that kludge line and this issue would not be noticed.

    So the fix is: Only if the netmail message header contains a source or destination zone number of 0, replace that zone with the system's primary/default zone number. As before, the INTL kludge zone information can override the header fields.

    Also, there's no reason to force the point numbers from the header to zero, since if they were not valid (e.g. "fill" in the original FTS-1 specification), they would be already zero. So use the source and destination point numbers, as is, from the netmail header too (with the FMPT and TOPT kludge override support left in-tact).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Nov 11 18:43:46 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5012efb1eb3d2d20289a01c1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log an error and exit immediately when a local linked-node is configured

    When a linked-node (in echocfg->Linked Nodes) contains one of the local system's FTN addresses, display/log an error and exit immediately, e.g.:
    Configuration ERROR: Linked node #20 is your own address: 1:103/705

    I'd perform this check in EchoCfg, but:
    1. echocfg doesn't read the BBS's configuration files (where the local FTN addresses are configured), and
    2. some sysops just directly edit their sbbsecho.ini file
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 12 14:09:35 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e10b39d1aee183a16a3d9458
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Generate a MSGID kludge for netmail messages created by SBBSecho

    The "serialno" field is a bad/naive one (a time_t value), but this is really just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged receiving AreaFix responses/notices).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Nov 18 17:38:10 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/27dfa4f6b9ebc59e1c4f097e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve gcc warning

    warning: format ‘%lx’ expects argument of type ‘long unsigned int’
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Jan 13 17:04:35 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/55962a410034e3633fe3ff09
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Disable libarchive support for creating/appending bundles

    libarchive apparently cannot be used for in-place modification of (e.g. adding files to) existing archives, so if a bundle already exists, this code would over-write it with a new archive containing just the latest packet. Issue reported by acn (IMZADI) via DOVE-Net.

    I could and might create an update_archive() function which extracts and re-creates an archive with additional files, but since I don't have that yet, just disable this for now and always use an external archive utility to create or update bundles (so again, an "Archive" configuration is required in your sbbsecho.ini file, which you most likely already have).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4ec5647c783a5f5af9d68611
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve some Coverity-discovered issues

    with lseek() argument types, ftell() return type, etc.

    Likely none of these would be actual issues with files < 2GiB in size.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Mar 2 10:07:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f9a681ac286284fe57f7f5c2
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix possible negative offset to fseeko()

    CID 350353
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Mar 11 00:08:19 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c4b6a79d6f3a6b217cb87a1b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add subject.can (Subject filter file) support

    For Trikester (DOVEMOD/BSMNTQQ)
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 00:38:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e530a12cf6268ef9ab47f36c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix CID 174355: Big parameter passed by value
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 3 16:51:09 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/726223ee8d8a7dde927fc833
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    For sub-boards configured to export "ASCII Only", convert UTF-8 correctly

    This converts the body text as well as the to, from, and subject header
    fields (first to CP437, then to ASCII).

    This should address the issue raised in issue #386 with exporting UTF-8 sequences to some message networks.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Apr 4 05:36:28 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bf3da76e32fbc8cd7785fa1f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve GCC warnings

    Fixes isue #388 - no change in behavior
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Tracker1@VERT/TRN to Rob Swindell on Mon Apr 4 18:56:06 2022
    On 4/3/22 16:51, Rob Swindell wrote:
    https://gitlab.synchro.net/main/sbbs/-/commit/726223ee8d8a7dde927fc833 Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    For sub-boards configured to export "ASCII Only", convert UTF-8 correctly

    This converts the body text as well as the to, from, and subject header fields (first to CP437, then to ASCII).

    This should address the issue raised in issue #386 with exporting UTF-8 sequences to some message networks.

    Maybe adding a "CP437/DOS Only" option? Not sure what the underlying
    value is though.
    --
    Michael J. Ryan - tracker1@roughneckbbs.com
    ---
    ï¿­ Synchronet ï¿­ Roughneck BBS - roughneckbbs.com
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Apr 13 18:35:02 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/414d34ec8bc2c13601ce476a
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix packet filename in "Gruned message" log entry on Win32

    e.g. "Grunged message (type 2) from 4:80/1 at offset 58 in packet: (null)"

    off_t is 64-bit, but long in 32-bit (on Win32), so needs a typecast here in lprintf() call (otherwise, the upper 4 bytes of the offset are interpreted
    as the string address for the corresponding '%s' argument, the filename).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Apr 21 22:09:52 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/2962e4a5bf733e4b0c3869c4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix segfault when printing Bad-echo name after failing to load cfg

    This is a weird one: sbbsecho ran right as I was saving msgs.cnf via
    SCFG and it seems like it loaded 0-byte msgs.cnf into memory and this
    segfault was a result of trying to print sub[INVALID_SUB]->code.

    The use of [f]nopen() with proper share perms should have prevented this (truncated msgs.cnf read) from happening, so there's something else afoot here. ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Thu Feb 16 00:01:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6fb20b919003c805a40c207c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve signed/unsigned compare warning with MSVC
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/ccfad124e104b09bf825392e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    More consistent 'exact' parameter values to findnodecfg() - e.g. false, not 0

    No functional change.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/15b230af547ff5932c6073e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Rework NetMail routing logic to handle point destinations better

    With this commmit, the logic is now:

    If the NetMail destination is a point and there's no linked-node for it
    and the boss node for this point is not one of our AKAs
    then route to the boss node (no linked-node match needed)
    if the boss node matches a linked-node with a route configuration
    then route to that configured route destination (2-levels of routing
    and thus 2 "Routing NetMail" msgs will be logged in this scenario)

    If the NetMail destination is a point and there is a linked-node for it
    then the netmail will not be routed
    unless that linked node has a route configuration

    NetMail destined for non-points are treated the same as before this
    commit.

    No change in the routing of echomail for points.

    I think this change fixes issue #520 which can be traced back to commit 45ced2a3b for poindexter FORTRAN (REALITY), 2 years ago almost to the
    day, where that change added point->boss routing, but only if the boss
    had a matching linked-node configuration (for both echomail and
    netmail).

    This commit also re-thinks commit ffe69b43623d (for Alterego) which
    would not route a point netmail if any our local AKAs matched the
    destination address, igorining the point value. I think what was
    intended here (I coudln't locate the original enhancmenet request or
    issue), was to not route if a local AKA was the *boss* of the point.
    And with this commit, that's now how it now works.

    As before, "test results appreciated".
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From poindexter FORTRAN@VERT/REALITY to Rob Swindell (on ChromeOS) on Sat Feb 18 18:45:27 2023
    Re: src/sbbs3/sbbsecho.c
    By: Rob Swindell (on ChromeOS) to Git commit to main/sbbs/master on Sat Feb 18 2023 12:59 pm

    As before, "test results appreciated".

    Thanks for doing this. I'm relying on the nightlies, so I'll download them tomorrow and test.
    ---
    þ Synchronet þ .: realitycheckbbs.org :: scientia potentia est :.
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Apr 15 19:45:46 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/227e2f4986eb0b04c05cc6ea
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Stop classifying msgs for unknown areas as security violations

    When Secure EchoMail is enabled and a Bad Echo Area (*) is defined in the
    area file (areas.bbs), but the packet source address is *not* listed as a
    link to the Bad Echo Area (tag: *) in areas.bbs, any messages for unknown
    areas in such a packet would cause the pkt to be considered a bad packet
    with a security violation. Instead, the message should just be skipped.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b185201161cd35dea8273d84
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Strip the "in-transit" attribute flag from imported packed-messages

    Log a warning message when either the "local" or "in-transit" flag has been stripped from ("Sanitized") imported packed-messages.

    Keyop reported a chksmb warning on a FidoNet message that contained the 'in-transit' attribute:
    <Keyop> Message flagged as 'In Transit' (?): 1
    <Keyop> fidonet_fidosoft Message Base has Errors!

    The message in question appears just to be a corrupted echomail msg coming
    from HPT:
    Sender '56:43 '
    To Tommi Koivula
    Subject test
    X-FTN-AREA FIDOSOFT.HUSKY
    X-FTN-TID hpt/os2-wc 1.9.0-cur 2021-03-14

    SBBSecho didn't use to convert/import the "in-transit" flag on imported
    netmail or echomail messages, ... until commit 446ab0ef7e09e5c61cf, which
    was needed to support the TickFix robot. So now, let's just sanitize the packed-message attributes a little sooner in the import process and log a warning when such sanitization has taken place.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d6eadf369e7ed75248b1819c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Truncate trailing whitespace from FidoNet message header fields

    It's unclear whether trailing whitespace is supposed to be significant or not (FidoNet specs don't say), but I don't see any reason why "John Doe" and
    "John Doe " should be considered unique senders or recipients. Remove any trailing whitespace from message subjects too.

    This change makes the trailing whitespace truncation in SMB hash functions unnecessary (at least for SBBSecho-imported messages), but most (all?) other message transports don't allow for this nonsense in the first place.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Jun 26 11:03:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e76fafaae4580941b343253b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix type 2.2 packet header generation

    As reported by Deon on DOVE-Net: type 2.2 packet generation was not (since SBBSecho v3.0) setting the origin and destination point values correctly:
    was leaving the packet type 2.0 date values in these fields.

    Also, zero-out the reserved bytes in the type 2.2 packet header (don't leave the type 2.0 date values in there).

    Thanks for the report Deon!
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Jul 20 11:53:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/68df9812f31add3f94430d77
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Always delete the AREASxxxxxx temp file

    When there are no changes (areas added or removed) via an areafix message, the data/AREASxxxxxx temp file would be left behind. The file was only removed if areas were added or removed from the area file via areafix message.

    The orphaned data/AREASxxxxxxx files were reported via DOVE-Net by Gamgee (PALANTIR)
    If you have these stale files, you can safely delete them.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Sep 17 23:27:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f9b0dda5a1cac371a50f9f3f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add more detail (e.g. line number) to various "error opening" log msgs

    Some of the errors could be pretty vague since they looked the same and
    we were depending on the path/file attempted to be opened in the log msg
    to clue us into what exactly was being attempted. But some of these file
    paths are sysop-configurable, and they can put unexpected things in there
    that make it difficult to determine exactly what file was trying to be
    opened and for what purpose. This should help a little bit.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 4 21:14:35 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 4 22:57:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Dec 15 17:25:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6e1118af6abf0c55ca608a29
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't use wildcard node packet password (if one exists)

    This also addresses the addresses with 65535 in them in the new debug-level
    log messages "New packet (type x) created for linked-node" .
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c2f663c30ab71c7493babab4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log message attributes in human-readable form (not just hexadecimal)
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Jan 7 20:47:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/623613492036f9806c225436
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Expand sole-LFs in message text (shouldn't normally be there)

    Expanded to CRLF or just CR (if strip LFs is enabled).

    It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Feb 7 10:47:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 16 20:11:36 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9b28769f4b669763409f0435
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag

    ... when exporting from SMB to .msg ("stored message") file
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 16:12:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4c7a908f8ee55161faf3be71
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Insure buf is null-terminated in getzpt(), resoving CID 488308
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 17:13:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5a2a73ae1b20ddf3563c23fe
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit to this file
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Sep 9 18:29:23 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0f0a8a1ae72c424509eaa72d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Refactor the function: unpack_bundle()

    1. When a 0-length bundle file was encountered or an unpacking error occurred,
    any remaining bundles for the current search day-of-week (e.g. *.SU*) would
    be skipped/ignored. This bug (issue #764, regarding the 0-length file part),
    is fixed by not incrementing the day-of-week index in the main loop, but
    rather only incremeting the index when all bundles for the current
    day-of-week have been processed.
    2. The age calculation for 0-byte/length bundle files was incorrect, so all
    0-length bundle files would always be considered "less than 24-hours old"
    (and thus, never auto-deleted).
    This exacerbated the problem of issue #764 since it would persist until the
    0-length files were manually deleted. Fixed the file age calculation and
    now logging the date/timestamp of the 0-length file as well.
    3. Don't do the switch/case/sprintf dance when we're not re-running a glob()
    search.
    4. Replace the switch/case statement with an array of week day names/patterns. 5. Ignore (with a warning log message) any sub-directories of the inbound
    directory that happen to match the bundle file search pattern.
    6. Use better variable naming.
    7. Refer to files with a length of 0 as "0-length" instead of "0-byte" in log
    messages.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Sep 22 16:57:13 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6177a1c02241acc45a1b0858
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix potential null pointer dereference

    strListReadFile() can return NULL upon error
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Nov 10 17:15:21 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3c0a335de3ba7d0008134bd1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log a notice-level message when renaming a bad bundle file to *.?_? or *.?-? ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Nov 12 20:08:03 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/fb138db6799daa4722bc8689
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support multiple filenames in subjects of file-attach netmails being packed

    When writing the attached file path/names to the FLO file, parse each
    filename out of the subject, accordingly. This should fix issue #824.

    There's an inconsistent support in SBBSecho for FileLists in the subjects of netmail messages. In a couple of places, single-space-separated filelists are fine (but not commas or multiple space, even though they are allowed per FTS-1).

    This particular fix is just for the packing of netmail messages and the appending the attached file(s) to the FLO file. Those other places (e.g.
    .REQ file creation) will need their own fixes for proper filelist support.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Nov 12 21:11:32 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/25ed5ec70838f530e7fc04ba
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support multiple files ("FileList" per FTS-1) in subj when creating .REQ files

    Previously, this feature assumed just one request per FREQ message, however FTS-1 make this clear:

    If one or more of FileAttached, FileRequest, or FileUpdateReq are
    asserted in an AttributeWord, the subject{72} field is interpreted as
    a list of file specifications which may include wildcards and other
    system-dependent data. This list is of the form

    FileList = [ FileSpec { Sep FileSpec } ] Null

    FileSpec = (* implementation dependent file specification. may
    not contain Null or any of the characters in Sep. *)

    Sep = ( " " | "," ) { " " }
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Nov 16 14:05:33 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e55183c0953d0b033d9f1179
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use fmutex_open for 100% locking and auto-removal upon close/termination
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Nov 17 16:40:39 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/dbf5e7758f297321c0b5260d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Revert "Use fmutex_open for 100% locking and auto-removal upon close/termination"

    This reverts commit e55183c0953d0b033d9f11796f4290e488596e92.

    fmutex_open()'s auto-remove feature doesn't work on normal/local Linux file systems: unlink() of a file immediately removes its directory entry allowing subsequent opens of the same file name, defeating the lock.

    I had tested fmutex_open() on a Samba mount (from Linux) and it worked as I wanted (like the Windows version does). Still searching for a good solution:
    if a process terminates, gracefully or not, I'd like the file to be removed
    at that time and until then, other processes or threads can't create or open the same lock file (using O_EXCL and file locking to insure this).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Nov 20 14:45:07 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3f24e009942a2d66c1870f34
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix new potential NULL derefs (the add/del_area args can be NULL)

    ... in area manager code modified in previous commit.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Nov 20 14:45:07 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a8cf36696b038fc4815f1264
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix unsigned compare against >= 0 and nomatch misplacement

    I'm not clear if/why these would cause the issue reporetd by
    Fernando but they're definitely bugs in the areas.ini areafix
    code. No impact to the areas.bbs areafix handling.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Nov 20 20:50:41 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a225fd20b4236ff5f8f56cc5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Detect and log warnings about duplicate area sections in areas.ini

    ... like how we do for areas.bbs files.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Nov 20 20:50:41 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6c85be290b34f6379cf56fe1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support AreaMgr request messages with -L (list) or -Q (query) but no body

    I noticed through code review that these kinds of messages would be rejected
    as "No commands to process.". We just needed to increment the 'cmd' counter when parsing these options to be sure we don't think that no commands were
    in fact request. -R (rescan) is not by itself a command since it requires listed area-tags to have any effect.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Nov 20 20:50:41 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f37c0346b645496e4e591d10
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix stupid inverted logic bug: treating areas.ini as areas.bbs for AreaFix

    and vice versa - so area manager requests were broken since I introduced the areas.ini support. Oops.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Nov 22 17:50:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2382d2987953d948a56b7612
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Clean up area management code

    I dislike this particular code a little less now:
    - no more redundant string compares
    - less deeply nested if() and for() blocks
    - remove added areas from the add list, rather than zeroing out the tag
    - a little more common code between areas.bbs and areas.ini handling

    No functional change (I hope).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Nov 30 21:02:49 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/cee11a4e100dba897abc250c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate some harmless gcc warning about using uninitialized vars
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Dec 5 21:40:24 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1520bba8c23f3e6b5d80de7f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Truncate the GIT date (remove time) in Program ID.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e2476ebbaa0a7d05e72bce2d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix insufficient allocation bug in link_area() introduced in commit 813072cd4

    This is likely the cause of the areamgr issue that resulted in weird/invalid node address being added to the area file, reported by Tom Moore (1:135/205). ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Dec 7 14:08:12 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c14cea13c153d2e18455823f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    A differnt 'fix' to link_area()

    So, (sizeof *addr) now looks right got me (this should've been the same as sizeof(fidoaddr_t)), so the change in commit e2476ebbaa doesn't actually look like a fix, but maybee a regression.

    I need to test some area manager link additions and get to the bottom of this, but this particular change was not a fix (and caught/reported by Coverity -
    CID 515673).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Dec 7 16:39:06 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/68e76982e0054dffec75b75c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix the areas.bbs AreaMgr addition bug created in commit 813072cd450c2

    The newly created/used link_aera() function was copying the address of the passed fidoaddr_t pointer rather than the value (fidoaddr) pointed to.
    This is the actual fix for the problem reported by Tom Moore (1:135/205)
    - tested and validated. It only immediately impacted areas.bbs use
    (not areas.ini), since we wrote a stringified address directly to the
    areas.ini file "links" key. This was not an allocation issue but a memcpy() issue.

    Other unrelated changes:
    - Log a debug-level message when ignoring a "NO-ECHO" message (subject "NE:*") - Log a notice-level message when ignoring a message due to GATEWAY VIOLATION
    (gating a message between net-types when not explicitly configured to do so) ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Jan 19 02:56:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/c0305b87e10ec27852fe13f1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log messages when (attempting) to notify mail recipients (via short messages)

    ERROR-level messages with error number, upon failure and debug-level message upon success.

    To hopefully help Deon get to the bottom of his SBBSecho echomail notification issue.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deon@VERT/ALTERANT to Digital Man on Sun Jan 19 23:35:56 2025
    Re: src/sbbs3/sbbsecho.c
    By: Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Sun Jan 19 2025 02:56 am

    Howdy,

    Log messages when (attempting) to notify mail recipients (via short messages)

    To hopefully help Deon get to the bottom of his SBBSecho echomail notification issue.

    Thanks, I've kicked of a build and will try this tomorrow. Thanks :)


    ...ëîåï

    ---
    þ Synchronet þ AnsiTEX bringing back videotex but with ANSI
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Jan 19 22:59:10 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/4bad3a54de5334550d9f5466
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    More log messages around notifying users of imported echomail, for Deon

    Log levels ERROR, NOTICE, and DEBUG
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 3 18:56:14 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ff1ebae7920c50df2855051c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add debug-level log messages when import_netmail() returns a non-zero value

    To help debug any situations where import_netmail() might silently fail
    (though I don't anticipate there are any, Accession suggested there was).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From k9zw@VERT to Rob Swindell (on Windows 11) on Tue Feb 4 06:54:08 2025
    Why are these being posted? Curious

    --- Steve K9ZW via SPOT BBS

    --- Mystic BBS v1.12 A49 2024/05/29 (Raspberry Pi/32)
    * Origin: SPOT BBS / k9zw (1:154/154)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to k9zw on Tue Feb 4 11:26:44 2025
    Re: Re: src/sbbs3/sbbsecho.c
    By: k9zw to Rob Swindell (on Windows 11) on Tue Feb 04 2025 06:54 am

    Why are these being posted? Curious

    This is the "Synchronet Programming (C/C++ and Git)" Conference, so the source code repository activity (changes to the Synchronet source, primarily) get posted here, so sysop can see what's changing (fixes, new features, etc.).
    --
    digital man (rob)

    This Is Spinal Tap quote #5:
    Nigel Tufnel: Authorities said... best leave it... unsolved.
    Norco, CA WX: 55.6øF, 78.0% humidity, 0 mph ENE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From k9zw@VERT to Digital Man on Tue Feb 4 17:48:19 2025
    On 04 Feb 2025, Digital Man said the following...

    Re: Re: src/sbbs3/sbbsecho.c
    By: k9zw to Rob Swindell (on Windows 11) on Tue Feb 04 2025 06:54 am

    Why are these being posted? Curious

    This is the "Synchronet Programming (C/C++ and Git)" Conference, so the source code repository activity (changes to the Synchronet source,

    Alas my system merged this in another echo... puzzling how at the moment...

    appreciate the reply!

    --- Steve K9ZW via SPOT BBS

    --- Mystic BBS v1.12 A49 2024/05/29 (Raspberry Pi/32)
    * Origin: SPOT BBS / k9zw (1:154/154)
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From MRO@VERT/BBSESINF to k9zw on Tue Feb 4 18:04:14 2025
    Re: Re: src/sbbs3/sbbsecho.c
    By: k9zw to Digital Man on Tue Feb 04 2025 05:48 pm

    source code repository activity (changes to the Synchronet source,

    Alas my system merged this in another echo... puzzling how at the moment...

    appreciate the reply!

    put your data files in their own sub directory for each msg network you have. ---
    þ Synchronet þ ::: BBSES.info - free BBS services :::
  • From Gamgee@VERT/PALANTIR to MRO on Tue Feb 4 18:41:06 2025
    MRO wrote to k9zw <=-

    source code repository activity (changes to the Synchronet source,

    Alas my system merged this in another echo... puzzling how at the moment... appreciate the reply!

    put your data files in their own sub directory for each msg network you have.

    That isn't necessary and certainly is not the default way.



    ... He does the work of 3 Men...Moe, Larry & Curly
    --- MultiMail/Linux v0.52
    þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL
  • From Nightfox@VERT/DIGDIST to MRO on Tue Feb 4 17:28:55 2025
    Re: Re: src/sbbs3/sbbsecho.c
    By: MRO to k9zw on Tue Feb 04 2025 06:04 pm

    Alas my system merged this in another echo... puzzling how at the moment...

    appreciate the reply!

    put your data files in their own sub directory for each msg network you have.

    I think it may be the internal sub-board code that matters, not really where the files are stored. The internal sub-board codes need to be unique. If 2 sub-boards share the same internal code, then I'm sure that would cause messages to get duplicated in both sub-boards. But it also doesn't hurt to have the files in separate directories.

    Nightfox

    ---
    þ Synchronet þ Digital Distortion: digitaldistortionbbs.com
  • From Digital Man@VERT to Nightfox on Tue Feb 4 20:00:53 2025
    Re: Re: src/sbbs3/sbbsecho.c
    By: Nightfox to MRO on Tue Feb 04 2025 05:28 pm

    Re: Re: src/sbbs3/sbbsecho.c
    By: MRO to k9zw on Tue Feb 04 2025 06:04 pm

    Alas my system merged this in another echo... puzzling how at the moment...

    appreciate the reply!

    put your data files in their own sub directory for each msg network you have.

    I think it may be the internal sub-board code that matters, not really where the files are stored. The internal sub-board codes need to be unique. If 2 sub-boards share the same internal code, then I'm sure that would cause messages to get duplicated in both sub-boards. But it also doesn't hurt to have the files in separate directories.

    In this case, the system with the issue is not a Synchronet system, so I don't know if "internal codes" apply. :-)
    --
    digital man (rob)

    Steven Wright quote #7:
    A clear conscience is usually the sign of a bad memory.
    Norco, CA WX: 54.0øF, 78.0% humidity, 3 mph WNW wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to Digital Man on Wed Feb 5 10:54:16 2025
    Re: Re: src/sbbs3/sbbsecho.c
    By: Digital Man to Nightfox on Tue Feb 04 2025 08:00 pm

    In this case, the system with the issue is not a Synchronet system, so I don't know if "internal codes" apply. :-)

    Ah, I didn't see (or notice) it's not a Synchronet system. :)

    Nightfox

    ---
    þ Synchronet þ Digital Distortion: digitaldistortionbbs.com
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 23 16:25:08 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/3ff043da84462d6cf5db9a64
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log warning-level message when we can't auto-add a sub

    ... because there's no linked-node configured as the uplink for the parent message group.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 23 20:32:38 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/d652854faa37cb4cdf507938
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Address some MSVC static analysis warnings
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 24 23:43:51 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/fabef9ea90ed2758081eec2a
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Only log one warning per invocation about inability to auto-add sub

    Just the first sub that couldn't be auto-added.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Mar 14 21:19:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8010070c0bc86aaf8104a144
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Take the configured origin line chars into account when determining charset

    and if the message is UTF-8, encode the origin line as UTF-8 too.
    If the message is straight ASCII (e.g. the sub-board is configured as ASCII only), convert the configured origin line to ASCII, before appending.

    At this time, only ASCII and CP437 encodings of originlines are supported
    in Synchronet (imported and exported origin lines can contain UTF-8).

    This should address the issue raise by Sergey Dorofeev (2:5020/12000) in the FidoNet UTF-8 echo whereby messages exported from Synchronet systems (presumably using SBBSecho) could contain a mixture of CP437 and UTF-8 encodings (!) when the sysop had CP437 chars in their configured origin line. ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Mar 14 21:19:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ca0d64e4e73f352dbfcd4f1b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate some unnecessary typecasts and parens
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Mar 14 21:21:49 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f78d5395969b6a38a4db8adc
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add typecast to elminate GCC warning
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Jul 15 22:40:09 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/6d037195018beb8a946bdebb
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When netmail is forwarded to an external (netmai/email) address, notify user

    Include the appropriate text.dat string (like the mail server does) in
    short message sent to user.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net