src/conio cterm.c 1.143 1.144
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5114

Modified Files:
cterm.c
Log Message:
Fix height calculation for scrolling.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://

src/conio cterm.c 1.144 1.145
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5132

Modified Files:
cterm.c
Log Message:
Typo fixins.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/conio cterm.c 1.145 1.146
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5028

Modified Files:
cterm.c
Log Message:
Fix scrolling region parsing when there are no arguments specified.



---
þ Synchronet þ Vertrauen þ

src/conio cterm.c 1.150 1.151
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv12694

Modified Files:
cterm.c
Log Message:
Fix Coverity detected memory leak when a corrupt font size is used (unlikely)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/conio cterm.c 1.151 1.152
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv29786

Modified Files:
cterm.c
Log Message:
More alloca() replacements.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/conio cterm.c 1.153 1.154
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2025

Modified Files:
cterm.c
Log Message:
Fix bug introduced Jan, 2014 parsing CSI x f or CSI x H with a single digit single argument. Imapged Global War continent maps at least.

Thanks for the bug report Digital Man!



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/conio cterm.c 1.153 1.154
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2025

Modified Files:
cterm.c
Log Message:
Fix bug introduced Jan, 2014 parsing CSI x f or CSI x H with a single digit single argument. Imapged Global War continent maps at least.

Thanks for the bug report Digital Man!

Also fixed displaying quite a bit of stuff in a random game I installed a couple of months back, Ghost Town III (v.3.13).

Good stuff!

~KenDB3

---
þ Synchronet þ KD3net-Rhode Island's only BBS about nothing. http://bbs.kd3.us

Re: Re: src/conio/cterm.c
By: KenDB3 to deuce on Tue Mar 10 2015 10:59 am

Also fixed displaying quite a bit of stuff in a random game I installed a couple of months back, Ghost Town III (v.3.13).

You gotta tell me about this stuff!

Best way to report a bug like this is a "raw" capture from SyncTERM, a screenshot of SyncTERM getting it wrong, and a screenshot of something else getting it right.

I can usually figure it out without the screenshots, but that capture is invaluable.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

You gotta tell me about this stuff!

Best way to report a bug like this is a "raw" capture from SyncTERM, a screenshot of SyncTERM getting it wrong, and a screenshot of something else getting it right.

I can usually figure it out without the screenshots, but that capture is invaluable.

Duly noted! I honestly thought I was the one doing something wrong at first, or that the game was "a bit funky". But now I'll know what to do for you next time.

~KenDB3

---
þ Synchronet þ KD3net-Rhode Island's only BBS about nothing. http://bbs.kd3.us

Re: Re: src/conio/cterm.c
By: KenDB3 to Deuce on Wed Mar 11 2015 07:15 am

You gotta tell me about this stuff!

Best way to report a bug like this is a "raw" capture from SyncTERM, a screenshot of SyncTERM getting it wrong, and a screenshot of something else getting it right.

I can usually figure it out without the screenshots, but that capture is invaluable.

Duly noted! I honestly thought I was the one doing something wrong at first, or that the game was "a bit funky". But now I'll know what to do for you next time.

Especially now, as Deuce is preparing for a (very soon now) SyncTERM 1.00 release. Timely bug reports are critical right now. :-)

(Did I let the cat out of the bag? If so, sorry.)

digital man

Synchronet "Real Fact" #35:
Synchronet's Windows DLLs are built with Microsoft Visual Studio/C++.
Norco, CA WX: 67.4øF, 39.0% humidity, 0 mph NW wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello Digital,

On 11 Mar 15 10:10, Digital Man wrote to KenDB3:

Especially now, as Deuce is preparing for a (very soon now) SyncTERM
1.00 release. Timely bug reports are critical right now. :-)

(Did I let the cat out of the bag? If so, sorry.)

Maybe only to people not watching whatever programming echo displays all your CVS commits. Both of you have been plugging away at it for a bit now. :)

I suppose I could ask Deuce about SSH not working in Syncterm/Windows 8.1, but I think he already knows about it.. something to do with cryptlib being a newer
version or something?

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: src/conio/cterm.c
By: Digital Man to KenDB3 on Wed Mar 11 2015 10:10 am

Especially now, as Deuce is preparing for a (very soon now) SyncTERM 1.00 release. Timely bug reports are critical right now. :-)

(Did I let the cat out of the bag? If so, sorry.)

Nay, I posted in General about it weeks ago.


---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Accession to Digital Man on Wed Mar 11 2015 05:15 pm

I suppose I could ask Deuce about SSH not working in Syncterm/Windows 8.1, but I think he already knows about it.. something to do with cryptlib being a newer version or something?

Have you tried one of the new nightlys from http://syncterm.bbsdev.net/

It works for me on 8.1.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

--- DIGITAL MAN wrote --

Especially now, as Deuce is preparing for a (very soon now) SyncTERM 1.00 release. Timely bug reports are critical right now. :-

(Did I let the cat out of the bag? If so, sorry.

The last time I tried it, Syncterm didn't render the ansi screen savers on my BBS correctly... I'll give it another go. I reported it at the time...



---
* TARDIS BBS - Home of QUARKware * telnet bbs.cortex-media.info 4223

Re: Re: src/conio/cterm.c
By: mark firestone to DIGITAL MAN on Thu Mar 12 2015 09:48:00

The last time I tried it, Syncterm didn't render the ansi screen savers on my BBS correctly... I'll give it another go. I reported it at the time...

What is an ANSI screen saver? Or rather, what is a screen saver in a BBS context? Is your BBS set up to display an ANSI after the user is inactive for some amount of time?

Nightfox

---
þ Synchronet þ Digital Distortion BBS - digitaldistortionbbs.com

--- NIGHTFOX wrote --

What is an ANSI screen saver? Or rather, what is a screen saver in a BB context? Is your BBS set up to display an ANSI after the user is inactive some amount of time

Sorry, I meant ASCII screen saver, and yes that is exactly what it does.



---
* TARDIS BBS - Home of QUARKware * telnet bbs.cortex-media.info 4223

Re: Re: src/conio/cterm.c
By: KenDB3 to Deuce on Wed Mar 11 2015 07:15 am

You gotta tell me about this stuff!

Best way to report a bug like this is a "raw" capture from SyncTERM, a screenshot of SyncTERM getting it wrong, and a screenshot of something else getting it right.

I can usually figure it out without the screenshots, but that capture is invaluable.

Duly noted! I honestly thought I was the one doing something wrong at first, or that the game was "a bit funky". But now I'll know what to do for you next time.

Especially now, as Deuce is preparing for a (very soon now) SyncTERM 1.00 release. Timely bug reports are critical right now. :-)

Actually, just while reading this I was trying to log in while at work, and RLogin port is blocked, so I use Alt-L to pass my credentials. However, suddenly I find that none of the Alt key combinations are working for me.

Whenever I test something on a work PC I always feel the need to double check from my home PC, *so it might just be me*. Looks like the build I am using here at work is from 3/10.

Anyone else notice this problem?

~KenDB3

---
þ Synchronet þ KD3net-Rhode Island's only BBS about nothing. http://bbs.kd3.us

Re: Re: src/conio/cterm.c
By: KenDB3 to Digital Man on Thu Mar 12 2015 12:05 pm

Actually, just while reading this I was trying to log in while at work, and RLogin port is blocked, so I use Alt-L to pass my credentials. However, suddenly I find that none of the Alt key combinations are working for me.

Whenever I test something on a work PC I always feel the need to double check from my home PC, *so it might just be me*. Looks like the build I am using here at work is from 3/10.

I've had a similar report from another source. I have not yet been able to reproduce it though.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Hello Deuce,

On 12 Mar 15 01:00, Deuce wrote to Accession:

Have you tried one of the new nightlys from
http://syncterm.bbsdev.net/

It works for me on 8.1.

Very possible I have not. I'll give it a try and report back. Thanks!

*EDIT*

Syncterm gives "Error activating session", and Synchronet's logs say "Handshake
failed [preauth]" even though I tried multiple times and I know my login/password for ssh and logging in in general. I do the exact same thing with putty and it works. :)

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Actually, just while reading this I was trying to log in while at work, and RLogin port is blocked, so I use Alt-L to pass my credentials. However, suddenly I find that none of the Alt key combinations are working for me.

Whenever I test something on a work PC I always feel the need to double check from my home PC, *so it might just be me*. Looks like the build I am using here at work is from 3/10.

I've had a similar report from another source. I have not yet been able to reproduce it though.

And strangely enough, the home computer acted differently. The file at home shows the same date 3/10. I'm pretty sure I updated them both on the same day. Work PC: Win 7 64-bit. Home PC: Win 8.1 64-bit. I can't think of much else that would be a major difference though.

~KenDB3

---
þ Synchronet þ KD3net-Rhode Island's only BBS about nothing. http://bbs.kd3.us

Actually, just while reading this I was trying to log in while at work, and RLogin port is blocked, so I use Alt-L to pass my credentials. However, suddenly I find that none of the Alt key combinations are working for me.

Whenever I test something on a work PC I always feel the need to double check from my home PC, *so it might just be me*. Looks like the build I am using here at work is from 3/10.

I've had a similar report from another source. I have not yet been able to reproduce it though.

And strangely enough, the home computer acted differently. The file at home shows the same date 3/10. I'm pretty sure I updated them both on the same day. Work PC: Win 7 64-bit. Home PC: Win 8.1 64-bit. I can't think of much else that would be a major difference though.

Even more odd, at work today it all works fine... no changes to anything at all. I got nothin' for ya. Ghost in the shell, man.

~KenDB3

---
þ Synchronet þ KD3net-Rhode Island's only BBS about nothing. http://bbs.kd3.us

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Thu Mar 12 2015 05:59 pm

Syncterm gives "Error activating session", and Synchronet's logs say "Handshake failed [preauth]" even though I tried multiple times and I know my login/password for ssh and logging in in general. I do the exact same thing with putty and it works. :)

What were you connecting to?

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Hello Deuce,

On 12 Mar 15 01:00, Deuce wrote to Accession:

Have you tried one of the new nightlys from
http://syncterm.bbsdev.net/

It works for me on 8.1.

Since I just noticed another thing you may want to take a look at, figured I'd post it before I forget to.

No matter what I try, Syncterm seems to create a c:\Users\<name>\Downloads\SyncTERM directory every time I open the program. I have my downloads and uploads directory set to c:\Users\<name>\Downloads and that is it. I've also changed the location of the syncterm.lst and configuration settings to the same directory Syncterm resides, which is E:\Program Files (x86)\Syncterm.

In other words, I've gone through the config multiple times now, and nowhere is
\SyncTERM specified. Does it automatically append it to your upload/download directory or something?

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Fri Mar 13 2015 05:19 pm

Hello Deuce,

On 12 Mar 15 01:00, Deuce wrote to Accession:

Have you tried one of the new nightlys from
http://syncterm.bbsdev.net/

It works for me on 8.1.

Since I just noticed another thing you may want to take a look at, figured I'd post it before I forget to.

No matter what I try, Syncterm seems to create a c:\Users\<name>\Downloads\SyncTERM directory every time I open the program. I have my downloads and uploads directory set to c:\Users\<name>\Downloads and that is it. I've also changed the location of the syncterm.lst and configuration settings to the same directory Syncterm resides, which is E:\Program Files (x86)\Syncterm.

In other words, I've gone through the config multiple times now, and
nowhere is \SyncTERM specified. Does it automatically append it to your upload/download directory or something?

Yes, he has hard-coded "SyncTERM" appended to the directories. I'm not a fan of
this either (e.g. I'd like my downloads to go into %USERPROFILE%\Downloads (on Windows) and not Downloads\SyncTERM.

digital man

Synchronet "Real Fact" #58:
Synchronet apparel and merchandise can be purchased at cafepress.com/synchronet Norco, CA WX: 80.1øF, 17.0% humidity, 10 mph SSW wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello Deuce,

On 13 Mar 15 15:25, Deuce wrote to Accession:

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Thu Mar 12 2015 05:59 pm

Syncterm gives "Error activating session", and Synchronet's logs
say "Handshake failed [preauth]" even though I tried multiple times
and I know my login/password for ssh and logging in in general. I
do the exact same thing with putty and it works. :)

What were you connecting to?

Oh sorry, it wasn't Synchronet's logs, it was /var/log/messages which is intermixed with Synchronet's logs. It's my sshd server using openssh.

SSH: Server;LType: Throughput;Remote: 192.168.1.101-54946;IN: 9840;OUT: 558112;Duration: 4024.5;tPut_in: 2.4;tPut_out: 138.7
pam_unix:(sshd:session): session closed for user axisd

..and another try gives:

error: Received disconnect from 192.168.1.101: 2: Handshake failed [preauth]

192.168.1.101 is the machine I'm using Syncterm on, while trying to connect to a local hostname/address (flakjacket.pharcyde.org) which works fine in putty, or from any Linux terminal as-is. I've also tried the LAN IP address of that machine as well, and get the same results.

Syncterm just prompts me for userID and password, then says "Error activating session".

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Hello Digital,

On 13 Mar 15 19:46, Digital Man wrote to Accession:

In other words, I've gone through the config multiple times now,
and nowhere is \SyncTERM specified. Does it automatically append it
to your upload/download directory or something?

Yes, he has hard-coded "SyncTERM" appended to the directories. I'm not
a fan of this either (e.g. I'd like my downloads to go into %USERPROFILE%\Downloads (on Windows) and not Downloads\SyncTERM.

Thanks for the explanation! I was thinking I was going crazy as I tried to make
sure it was nowhere in my configuration. But every time I execute the program the damn directory reappears! :(

I agree I'd like everything to go in my Downloads folder on Windows as well. Since that's where every other program I run here seems to like to put things. :)

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Fri Mar 13 2015 05:19 pm

No matter what I try, Syncterm seems to create a c:\Users\<name>\Downloads\SyncTERM directory every time I open the program. I have my downloads and uploads directory set to c:\Users\<name>\Downloads and that is it. I've also changed the location of the syncterm.lst and configuration settings to the same directory Syncterm resides, which is E:\Program Files (x86)\Syncterm.

In other words, I've gone through the config multiple times now, and nowhere is \SyncTERM specified. Does it automatically append it to your upload/download directory or something?

I'll take a look. By default, SyncTERM asks the OS where it should store files. This may be an unexpected side-effect.

Thanks for the report!

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Digital Man to Accession on Fri Mar 13 2015 07:46 pm

Yes, he has hard-coded "SyncTERM" appended to the directories. I'm not a fan of this either (e.g. I'd like my downloads to go into %USERPROFILE%\Downloads (on Windows) and not Downloads\SyncTERM.

The *default* download dir has SyncTERM appended... as I recall, the source of this is some Microsoft document on the Right Way to store downloaded files. When a download directory is specified in an entry, or a default download path is specified and the entry doesn't have a path, it is not modified to have SyncTERM appended... ie: it's not hard-coded.

My reading of the bug report is that the default download directory is created regardless of it being used by anything. Possibly the directory is created as a side effect of getting the default transfer path before loading the list or something. I'll confirm and fix if this is true this weekend.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Sat Mar 14 2015 09:43 am

192.168.1.101 is the machine I'm using Syncterm on, while trying to connect to a local hostname/address (flakjacket.pharcyde.org) which works fine in putty, or from any Linux terminal as-is. I've also tried the LAN IP address of that machine as well, and get the same results.

What version of OpenSSH is running there? Sounds like a handshake difference between OpenSSH and Cryptlib.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Accession to Digital Man on Sat Mar 14 2015 09:54 am

I agree I'd like everything to go in my Downloads folder on Windows as well. Since that's where every other program I run here seems to like to put things. :)

After you change your configuration, the file is downloaded to the expected directory though right? That is to say, the useless directory is created and never used.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Deuce to Accession on Sat Mar 14 2015 01:10 pm

I'll take a look. By default, SyncTERM asks the OS where it should store files. This may be an unexpected side-effect.

Thanks for the report!

It appears that on Vista and higher, the Downloads directory is defined as the place to put all downloads. I've updated SyncTERM to use the "new" Downloads directory as-is. XP and older will still use the "Documents and Settings\SyncTERM" though, and will likely still create that folder if it doesn't exist.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Hello Deuce,

On 14 Mar 15 13:32, Deuce wrote to Accession:

192.168.1.101 is the machine I'm using Syncterm on, while trying to
connect to a local hostname/address (flakjacket.pharcyde.org) which
works fine in putty, or from any Linux terminal as-is. I've also
tried the LAN IP address of that machine as well, and get the same
results.

What version of OpenSSH is running there? Sounds like a handshake difference between OpenSSH and Cryptlib.

Gentoo stable, net-misc/openssh-6.7_p1.

I also tried to ssh to my other system, which runs Archlinux, and openssh 6.7 as well it seems. I tried both from a CTRL-D enter your address manually and adding an entry for it, and when it connected via CTRL-D it showed the OpenSSH header, I hit a key and it said "protocol mismatch."

Just trying to give you any information I have here.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Hello Deuce,

On 14 Mar 15 13:32, Deuce wrote to Accession:

After you change your configuration, the file is downloaded to the expected directory though right? That is to say, the useless
directory is created and never used.

After giving that a shot.. it seems to be confirmed. Downloads to the configured directory, and the SyncTERM directory is not used, yet autocreated every time the program is run.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Hello Deuce,

On 15 Mar 15 02:19, Deuce wrote to Accession:

Thanks for the report!

It appears that on Vista and higher, the Downloads directory is
defined as the place to put all downloads. I've updated SyncTERM to
use the "new" Downloads directory as-is. XP and older will still use
the "Documents and Settings\SyncTERM" though, and will likely still
create that folder if it doesn't exist.

I just snagged today's binary, compiled on "Sun Mar 15 10:01:29". Seems to be later than your posted message(s). Anyhow, C:\Users\<username>\Downloads\SyncTERM is still being autocreated each time Syncterm is ran.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Sun Mar 15 2015 10:07 am

Gentoo stable, net-misc/openssh-6.7_p1.

I also tried to ssh to my other system, which runs Archlinux, and openssh 6.7 as well it seems. I tried both from a CTRL-D enter your address manually and adding an entry for it, and when it connected via CTRL-D it showed the OpenSSH header, I hit a key and it said "protocol mismatch."

Just trying to give you any information I have here.

Yep, perfect, I can reproduce here, and it looks like OpenSSH has started sending a PAM auth request with no prompts. Looking into it... this will likely require anoter patch to Cryptlib to fix.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Sun Mar 15 2015 10:18 am

I just snagged today's binary, compiled on "Sun Mar 15 10:01:29". Seems to be later than your posted message(s). Anyhow, C:\Users\<username>\Downloads\SyncTERM is still being autocreated each time Syncterm is ran.

I've just updated the build, there was a compile error in last night's nightly that prevented the .exe from being updated. It should be good now.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

El 15/03/15 a las 17:52, Deuce escibió:

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Sun Mar 15 2015 10:07 am

Gentoo stable, net-misc/openssh-6.7_p1.

I also tried to ssh to my other system, which runs Archlinux, and openssh 6.7 as well it seems. I tried both from a CTRL-D enter your address manually
and adding an entry for it, and when it connected via CTRL-D it showed the OpenSSH header, I hit a key and it said "protocol mismatch."

Just trying to give you any information I have here.

Yep, perfect, I can reproduce here, and it looks like OpenSSH has started sending a PAM auth request with no prompts. Looking into it... this will likely require anoter patch to Cryptlib to fix.

Deuce, please consider kepping the WITHOUT_CRYPTLIB to permit build
without this library.

I had to make a patch because in some place do not handle it correctly:

https://github.com/ftoledo/pkg-syncterm/blob/master/debian/patches/disabled_cryptlib

Re: Re: src/conio/cterm.c
By: Ragnarok to Deuce on Sun Mar 15 2015 10:45 pm

Deuce, please consider kepping the WITHOUT_CRYPTLIB to permit build
without this library.

I had to make a patch because in some place do not handle it correctly:
https://github.com/ftoledo/pkg-syncterm/blob/master/debian/patches/disabled _cryptlib

What license problems are referred there? Cryptlib is distributed under the Sleepycat license which is GPL compatible. See here:

http://www.gnu.org/licenses/license-list.html#BerkeleyDB

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

El 16/03/15 a las 21:00, Deuce escibió:

Re: Re: src/conio/cterm.c
By: Ragnarok to Deuce on Sun Mar 15 2015 10:45 pm

Deuce, please consider kepping the WITHOUT_CRYPTLIB to permit build without this library.

I had to make a patch because in some place do not handle it correctly:
https://github.com/ftoledo/pkg-syncterm/blob/master/debian/patches/disabled
_cryptlib

What license problems are referred there? Cryptlib is distributed under the Sleepycat license which is GPL compatible. See here:

http://www.gnu.org/licenses/license-list.html#BerkeleyDB

The problem seems that cryptlib have code derivated from openssl and
this is not GPL-compatible:

https://www.debian-administration.org/users/dkg/weblog/74

http://comments.gmane.org/gmane.comp.encryption.cryptlib/2529

I'm not expert in this topic, maybe if you have contact with cryptlib
devel, they can help undertanding the issue.
For this reason i still building without cryptlib until this situation
is clarified for me.

Re: Re: src/conio/cterm.c
By: Ragnarok to Deuce on Tue Mar 17 2015 12:21 pm

The problem seems that cryptlib have code derivated from openssl and
this is not GPL-compatible:

https://www.debian-administration.org/users/dkg/weblog/74

http://comments.gmane.org/gmane.comp.encryption.cryptlib/2529

I'm not expert in this topic, maybe if you have contact with cryptlib
devel, they can help undertanding the issue.
For this reason i still building without cryptlib until this situation
is clarified for me.

I got my copy under the Sleepycat license and am redistributing it under the terms that were specified in it. I have no reason to believe that Dr. Gutmann is not acting in good faith. It seems that nobody has every actually asked him about this. Assuming someone is guilty without even a priliminary attempt at allowing them to defend themselves is pretty silly. Punishing downstream users by arbitrarily disabling features based on this assumption even more so.

I've posted the link to the mailing list, but do not plan on making it easier to remove features until/unless Dr. Gutmann responds confirming the fears of the person who originated that blog post.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Hello Deuce,

On 15 Mar 15 13:52, Deuce wrote to Accession:

Just trying to give you any information I have here.

Yep, perfect, I can reproduce here, and it looks like OpenSSH has
started sending a PAM auth request with no prompts. Looking into
it... this will likely require anoter patch to Cryptlib to fix.

I don't know if my other message made it to you or not, but after you did something to syncterm.c, I've downloaded multiple dailys now and up till today a Downloads\SyncTERM folder is still created.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: src/conio/cterm.c
By: Accession to Deuce on Fri Mar 20 2015 06:02 pm

Yep, perfect, I can reproduce here, and it looks like OpenSSH has started sending a PAM auth request with no prompts. Looking into
it... this will likely require anoter patch to Cryptlib to fix.

I don't know if my other message made it to you or not, but after you did something to syncterm.c, I've downloaded multiple dailys now and up till today a Downloads\SyncTERM folder is still created.

Not sure what you mean by "other message", but please reply on an appropriate thread. This is too confusing for my poor little brain.

What do you mean by "did something to syncterm.c"? Also, the default default download folder could be a factor. I dunno, 'cause this is three different bugs in the same message.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Hello Deuce,

On 21 Mar 15 04:14, Deuce wrote to Accession:

Not sure what you mean by "other message", but please reply on an appropriate thread. This is too confusing for my poor little brain.

I posted a message a week or so ago stating whatever "fix" you did in regards to the SyncTERM directory being auto-created did not work. This has been the same thread as far as I know. I brought up two bugs in the same thread, neither
of them are fixed yet.

What do you mean by "did something to syncterm.c"? Also, the default default download folder could be a factor. I dunno, 'cause this is
three different bugs in the same message.

One of your last commits was to syncterm.c to try to fix the Downloads\SyncTERM
directory being auto-created. I was simply letting you know it didn't change anything.

When I load up Syncterm, the directory is created, and after that I'll delete the SyncTERM directory, then any time I disconnect from a system and go back to
the "dialing directory" screen the directory is also auto-created. So it's not *only* when I open the program for the first time.

There were only two bugs I have been talking about recently. Where it turned into three bugs, I don't know. But I've been on the same thread the entire time. *shrug*

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20130910
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

src/conio cterm.c 1.154 1.155
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv28940

Modified Files:
cterm.c
Log Message:
Open logs in binary mode to work around Microsoft C library bug which mangles LFs on write.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/conio cterm.c 1.155 1.156
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv14176

Modified Files:
cterm.c
Log Message:
Added range checks when initializing textinfo.screenwidth and screeheight (don't wrap around if value is > 255) - presumably these textinfo struct members were left as unsigned chars (8-bits) to preserve compatiblity with legacy conio apps, but I'm not sure. Perhaps we could increase these to
at least 16-bit integers or bigger in the future, in which case these range checks would need to be removed or replaced.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.158 1.159
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv13109

Modified Files:
cterm.c
Log Message:
...and I put the first-available-font-slot in front of the version number. Fixed.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.164 1.165
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv9785

Modified Files:
cterm.c
Log Message:
Don't indent left-aligned stuff.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.168 1.169
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22548

Modified Files:
cterm.c
Log Message:
Fix Query Extended State information request (CSI=...n), broken in rev 1.162: no responses were being sent for a couple of different reasons (misplaced break and erroneous check of strcmp result).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.169 1.170
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2173

Modified Files:
cterm.c
Log Message:
Fix SOS temrination handling



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.170 1.171
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22332

Modified Files:
cterm.c
Log Message:
Major overhaul of ANSI parsing...

Instead of each control function having separate code to parse sequences,
use shared code which splits it into a structure and parses parameters.

This fixes all sorts of ANSI bugs with leading zeros, default values, etc.

Not all sequences have been updated yet, but I'll plug away at this slowly.

Now, instead of a couple sequences having broken parsing, and them all being broken in different ways, all sequences can be broken in the same way all at once.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.171 1.172
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv9896

Modified Files:
cterm.c
Log Message:
Use common parsing code for all the things.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.172 1.173
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv11278

Modified Files:
cterm.c
Log Message:
"Fix" warnings.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.173 1.174
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv13062

Modified Files:
cterm.c
Log Message:
Create a function to check a sequence for legality and delete SO MUCH copy pasta.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.174 1.175
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv14011

Modified Files:
cterm.c
Log Message:
Parameter strings not starting with <, =, >, or ? can not contain any of those characters.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.175 1.176
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv27808

Modified Files:
cterm.c
Log Message:
Add case and comment for all standard sequences.
Also, delineate standard from non-standard.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.178 1.179
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv20001

Modified Files:
cterm.c
Log Message:
Initial support for XTerm 256-color mode.

You can now use CSI [ 38 ; 5 ; X m to set the foreground colour, and
CSI [ 48 ; 5 ; X m to set the background colour from the palette and use
any of the 256 standard colours, any of the 16 Commodore 64 colours (start
at 256), or the two Atari colors (after the C64 colours). In addition,
you can use the palette redefinition commands to extend the palette past
those entries.

NOTE: Since this is only CTerm so far, using SyncTERM and UIFC features
will lose the palette blocks for the characters, and they will revert to
their current 16-color value. Further, I haven't testing how this interacts with alternat fonts, blinking, etc yet.

But it looks cool!


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.181 1.182
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv17109

Modified Files:
cterm.c
Log Message:
Fix out-of-bounds write in sequence parsing.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.182 1.183
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv14194

Modified Files:
cterm.c
Log Message:
Initial Sixel support...

List of known problems:
1) Does not support different aspect ratios. This is simple.
2) The VT-340 programmers manual says the default is to set all pixels,
but all the sample Sixel files I've found don't specify that and expect
zero bits to not be written. For now, we just never set the background
colour until we figure out what's up with that.
3) Line lengths don't seem to match up... maybe repeat is broken?
4) Sixel graphics will not cause scrolling... the bottom will be chopped off
if it reaches the bottom of the terminal.
5) Sixel graphics do not scroll... they sit where they were drawn until
overwritten by text boxes. They should scroll with the text.
6) The background clear thing in the raster attribute command isn't supported.
I want to figure out what's up with background and set all pixels before
I work on this.
7) Instead of parsing as it's read, it gets all the data in a string, then
parses the string... this is wasteful.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.183 1.184
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv14987

Modified Files:
cterm.c
Log Message:
Yep, it was repeat... graphics look good now.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.185 1.186
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2048

Modified Files:
cterm.c
Log Message:
Fix up cursor position after Sixels, and hide cursor while drawing.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.186 1.187
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5502

Modified Files:
cterm.c
Log Message:
Fix up the rest of the Sixel stuff... only three minor issues remain:

1) Instead of parsing as it's read, it gets all the data in a string, then
parses the string... this is wasteful. This is the toughest one to fix.
2) The background clear thing in the raster attribute command doesn't
work if the image scrolls. Somthing Must Be Done.
3) No save/restore pixel data, so menus and scrollback break images.
This one is fairly straightforward to fix.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.187 1.188
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv1499

Modified Files:
cterm.c
Log Message:
Only draw the background on the first pass of a sixel line... this seems to
be what is ment/expected.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.192 1.193
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv27231

Modified Files:
cterm.c
Log Message:
Set the height/width of the pixel buffer when erasing the sixel background.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.194 1.195
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv16762

Modified Files:
cterm.c
Log Message:
Make the mask big enough... should fix random memory clobbers and crashes
in sixel stuff.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.197 1.198
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv7475

Modified Files:
cterm.c
Log Message:
Added support for querying the current font/char dimenions (height;width)
with: CSI=3n
Replaced a couple \e's and %c with \x1b's.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.198 1.199
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22708

Modified Files:
cterm.c
Log Message:
Shift the palette up during cterm_write() operations... this prevents
palette stuff from messing with the display.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.199 1.200
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv27695

Modified Files:
cterm.c
Log Message:
Take BGBRIGHT and NOBRIGHT video flags into account when updating the 32-bit colour. In general, this should work as exepected, except if you use XTerm 256-colour extensions to set the colour to the current standard one, then adjust the appropriate flag, the colour will change. I don't know if that's expected or not to be honest.

Anyway, this fixes rendering of tcf - 22 - amidala.XB


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.202 1.203
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23078

Modified Files:
cterm.c
Log Message:
Fix scrollback foreground and background colours.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.204 1.205
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv26521

Modified Files:
cterm.c
Log Message:
Fix some errors in last commit


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.206 1.207
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2225

Modified Files:
cterm.c
Log Message:
Add CSI < Ps c command to query extended device attributes.

Sixel support, loadable fonts, etc.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.208 1.209
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv15347

Modified Files:
cterm.c
Log Message:
Remove unused stuff.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.209 1.210
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv17614

Modified Files:
cterm.c
Log Message:
We can get the mode from cio_api.mode directly.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.211 1.212
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv32071

Modified Files:
cterm.c
Log Message:
Ye olde bugs in last commit commit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.213 1.214
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv1256

Modified Files:
cterm.c
Log Message:
Fix CSI 7 m... how long has THAT been broken?



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.211 1.212
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv32071

Modified Files:
cterm.c
Log Message:
Ye olde bugs in last commit commit.

Having a heck of a time compiling after this commit:

...
make -C ../../smblib lib
make[2]: Entering directory '/home/noisome/sbbs/src/smblib'
make[2]: Nothing to be done for 'lib'.
make[2]: Leaving directory '/home/noisome/sbbs/src/smblib'
Linking gcc.linux.armv7l.exe.release/umonitor ../../conio/gcc.linux.armv7l.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write': cterm.c:(.text+0x59c6): undefined reference to `b64_decode' collect2: error: ld returned 1 exit status
GNUmakefile:29: recipe for target 'gcc.linux.armv7l.exe.release/umonitor' failed make[1]: *** [gcc.linux.armv7l.exe.release/umonitor] Error 1
make[1]: Leaving directory '/home/noisome/sbbs/src/sbbs3/umonitor' GNUmakefile:155: recipe for target 'umonitor' failed
make: *** [umonitor] Error 2

Looks like its not finding the base64.h/c in the necessary spots.

---
þ Synchronet þ Digital 52 BBS - digital52.com

src/conio cterm.c 1.214 1.215
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv11834

Modified Files:
cterm.c
Log Message:
We need to use pputtext() when clearing due to possiblity of 256-colour background


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/conio/cterm.c
By: Noisome to deuce on Sat Feb 10 2018 12:36 am

src/conio cterm.c 1.211 1.212
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv32071

Modified Files:
cterm.c
Log Message:
Ye olde bugs in last commit commit.

Having a heck of a time compiling after this commit:

...
make -C ../../smblib lib
make[2]: Entering directory '/home/noisome/sbbs/src/smblib'
make[2]: Nothing to be done for 'lib'.
make[2]: Leaving directory '/home/noisome/sbbs/src/smblib'
Linking gcc.linux.armv7l.exe.release/umonitor ../../conio/gcc.linux.armv7l.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write': cterm.c:(.text+0x59c6): undefined reference to `b64_decode' collect2: error: ld returned 1 exit status

Looks like its not finding the base64.h/c in the necessary spots.

Correct. It was moved from sbbs3 to smblib a while ago. If you just do "make clean all" that should fix ya up.

digital man

This Is Spinal Tap quote #39:
Airport Security Officer: Do you have any artificial plates or limbs?
Norco, CA WX: 63.0øF, 63.0% humidity, 3 mph ESE wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 02/10/18, Digital Man said the following...

Linking gcc.linux.armv7l.exe.release/umonitor ../../conio/gcc.linux.armv7l.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write': cterm.c:(.text+0x59c6): undefined reference to `b64_decode' collect2: error: ld returned 1 exit status
Looks like its not finding the base64.h/c in the necessary spots.

Correct. It was moved from sbbs3 to smblib a while ago. If you just do "make clean all" that should fix ya up.

I just tried a completely fresh start from CVS and got the same thing:

Linking gcc.linux.x64.exe.release/umonitor ../../conio/gcc.linux.x64.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write':
cterm.c:(.text+0x6615): undefined reference to `b64_decode'
collect2: error: ld returned 1 exit status
make[1]: *** [GNUmakefile:30: gcc.linux.x64.exe.release/umonitor] Error 1 make[1]: Leaving directory '/sbbs/src/sbbs3/umonitor'
make: *** [GNUmakefile:155: umonitor] Error 2

I looked at the command line the makefile is issuing where this fails: $(QUIET)$(CC) $(LDFLAGS) $(OBJS) -o $@ $(SMBLIB_LIBS) $(UIFC-MT_LIBS) $(CIOLIB-MT_LIBS) $(XPDEV-MT_LIBS)

Since ciolib uses b64_decode from smblib in cterm.c, it should come before smblib in the list in order for the linker to know it needs to grab b64_decode from smblib when it comes across it. After changing the order, umonitor now links.

Syncview also fails to link with the same error but doesn't have smblib in its list of libraries at all. Adding smblib after ciolib in that makefile allows
it to link as well.

--- Mystic BBS v1.12 A38 2018/01/01 (Linux/64)
* Origin: Subcarrier BBS (1:249/400)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/conio/cterm.c
By: John McCoy to Digital Man on Sun Feb 11 2018 06:48 pm

On 02/10/18, Digital Man said the following...

Linking gcc.linux.armv7l.exe.release/umonitor ../../conio/gcc.linux.armv7l.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write': cterm.c:(.text+0x59c6): undefined reference to `b64_decode' collect2: error: ld returned 1 exit status
Looks like its not finding the base64.h/c in the necessary spots.

Correct. It was moved from sbbs3 to smblib a while ago. If you just do "make clean all" that should fix ya up.

I just tried a completely fresh start from CVS and got the same thing:

Linking gcc.linux.x64.exe.release/umonitor ../../conio/gcc.linux.x64.lib.release/libciolib_mt.a(cterm.o): In function `cterm_write':
cterm.c:(.text+0x6615): undefined reference to `b64_decode'
collect2: error: ld returned 1 exit status
make[1]: *** [GNUmakefile:30: gcc.linux.x64.exe.release/umonitor] Error 1 make[1]: Leaving directory '/sbbs/src/sbbs3/umonitor'
make: *** [GNUmakefile:155: umonitor] Error 2

I looked at the command line the makefile is issuing where this fails: $(QUIET)$(CC) $(LDFLAGS) $(OBJS) -o $@ $(SMBLIB_LIBS) $(UIFC-MT_LIBS) $(CIOLIB-MT_LIBS) $(XPDEV-MT_LIBS)

Since ciolib uses b64_decode from smblib in cterm.c, it should come before smblib in the list in order for the linker to know it needs to grab b64_decode from smblib when it comes across it. After changing the order, umonitor now links.

Syncview also fails to link with the same error but doesn't have smblib in its list of libraries at all. Adding smblib after ciolib in that makefile allows
it to link as well.

Thanks and appreciate the analysis as well.

digital man

Synchronet/BBS Terminology Definition #31:
ISDN = Integrated Services Digital Network
Norco, CA WX: 54.5øF, 74.0% humidity, 0 mph SW wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.218 1.219
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv29577

Modified Files:
cterm.c
Log Message:
Fix replace_font() call using legacy font loading.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.219 1.220
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv4972

Modified Files:
cterm.c
Log Message:
Limit string sizes to 512MB This puts a cap of on the max asset size of 384MB



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.220 1.221
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5475

Modified Files:
cterm.c
Log Message:
Some SOS handling cleanup.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.222 1.223
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv24649

Modified Files:
cterm.c
Log Message:
First pass at supporting all the XTerm 38/48m sequences, specifically:

CSI 38 : 5 : X m
CSI 38 ; 5 : X m
CSI 38 ; 5 ; X m
CSI 38 : 2 : Z : R : G : B m
CSI 38 : 2 : R : G : B m
CSI 38 ; 2 : Z : R : G : B m
CSI 38 ; 2 : R : G : B m
CSI 38 ; 2 ; R ; G ; B m

X = palette slot
Z = colour space identifier (ignored)
R/G/B = Reg/Green/Blue values



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.226 1.227
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv17287

Modified Files:
cterm.c
Log Message:
Fix font loading... since setfont return value was inverted, check the
inverted value.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.227 1.228
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv21054

Modified Files:
cterm.c
Log Message:
Fix memory leak handling SOS.
-- coverity



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.228 1.229
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv21242

Modified Files:
cterm.c
Log Message:
Fix error handling unsupported 'n' FB sequences.
--coverity


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.229 1.230
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23357

Modified Files:
cterm.c
Log Message:
Coverity likes arrays to be passed to functions using arrays.
--coverity


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.230 1.231
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23626

Modified Files:
cterm.c
Log Message:
If we can't get the vmode, don't do sixel stuff.
--coverity


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.231 1.232
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23946

Modified Files:
cterm.c
Log Message:
More vmode value testing... all impossible.
--coverity


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.232 1.233
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv24284

Modified Files:
cterm.c
Log Message:
No no, that's how how you test something...



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.233 1.234
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv24544

Modified Files:
cterm.c
Log Message:
More vmode == -1 tests.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.234 1.235
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv3706

Modified Files:
cterm.c
Log Message:
Some bugs found by Coverity
Thanks Coverity!


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.235 1.236
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv5905

Modified Files:
cterm.c
Log Message:
Another bug
Thanks Coverity


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.236 1.237
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv10803

Modified Files:
cterm.c
Log Message:
"fix" "issue" found by scan-build.
Not impressed yet. :-)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.237 1.238
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv15373

Modified Files:
cterm.c
Log Message:
Fix potential NULL dereference on illegal strings commands.
Found by scan-build.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.238 1.239
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv16211

Modified Files:
cterm.c
Log Message:
Fix use of uninitialized value when more than 16 bits of colour channel information are specified in an xterm rgb: color definition.
Found by scan-build.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.239 1.240
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv20366

Modified Files:
cterm.c
Log Message:
Fix various useless assignments.
Thanks scan-build!



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.240 1.241
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23263

Modified Files:
cterm.c
Log Message:
Fix a large number of errors involving re-using an in-use index variable as
a temp variable. Mostly impacting the setting of video flags.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.241 1.242
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv3482

Modified Files:
cterm.c
Log Message:
Copy the current font one into the CTerm altfont array during cterm_init()

This should fix the issue with non-CP437 fonts reported by Kirkman.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/conio/cterm.c
By: deuce to CVS commit on Tue Apr 17 2018 11:33 pm

Copy the current font one into the CTerm altfont array during cterm_init() This should fix the issue with non-CP437 fonts reported by Kirkman.

It's definitely much better than it was yesterday but I'm still seeing some character glitches in game title screens.

There's a separate problem (which is what led me to compare 1.0 with 1.1b in the first place) where background colors don't get reset. Both versions have this problem. I'll send you screenshots for reference.

--Josh

////--------------------------------------------------
BiC -=- http://breakintochat.com -=- bbs wiki and blog

---
þ Synchronet

src/conio cterm.c 1.242 1.243
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv9250

Modified Files:
cterm.c
Log Message:
Translate C128 colour codes to CGA palette.
This may mess up colour hacks in other places, but should fix C128 colours
in the terminal.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.243 1.244
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv9744

Modified Files:
cterm.c
Log Message:
Add missing brace.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.244 1.245
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv29846

Modified Files:
cterm.c
Log Message:
Bug-fix for PETSCII modes: disable reverse video upon carriage-return (13). Should this also be done for 141 (shift-CR)? I'd love to know where you
found the document which inspired the comment ("disabled reverse") - but
the code just wasn't doing it and it was apparent when viewing PETSCII
art and comparing the behavior with other emulators.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.246 1.247
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv21320

Modified Files:
cterm.c
Log Message:
Implement DECRQSS for SCR.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.248 1.249
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv30728

Modified Files:
cterm.c
Log Message:
Fix sub-parameter parsing and extended color DECRPSS.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.250 1.251
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv6048/conio

Modified Files:
cterm.c
Log Message:
Various minor issues found by Coverity.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.251 1.252
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2820

Modified Files:
cterm.c
Log Message:
Fix vaious issues with saving extended colour codes.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.255 1.256
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv15348

Modified Files:
cterm.c
Log Message:
Fix error handling.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.262 1.263
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv1072

Modified Files:
cterm.c
Log Message:
Remove todo comment.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.263 1.264
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv3506

Modified Files:
cterm.c
Log Message:
Actually convert the y axis in coord_conv_xy().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.264 1.265
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv17340

Modified Files:
cterm.c
Log Message:
"Implement" Character Position Backward



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.267 1.268
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv30709

Modified Files:
cterm.c
Log Message:
Clean up sixel position init.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.271 1.272
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22895

Modified Files:
cterm.c
Log Message:
Fix nF sequence detection.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.272 1.273
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv30339

Modified Files:
cterm.c
Log Message:
Parse all valid sequences (which means suppressing them if not handled)
Various sixel fixes for sixel scroll mode.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.273 1.274
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2628

Modified Files:
cterm.c
Log Message:
Some bugs introduced by the sane coordinate changes...
Found by Coverity.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.274 1.275
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv24745

Modified Files:
cterm.c
Log Message:
Remove unneeded assignments.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.276 1.277
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv31933

Modified Files:
cterm.c
Log Message:
Fix *z parameter parsing.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.277 1.278
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv6761

Modified Files:
cterm.c
Log Message:
Fix ATASCII newline handling, broken in coord update



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.279 1.280
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv19154

Modified Files:
cterm.c
Log Message:
Fix PETSCII bug introduced a few days ago.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.281 1.282
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv7421

Modified Files:
cterm.c
Log Message:
Work around what appears to be semaphores racing with mutexes on Win32.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.282 1.283
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22426

Modified Files:
cterm.c
Log Message:
Fix dellines()



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.284 1.285
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv26509

Modified Files:
cterm.c
Log Message:
Fix CSI E and CSI F (were not going to column 1)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.286 1.287
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv9646

Modified Files:
cterm.c
Log Message:
Don't allow TAB to move to the next line.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/conio/cterm.c
By: deuce to CVS commit on Fri Apr 24 2020 06:59 pm

Don't allow TAB to move to the next line.

I'll move to the next line with whatever soft drink I choose!

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

src/conio cterm.c 1.288 1.289
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv31127

Modified Files:
cterm.c
Log Message:
Fix macro space query.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.292 1.293
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv18827

Modified Files:
cterm.c
Log Message:
Fix off-by-one in shift which caused a crash.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.293 1.294
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv13592

Modified Files:
cterm.c
Log Message:
Fix pixel-based checksum calculation.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.295 1.296
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv17465

Modified Files:
cterm.c
Log Message:
DECCKSR is documented incorrectly on the XTerm website. It's always
DSR Pn ! ~ x x x x ST



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.296 1.297
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv20742

Modified Files:
cterm.c
Log Message:
Fix out-of-bounds read in do_backtab().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.297 1.298
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv27756

Modified Files:
cterm.c
Log Message:
DECCKSR specifies upper-case hex digits.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.298 1.299
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv4975

Modified Files:
cterm.c
Log Message:
Fix tab handling code.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.299 1.300
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv20042

Modified Files:
cterm.c
Log Message:
memmove() for overlapping memory.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.300 1.301
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv28348

Modified Files:
cterm.c
Log Message:
Better cleanup of cterm sessions.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.301 1.302
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv27998

Modified Files:
cterm.c
Log Message:
Add separate term clreol()
Reset mouse state on terminal reset



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.302 1.303
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv2295

Modified Files:
cterm.c
Log Message:
Fix autowrap disable.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.303 1.304
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv22913

Modified Files:
cterm.c
Log Message:
Apply CSI t colours immediately.
Fixes issue with Pablo 24-bit colour ANSIs.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.304 1.305
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv30126

Modified Files:
cterm.c
Log Message:
Ensure cterm->strbuf is always NUL terminated (no functional change)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.306 1.307
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv16795

Modified Files:
cterm.c
Log Message:
Don't use a shadow palette unless CONIO_OPT_EXTENDED_PALETTE is set.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.308 1.309
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv12727

Modified Files:
cterm.c
Log Message:
Fix bug in last commit that resulted in C64 colours being broken for outputs with extended palettes.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.309 1.310
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23943

Modified Files:
cterm.c
Log Message:
Fix C128 40-column colour mapping. The palette was changed to match C64,
but the mapping wasn't.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.310 1.311
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv18057

Modified Files:
cterm.c
Log Message:
Fix weird font reset issue in PETSCII emulation.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio cterm.c 1.311 1.312
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv23370

Modified Files:
cterm.c
Log Message:
Fix the last fix so it's fixed.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ec06a1687a66ddd48fd6aa38
Modified Files:
src/conio/cterm.c
Log Message:
Fix issue with ATASCII delete/insert character.

Before the Unicode support was added, displaying a NUL would clear
the cell, but now it is translated. For ATASCII, this results in
a heart character being displayed instead of an empty cell when
inserting or deleting characters.

Fixes bug #28 on Sourceforge.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2f33ee734bc31462d7ce4e7f
Modified Files:
src/conio/cterm.c
Log Message:
Fix error on scroll with left/right margins

Scrolling would clear the line to the end of the screen, not the
end of the scrolling region.

Sorry echicken.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5abc5cdae5f652cf7a478b44
Modified Files:
src/conio/cterm.c
Log Message:
Ensure cleared block in in scrolling region

Do not clear at the current X/Y on scroll (derp)
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/37cdd991af1c54c30752bcc6
Modified Files:
src/conio/cterm.c
Log Message:
Add a UINT64_MAX hack for VS 2022

Not sure why this isn't defined from inttypes.h, but blah.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bb233b89b205ae98af9eacb6
Modified Files:
src/conio/cterm.c
Log Message:
Continue fixing a coverity issue.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1e9dcf477a5de94298f9bb74
Modified Files:
src/conio/cterm.c
Log Message:
Clamp sixel repeat to 0x7fff per specification.

This is the issue behind CVE-2022-24130 in xterm.
Reported against SyncTERM by Autumn Lamonte (Thanks!)
Discussion here: https://gitlab.com/klamonte/jexer/-/issues/105

Closes SyncTERM bug 79.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5c12fc2e5c7362a36fd68c23
Modified Files:
src/conio/cterm.c
Log Message:
Fix memory leak and uninitialized acces in sixel graphics.

Properly initialize sixel mask width/height.
Free sx_mask->bits when finished.

These were broken by the PPM feature commit 4975b41
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cda7525d78b0948996c19561
Modified Files:
src/conio/cterm.c
Log Message:
Fix off-by-one in delete lines

Previously, delete lines would erase the line above the current one.
This was visible in vim which makes extensive use of delete line
to scroll.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e5c75c3a8268961c2552edb9
Modified Files:
src/conio/cterm.c
Log Message:
Add comments to hopefully shut up Coverity
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/80379e9161895f4241bc30f3
Modified Files:
src/conio/cterm.c
Log Message:
Fix warning: ‘end’ may be used uninitialized in this function

Fix multiple warning: ignoring return value of ‘asprintf’
declared with attribute ‘warn_unused_result’
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1181333075e9674aad79ff3e
Modified Files:
src/conio/cterm.c
Log Message:
Fix for 80379e916

The commit just the zero-length behaviour from uninitialized use
with possible undefined behaviour to guaranteed undefined behaviour.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2f436df7f1606aa07ca81b1a
Modified Files:
src/conio/cterm.c
Log Message:
Fix macro recusion protection for macros 32-63.

Found by MSVC
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6621c97c34e6e1f193e45bb3
Modified Files:
src/conio/cterm.c
Log Message:
Disable MSVC warnings 4244 and 4267.

The alternative is to explicitly copy/paste the type everywhere
forcing the compiler to do the only thing it could possibly do,
and making it painful to change a type later.

Honestly, in my opinion, these warnings should just be disabled
completely everywhere.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/21c6201278ed7f0b9ee5f45e
Modified Files:
src/conio/cterm.c
Log Message:
Fix doorway mode.

CSI=255h was not entering doorway mode anymore.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dc2b586763a0c4a1be105efa
Modified Files:
src/conio/cterm.c
Log Message:
Use default instead of enum value in warning suppression.

This will hopefully keep both Coverity and compilers happy.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/28bfe4a1424f57bb6abf2f8a
Modified Files:
src/conio/cterm.c
Log Message:
When ANSI Music is enabled, CSI M with parameters is still delete line
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f209a29da73cb1da1bc7b4bf
Modified Files:
src/conio/cterm.c
Log Message:
Bump revision.

I need to document when I should do this better.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e8c6145d3d975d6157ec772d
Modified Files:
src/conio/cterm.c
Log Message:
Implement line editing support.

Changing "stuff" on a line will now propogate to the right
appropriately.

Next up is double-height characters... hopefully.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/252e539cc03a4411e4b52897
Modified Files:
src/conio/cterm.c
Log Message:
"Handle" malloc() failures

Just scream on stderr, and screw things up in the window.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76bf7cde63a9a19dfdb75034
Modified Files:
src/conio/cterm.c
Log Message:
Make the default Prestel ID 0 bytes long.

CCl4 sends an ENQ character in the login screen, and sends an ENQ
which will auto-fill your username. Also, if you enter six zeros
into the username, it will take you to the password field.

With ten zeros, this means it's impossible to log in to CCl4.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ab3cfcb1eb84576fe44740f
Modified Files:
src/conio/cterm.c
Log Message:
Fix up the Prestel "Engineering Test Page" rendering

This was due to two main bugs... the simple one was a type where
the cutoff between separated and contiguous mosaics was incorrect,
which caused the first four separated mosaics to not be displayed.

The second was due to a number of bugs in the Hold Mosaic
implementation.

This fixes the first half of issue 172.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/548763fda45f0d0db2bda11b
Modified Files:
src/conio/cterm.c
Log Message:
The final fixings for issue 172

Use 0 for "no held mosaic" to avoid confusion around printable bytes.
Store the state of the current cell *before* updating in fix_line()
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/348f1a7e91c6fbab5b81c9e9
Modified Files:
src/conio/cterm.c
Log Message:
Bump the CTerm revision.

Commands are added.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/110f23bfdda7e6f7c96f8f1c
Modified Files:
src/conio/cterm.c
Log Message:
Add some paranoia around size of macros.

Initially set 1MB as the max macro size. I can't imagine wanting
one bigger than this, but I can bump it up if needed.

This likely fixes a vulerability where the BBS could at least crash
SyncTERM, and at most take control of the users system. This
likely isn't the only place that needs bounds checks like this.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c08f1613744351338e822c30
Modified Files:
src/conio/cterm.c
Log Message:
Fix NULL dereference in strbuf error

If strbuf is over 5MB, or the realloc() fails, clear strbuf and
break before writing to strbuf.
Found by scan-build
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0b61127f46337d568bba8560
Modified Files:
src/conio/cterm.c
Log Message:
Set defaults for XTerm graphics query before checking

Fixes potential read of uninitialized data.
Found by scan-build
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/72b1a6ed7da07e08e677c471
Modified Files:
src/conio/cterm.c
Log Message:
Avoid read out of bounds in bad CSI m

In the CSI 38 : 2 : Z? : R : G : B m variant, if there was no
sub params (ie: CSI 38 : m), a read out of bounds would be
triggered.
Found by scan-build
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dc75bc36a58f294681a71856
Modified Files:
src/conio/cterm.c
Log Message:
Handle malicious sequences with 2147483648 parameters.

Previously, this could (but likely wouldn't) result in accesses
outside of allocated memory, doing Very Bad Things.
Found by scan-build
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5ff8b9fe668544911d33451b
Modified Files:
src/conio/cterm.c
Log Message:
Another NULL dereference after overrunning the string buf.

Found by scan-build
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9f6780d23478b6cb933d4949
Modified Files:
src/conio/cterm.c
Log Message:
Get strncat() and strnlen() out of the hot path...

Down to 4.7s now... 38× faster.
Starting to get somewhere useful now.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d308ae450e792921290484a5
Modified Files:
src/conio/cterm.c
Log Message:
Get strspn() out of the ANSI hot path.

This was the only standout issue when profiling the ANSI parsing
code, and is a trivial fix since we're pretty much only checking
contiguous ranges of characters.

Unfortunately, I didn't create a test for comparison here.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/274d038bd34c8da952533932
Modified Files:
src/conio/cterm.c
Log Message:
Fix race condition in starting/stopping playnote thread
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/51644d7992facd9e90a07b6a
Modified Files:
src/conio/cterm.c
Log Message:
Indicate not running before posting sem

Memory is free()ed after sem is posted, so this write goes into
lalaland.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c85d0cc939bffa1b1d30f1a1
Modified Files:
src/conio/cterm.c
Log Message:
retbuf paranoia

Reported in unmonitor, which always passes NULL.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ac92a69b18331da6083a68e2
Modified Files:
src/conio/cterm.c
Log Message:
Fix handling of C1 control characters

At the same time, fix an old error in prestel_handle_escaped() that
didn't pass the ctrl to prestel_apply_ctrl_after() properly, and
always flush the print buffer before calling prestel_handle_escaped()

We still shouldn't actually get C1 characters on a Prestel connection,
but if we do, at least we're doing the right thing now.

As for G1 characters, the default repetoire for these terminals per
ITU-T REC. T0101 is the mosaic character set with smoothed moasics,
something there's no evidence of a Prestel terminal ever supporting.
In order to implement those properly, I would need special handling
of "separated" in the renderer, and would need to fiddle with the
font to include the contiguous smoothed mosaics (and exclide the
separated ones). Since this would end up allowing wildly un-Pretel
behaviour (ie: mosaics without a mosaic escape) I'm inclined to
just treat them all as spaces and move on util/unless I do full
support for all the Videotex standards. Nobody has asked me to
open this can of worms, so I'm just going to leave it on the shelf.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1eb4ec043e73713ba2e9e4b2
Modified Files:
src/conio/cterm.c
Log Message:
Ignore invalid ESC sequences in Prestel mode
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bf58917b5e6a0c11203e127d
Modified Files:
src/conio/cterm.c
Log Message:
Clear cterm->sequence and cterm->escbuf when ignoring ESC
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7982c3cf4ad4cf07ae92d7ce
Modified Files:
src/conio/cterm.c
Log Message:
Switch back to ignoring unhandled C0 bytes.

This "feels" more like what the spec means.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1817c363cce0eb301f339cf0
Modified Files:
src/conio/cterm.c
Log Message:
Update comments for closer reading of the spec.

Section 2.3.1 is the C0 set, which "is not stored or displayed"
Section 2.3.2 is the C1 set, so interpret "all control characters"
in this context as meaning "all C1 characters".
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4ab569ff44a8501fbfd653f4
Modified Files:
src/conio/cterm.c
Log Message:
Some todone comments.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d6315867039caf232b681831
Modified Files:
src/conio/cterm.c
Log Message:
Mode 7 terminals (ie: Commstar) do not support cursor control

Specifically, \x11 is not cursor on, and \x14 is not cursor off.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ac68809c9d1f14f12b8fd6e1
Modified Files:
src/conio/cterm.c
Log Message:
Split Prestel from Beeb emulation parsing, add VDU 7, 23, and 31

Prestel and Beeb emulations are different enough that using a shared
switch statement doesn't really make sense.

This adds Mode 7 support for VDU commands 7 (beep), 23 (cursor only),
and 31 (move to X/Y, 0-based).

The rest of the unsupported commands don't seem overly useful in a
BBS context (disable/enable output) or I don't want to deal with
documenting and implementing ("Page mode").
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8379c1205104a28c7a10cee4
Modified Files:
src/conio/cterm.c
Log Message:
Character 127 in Beeb mode is destructive backspace.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/848602f4b2461e547f28bd31
Modified Files:
src/conio/cterm.c
Log Message:
Fix handling of translated blast-through mosaics

Since we're translating in ch[0], don't use buf[j] for mosaic or
we'll lose the translation we just did.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/852e6b7af4771259c2cb2904
Modified Files:
src/conio/cterm.c
Log Message:
A couple more Atari ST VT52 fixes...

FF and VT both move down one line, scrolling if necessary.

The rest of the unsupported control characters have no effect
(ie: work like NUL)

Delete shows the delta.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ca515cf3952ad14839b7d7e8
Modified Files:
src/conio/cterm.c
Log Message:
Fix blast-through glyphs for high mosaics.

The smooth mosaics aren't available with the SAA5050.
Nothing to see here.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cc07b354ec1912896a6bb546
Modified Files:
src/conio/cterm.c
Log Message:
Fix defaults for variable length sequences

Only SGR was impacted, but this explicitly sets the rest of the
defaults to zero.

Closes ticket 193.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cbe604acdd0303d821bb8770
Modified Files:
src/conio/cterm.c
Log Message:
CSI < c only takes one manditory argument with default

Fixes bug introduced in cc07b354 where the command without any
parameters would not return anything.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d90f4a4dad3ba0bbdaabb6cf
Modified Files:
src/conio/cterm.c
Log Message:
SGR has at least one (defaulted) parameter
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/38bd307bf3e777425f37b1d1
Modified Files:
src/conio/cterm.c
Log Message:
Fix Mode7 APS handling

The code is 0x1C, not 0x1E, and it's row then column.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/433eed47ed682016a43acef8
Modified Files:
src/conio/cterm.c
Log Message:
Atari ST doesn't support the VT-52 Ident command
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f6fbd8eac28330f9ecae607e
Modified Files:
src/conio/cterm.c
Log Message:
Only call xptone_complete() if there's foreground notes

Otherwise there's a race condition that will crash Win32 at least.
Fixes ticket 199.
---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net