1. Forum
  2. DOVE-Net
  3. Synchronet Programming C+

  • src/sbbs3/qwktomsg.cpp

    From rswindell@VERT to CVS commit on Wed Sep 2 00:46:35 2015
    src/sbbs3 qwktomsg.cpp 1.55 1.56
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10718

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Added xpDateTime_to_localtime() which behaves the way the xpDateTime_to_time() used to, that is, it stores the broken-down date/time values in the time_t equivalent for the local timezone, regardless of what value is in the zone element of the xpDateTime_t.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Nov 17 17:12:24 2016
    src/sbbs3 qwktomsg.cpp 1.59 1.60
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16663

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Address 2 QWK/REP-importing security issues:
    1. If QWKE was enabled for the QWKnet account on the Hub, a user could spoof
    their name with a "From:" QWKE kludge line in the message body. Fixed by
    not processing QWKE "From:" kludge lines at all, ever.
    2. If an @VIA kludge line was in the message body, it could over-ride the
    correct value from the HEADERS.DAT (oops). Really, the SENDERNET* lines
    in the HEADERS.DAT were always being overriden by either the @VIA kludge
    line (if present) or just the auto-genereated SENDERNET info (from the
    QWK-ID of the QWKnet account or hub. Normally, in a single hop QWKnet
    message, there will be no @VIA line, so spoofing is still possible in that
    case.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thu Oct 12 02:05:13 2017
    src/sbbs3 qwktomsg.cpp 1.61 1.62
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5335

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Fixed potential NULL-dereference in qwk_import_msg().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Dec 10 04:05:48 2017
    src/sbbs3 qwktomsg.cpp 1.63 1.64
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27215

    Modified Files:
    qwktomsg.cpp
    Log Message:
    When importing QWK messages from a QWKnet hub, parse/strip all QWK kludge
    lines - don't check the (invalid) sbbs_t:useron.qwk settings for QWKE
    support in this case (!).
    If you've been seeing the occasional message with "Subject:" as the first
    line followed by some @-kludge lines (e.g. @MSGID, @TZ, etc.) this would
    be the cause: you have QWKE support enabled on your hub BBS (e.g. VERT),
    which adds the "Subject:" kludge lines for subjects > 25 chars and when importing QWK messages from a *hub*, these lines weren't (normally) parsed/stripped.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Jan 31 15:44:18 2018
    src/sbbs3 qwktomsg.cpp 1.64 1.65
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23398

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Use thew new iniGetValue() function instead of iniGetString() when parsing
    QWK kludge lines - string literals should not be interpretted in these
    strings! Yes, you'll need to cvs-update xpdev/* too.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Feb 16 22:22:40 2019
    src/sbbs3 qwktomsg.cpp 1.69 1.70
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Add add_msg_ids() call when creating local msgs from QWK packets.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Aug 1 00:25:09 2019
    src/sbbs3 qwktomsg.cpp 1.74 1.75
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1965

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Don't treat 0xE3 as a UTF-8 char unless the message buffer is valid UTF-8.
    This should solve the problem of non-UTF-8 messages posted on non-up-to-date systems (no UTF-8 support), yet the message has a "charset=utf-8" in a MIME content-type header.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Aug 2 15:21:01 2019
    src/sbbs3 qwktomsg.cpp 1.76 1.77
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Added missing return true;


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Aug 11 23:27:47 2019
    src/sbbs3 qwktomsg.cpp 1.78 1.79
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23565

    Modified Files:
    qwktomsg.cpp
    Log Message:
    The QWKE spec (qwke.txt) says
    "kludges ... should be ... terminated by either a carriage return, or the (0xE3) QWK terminator" :-(


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 14 14:12:25 2019
    src/sbbs3 qwktomsg.cpp 1.79 1.80
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7960

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Fix bug in previous commit - a line is not a kludge line if it doesn't contain a CR *and* it doesn't contain a 0xE3 (QWK newline). <sigh>


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Aug 16 23:22:20 2019
    src/sbbs3 qwktomsg.cpp 1.80 1.81
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29977

    Modified Files:
    qwktomsg.cpp
    Log Message:
    If a message section HEADERS.DAT has the "utf8" field set to "true", set the MSG_HFIELDS_UTF8 flag in the auxattr header field to indicate UTF-8 encoding
    of message header fields.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 24 15:55:52 2019
    src/sbbs3 qwktomsg.cpp 1.81 1.82
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8587

    Modified Files:
    qwktomsg.cpp
    Log Message:
    If the QWK HEADERS.DAT indicates that a message is UTF-8, use \n-terminated lines in the QWK body (not '\xE3'), even if the message contains invalid
    UTF-8 character sequences.
    This likely fixes the recent issue with blank messages and QWK kludges being imported into body text.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 24 15:56:50 2019
    src/sbbs3 qwktomsg.cpp 1.82 1.83
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Fix typo in previous commit.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to rswindell on Sun Aug 25 20:02:44 2019
    Re: src/sbbs3/qwktomsg.cpp
    By: rswindell to CVS commit on Sat Aug 24 2019 03:55 pm

    qwktomsg.cpp
    Log Message:
    If the QWK HEADERS.DAT indicates that a message is UTF-8, use \n-terminated lines in the QWK body (not '\xE3'), even if the message contains invalid UTF-8 character sequences.
    This likely fixes the recent issue with blank messages and QWK kludges being imported into body text.

    I downloaded the current sbbs_dev.zip today (August 25th), but it looks like the binaries in there are from August 23rd.

    Nightfox

    ---
    þ Synchronet þ Digital Distortion: digitaldistortionbbs.com
  • From Digital Man@VERT to Nightfox on Mon Aug 26 00:47:06 2019
    Re: src/sbbs3/qwktomsg.cpp
    By: Nightfox to rswindell on Sun Aug 25 2019 08:02 pm

    Re: src/sbbs3/qwktomsg.cpp
    By: rswindell to CVS commit on Sat Aug 24 2019 03:55 pm

    qwktomsg.cpp
    Log Message:
    If the QWK HEADERS.DAT indicates that a message is UTF-8, use \n-terminated lines in the QWK body (not '\xE3'), even if the message contains invalid UTF-8 character sequences.
    This likely fixes the recent issue with blank messages and QWK kludges being imported into body text.

    I downloaded the current sbbs_dev.zip today (August 25th), but it looks like the binaries in there are from August 23rd.

    Yeah, there was a build failure this morning due to an untested commit. Hopefully tonights will go better.

    digital man

    This Is Spinal Tap quote #17:
    David St. Hubbins: It's such a fine line between stupid, and uh... and clever. Norco, CA WX: 73.6øF, 50.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to Digital Man on Mon Aug 26 10:01:04 2019
    Re: src/sbbs3/qwktomsg.cpp
    By: Digital Man to Nightfox on Mon Aug 26 2019 12:47 am

    Yeah, there was a build failure this morning due to an untested commit. Hopefully tonights will go better.

    I just downloaded sbbs_dev.zip and the timestamps have today's date.

    Nightfox

    ---
    þ Synchronet þ Digital Distortion: digitaldistortionbbs.com
  • From rswindell@VERT to CVS commit on Thu Apr 2 12:28:40 2020
    src/sbbs3 qwktomsg.cpp 1.83 1.84
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31007

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Strip any control characters from QWK-imported to/from/subject header fields.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 5 12:54:08 2020
    src/sbbs3 qwktomsg.cpp 1.84 1.85
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7784

    Modified Files:
    qwktomsg.cpp
    Log Message:
    SMBLIB functions return a signed int.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 5 17:35:51 2020
    src/sbbs3 qwktomsg.cpp 1.85 1.86
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15468

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Automatically detect the character set of QWK-imported messages (that don't already have a FidoNet "CHRS" header) and create/set the FIDOCHARS header field accordingly (UTF-8, ASCII, or CP437). This should resolve the issue I observed of QWK-posted messages on FidoNet with the wrong CHRS header value (i.e. CP437, when the message body in fact contained UTF-8).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue May 5 17:51:15 2020
    src/sbbs3 qwktomsg.cpp 1.86 1.87
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    qwktomsg.cpp
    Log Message:
    Resolve GCC warning: suggest parentheses around '&&' within '||'



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 14 23:17:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ef86978b3d5bfa3c39fdac13
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Update comment header block.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Nov 15 21:30:02 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ed1f4ab1828f06a5b2369200
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Initialize time zone variable (zone)

    As found and reported by Talisam author, apam (HAPPYLND).

    sscanf() won't initialize the buffer of the argument passed if the format string is not matched, so when there was no hexadecimal/SMB timezone value, the timezone specified in the ISO date/time string (if any) would be overwritten with 0, converted from the uninitialized 'zone' variable (unlikely to be valid hex-ASCII chars). Thanks apam!
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Apr 4 18:06:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/fa91e9074a14a892557b7606
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Default FTN charset to CP437 (not ASCII) for QWK-imported messages

    A QWKnet tagline usually contains CP437 character 254 and if/when appended to
    a message during export, would "convert" the message to CP437 thus making the "ASCII" charset advertisement incorrect.

    If a FIDO CHARSET value was already specified (e.g. in HEADERS.DAT), that
    value will (still) not be overridden. So the *original* import via QWK (before it gets exported to a QWKnet) is where this change will take effect.

    Fix for issue #741
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Sep 6 20:52:32 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/984c371ae383e19fcdb99cae
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Don't use QWK reply message date unless time zone is also specified

    For regular user QWK Relpy packet uploads only, if no timezone is specified (e.g. via @TZ kludge or HEADERS.DAT), then over-ride the message's "posted" date/time with the current date/time since we're going to set the message's timezone to the BBS's local timezone as well.

    This is a fix for issue #783 reported by Chris Jacobs.

    If/when we support user-specified timezones, then this likely would be a
    place where we'd want to use the user's timezone.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Apr 25 18:33:39 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/7e00f2c83dd512d9caf13bfb
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Create FTN charset of "ASCII 1" when the imported message is explicitly ASCII

    (e.g. via "Content-Type: text/plain; charset=US-ASCII" header field)

    ... previously we would default to "CP437" for the created FTN charset.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net