1. Forum
  2. DOVE-Net
  3. Synchronet Programming C+

  • src/sbbs3/logon.cpp

    From rswindell@VERT to CVS commit on Wed Oct 5 23:24:50 2016
    src/sbbs3 logon.cpp 1.62 1.63
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21554

    Modified Files:
    logon.cpp
    Log Message:
    Hangup the connection before returning false (logon failure) for several semi-normal cases (e.g. user does not have permissions for this node). Fixes "User not logged on" error.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sun Apr 15 18:32:23 2018
    src/sbbs3 logon.cpp 1.65 1.66
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4341

    Modified Files:
    logon.cpp
    Log Message:
    If the HappyBirthday text.dat line is blank, don't try to display it nor
    pause and CLS after.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Oct 25 20:40:25 2018
    src/sbbs3 logon.cpp 1.67 1.68
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20295

    Modified Files:
    logon.cpp
    Log Message:
    If the system is configure to not ask new user's if they have a color display, don't ask Guests (during logon) either.
    Removed some more WIP and HTMLterm support.
    Remove a couple unnecessary if (text[somethingQ][0]) checks.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Aug 14 18:16:44 2019
    src/sbbs3 logon.cpp 1.71 1.72
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11700

    Modified Files:
    logon.cpp
    Log Message:
    Log "Fast-Logon" (when user is using fast logon), rather than just "Logon".


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Sep 26 20:16:14 2019
    src/sbbs3 logon.cpp 1.72 1.73
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25570

    Modified Files:
    logon.cpp
    Log Message:
    When a Q-restricted account logs-in using a '*' prefix to their login name, toggle OFF the QWK-logon status. This allows QWKnet accounts to perform
    other non-QWK operations, like change their password.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Apr 4 20:16:45 2020
    src/sbbs3 logon.cpp 1.77 1.78
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24782

    Modified Files:
    logon.cpp
    Log Message:
    Use safe string operations. No functional change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 22 12:45:31 2020
    src/sbbs3 logon.cpp 1.78 1.79
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23090

    Modified Files:
    logon.cpp
    Log Message:
    Revert commit 1.61 from Aug-2015, use the documented behavior of the
    "Use Location in User List" option. When set to false, the user's *note* (not IP address) is to be included in the user/logon lists.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Sep 12 23:56:05 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/67edda7341b4d9a6a978eb69
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Automatically switch back from PETSCII to ANSI mode

    If the user's terminal was auto-detected as being ANSI, yet they had their account settings manually-overridden to use PETSCII, automatically switch
    back to auto-terminal mode (e.g. with ANSI).
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thu Sep 24 22:08:32 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't force password-changes for users with blank passwords (e.g. Guest)

    Wow. This is another one of those "forever bugs".
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From MRO@VERT/BBSESINF to Rob Swindell on Sat Sep 26 16:27:00 2020
    Re: src/sbbs3/logon.cpp
    By: Rob Swindell to Git commit to sbbs/master on Thu Sep 24 2020 10:08 pm

    https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53 Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't force password-changes for users with blank passwords (e.g. Guest)

    Wow. This is another one of those "forever bugs".

    aw man, i liked that one
    ---
    þ Synchronet þ ::: BBSES.info - free BBS services :::
  • From Rob Swindell@VERT to Git commit to sbbs/master on Mon Oct 12 08:50:48 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0a785fa5677d43760fbbad7a
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix birth month check during logon.

    New bug, reported by Melkor (STARFRON).
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Tue Nov 17 19:53:01 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/733ddc699d4b6c1a1ead869b
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    If all waiting-mail has been read, don't default to "Yes" read mail

    Count the read mail-waiting and compare to the total mail-waiting and if they're the same, then default to "No" for the "Read Your Mail Now" prompt during logon.

    Also, pass the difference (the unread mail) to the LiMailWaiting logon-info line.

    As requested by altere via I.R.C.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Tue Nov 17 20:59:39 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/721b6a54ebb9f0bf357b67dc
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix inverted logic of noyes() prompt in previous commit.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Jan 25 19:17:32 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3f17c245f7a2e514826e9a26
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't modify useron.misc during logon, even for AUTOTERM

    We shouldn't need to set any of the autoterm flags in useron.misc these days (term_supports() checks autoterm when appropriate).

    Try this Nelgin.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Jan 25 22:18:33 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/88cef39afc51baf131c5a41f
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Beautification of the previous commit

    And don't store the autoterm flags in useron.misc even when correcting a manual-PETSCII configuration.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 6 02:13:58 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f5fed0b229e70b79a5ebb330
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix access-control by terminal cap issue introduced a week ago

    In commit 3f17c245, I was addressing the issue reported by Nelgin via IRC: <nelgin> If you login using a term that doesn't support ansi, it changes your settings - can you set 'em back when done?
    <DigitalMan> if you have auto-term enabled, it doesn't actually change your settings, just what's in use during that session
    <nelgin> I logged in using my BBC emulator which doesn't do ansi, then when I logged in through syncterm, I got the display like it was on the BBC. All my characters replaced with #'s and stuff.
    <nelgin> I had to go back into the user menu to fix it. That is going to confuse users.

    However, the chk_ar() function in userdat.c which is used to populate JS objects (e.g. xtrn_area.sec_list[].prog_list[]) uses the user.misc value (cannot call term_supports()), so the current user terminal flags need to be reflected in user.misc always. So the real fix for the originally reported problem is to clear the charset-related terminal settings when logging in with auto-terminal settings enabled (and before the auto-detected charset flags are OR'd in).

    I toyed with the idea of storing a copy of the term_supports() result in client_t, which is passed to chk_ar() when appropriate, but decided that was a bit overkill and there were issues with servers that don't have term_supports (e.g. the web server) and properly populating access-controlled areas in the JS object model (e.g. door games that require ANSI). Better to use the last-auto-detected terminal caps than assuming "no" terminal capabilities in that scenario.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Thu Mar 2 18:56:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c0ef762adf57ff91307c3015
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Remove defunct files from batch download queue during logon

    If a user doesn't have access to download a file that's in their batch queue, remove it without saying anything to the user (but log a notice-level message about it) during logon. Files that no longer exist in the filebase are treated the same way.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Jul 24 17:21:26 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8266da9c329d2ba49ff2001c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Log an error if getstats() returns a failure

    I saw my logon.jsonl file getting cycled multiple times a day recently on Vert and suspect this function call may have been failing.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Jul 24 18:25:35 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e12c35049251dc97e8eafd7c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Log an error if getstats() returns a failure"

    This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.

    We're already passing a sock_init callback (ls_cb) which is supposed to set
    the socket options (call set_socket_options), so this change shouldn't be necessary and reportedly caused more issues binding ircd sockets when running ircd.js via jsexec (though I didn't see this myself).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Jul 24 18:27:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/46f1f80e75b30d477cdb419c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Revert "Log an error if getstats() returns a failure""

    This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.

    Wrong commit reverted. Oops.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Wed Sep 13 16:27:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/65f1df280bc72439e80b8a9f
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    A todo comment
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 4 18:45:55 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/cbf6a8b24c615e753801dbd2
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were

    I don't recall this actually being a thing, ever, so certainly no reason to
    be cleaning these files up during logon. <shrug>
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 26 23:07:48 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f315f34ce2c8b91e656fc5a4
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Change "On two nodes" to "On more than one node", since it's possible it's > 2 ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 26 23:22:29 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9544a3c6bf36555a2babc6bb
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't send NodeLoggedOn message to any nodes if user isn't being logged-on

    If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user).

    Reported by Nelgin.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Sep 20 00:03:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c345c6ad034f1e64db2b88de
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Clear the Guest user's language (lang) field during logon - revert to default ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Sep 22 16:57:13 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3bcf61744225d8898eae6a00
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Always close csts.ini file, even in error path (failure to open dsts.ini)

    Fix for CID 509720
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Nov 30 21:02:49 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/69e23e724e4e9dd2cd905b7d
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Move the backup of dsts.ini before opening the file

    Can't backup (make copies of) an open file.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3b602ca5349f2b4143ff27ab
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Check return value of getnodedat()

    Should fix CID 515599 since this seems to be the only place we call unlocknodedat() without possibly not owning the nodefile_mutex already.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 2 23:46:57 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b6b3e89091f941ab6ba3ea01
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Actually use the (first) shell we found that the user meets the requirements

    As discovered and reported by Deuce and Nelgin
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 16 22:06:53 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/437b1a13e91a9878480671d7
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't backup dsts.ini daily

    Looks like an unintentional debug-inclusion with commit 2064f3a4f71c6656693a1 as pointed about by Deuce in IRC.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu May 1 11:57:17 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/9eaeedc13950d1ec26af5963
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Do rollover daily stats (dsts.ini) if the previous date was Jan-1-1970 (never)

    Basically revert commit 2064f3a4f71c6656693a1d24fc63004c3c41aaea

    In a new install, the "Date" value in dsts.ini will be 0/Never and thus would never be rolled over (e.g. stats moved o csts.tab files).

    Since getstats() now reliably detects any read failures, we shouldn't need
    this as a work-around any more anyway - if the "date" field is 0, it just
    means a new install and it's expected.

    This should fix the issue reported by Basis where the ctrl/csts.tab and node*/csts.tab files were never created in fresh install of v3.20. A work around is to just set the Date field in the ctrl/dsts.ini file to the current date (one time).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon May 19 20:12:49 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/ae706b8054af1f291bfcd9ca
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't turn off the "ASCII only" user setting during logon

    ... when auto-terminal-type detection is enabled for the user

    Fix for issue #923
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Aug 17 12:51:57 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/53c42100db8385eb3a965888
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Better error reporting in logonstats()

    Eastside75 (THUNDER) is reporting that their daily statistics (ctrl/dsts.ini) file is never "rolled-over" and there are only a couple of potential errors
    in this function that could "silently fail" if the current date/time or the "Date" value in the dsts.ini file could not be converted to a broken-down date/time. So if either of those errors happen, log an error. It's unknown
    what the cause of Eastside75's issue is, but I wanted to at least eliminate these 2 possible errors (failures in calls to localtime_r()) as potential causes.

    Also, cleaned up a little using new dates_are_same() function, etc.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Dec 6 17:44:32 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/a51dd4dc5d08d22fee21c3c0
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    A blank ReadYourMailNowQ text.dat string will not defeat the Unread mail prompt

    I sbbs_t::noyes() will return true if this string is blank, so we didn't need check here now anyway.

    Setting ReadYourMailNowQ in text.dat to an empty string means this prompt
    won't be shown and the read messages will *not* be shown during logon.

    Setting ReadYourUnreadMailNowQ in text.dat to an empty string means this
    prompt won't be shown and any unread messages *will* be shown during logon (automatically).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Dec 6 19:20:50 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/377454c2db49f071cf24188c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    When displaying unread mail during logon, use user-preferred sort order

    Update to fix for feature request #1027
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net