1. Forum
  2. DOVE-Net
  3. Synchronet Programming C+

  • src/sbbs3/xmodem.c

    From rswindell@VERT to CVS commit on Sat Aug 24 02:07:45 2019
    src/sbbs3 xmodem.c 1.50 1.51
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16566

    Modified Files:
    xmodem.c
    Log Message:
    YMODEM/YMODEM-G:
    Purge any pending receive data before sending the YMODEM header block.
    This helps to insure that the next byte received from the receiver
    (ACK, NAK, 'C' or 'G') is an actual response to the header block we sent and not some other pending receiver start-request.

    The problem that was observed was upon YMODEM-G uploads to the BBS/sexyz, the receiver (sexyz) would send a few 'G's before the sender (e.g. SyncTERM)
    would get around to sending the YMODEM header block (while the user selects
    the file path/name to upload, takes a few seconds). The sender would see
    the first of these buffered 'G's received while selecting a file as an acknowledgement of the header block and then immediatley start sending file data. Meanwhile, the receiver sees incoming file data *before* he actually acknowledges the header block and throws it out as unexpectd data, so we're out-of-sync and with YMODEM-G there is no recovery/retry scheme.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 31 15:39:25 2019
    src/sbbs3 xmodem.c 1.51 1.52
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4369

    Modified Files:
    xmodem.c
    Log Message:
    Use the preferred US-English spelling of "Canceled".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Nov 30 02:01:41 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/d8cb42f85e8b14aee7ec52a6
    Modified Files:
    src/sbbs3/xmodem.c
    Log Message:
    Fix failure to recognize remote cancel if send buffer full.

    xmodem_cancel() would return an error if putcom() failed, *before*
    setting the "cancelled" [sic] flag. xmodem_cancel() in response to the
    receipt of a remote cancel request (^X character).
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Dec 4 00:17:14 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/c3619942a04c89f384c3cfc1
    Modified Files:
    src/sbbs3/xmodem.c
    Log Message:
    Change rev to 2.0.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Feb 20 15:11:24 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b92bf999e3800568eb4b3e3b
    Modified Files:
    src/sbbs3/xmodem.c
    Log Message:
    Don't do the double-EOT trick in "G-mode"

    Interesting, this is how this code worked back in 2005, but was changed without a good description of why:
    http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/xmodem.c?r1=1.15&r2=1.16

    This addresses the anonymous SyncTERM bug report: https://sourceforge.net/p/syncterm/tickets/46/

    Thanks, whoever that was. :-)
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 20 22:54:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/afd507165178361a0158544e
    Modified Files:
    src/sbbs3/xmodem.c
    Log Message:
    Default to *not* adding a delay to X/Ymodem uploads.
    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net